From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FAE4C04AA5 for ; Thu, 25 Aug 2022 07:47:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04A6F10E08D; Thu, 25 Aug 2022 07:47:29 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BB6710E08D for ; Thu, 25 Aug 2022 07:47:24 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 054785C010B; Thu, 25 Aug 2022 03:47:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 25 Aug 2022 03:47:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661413641; x= 1661500041; bh=8JWOzf32GRpIDkXSkVqxDewn7LWG2w+DtZqaLHYL6Mk=; b=l 8JoX4ibDUsCMUTjE6hXvNSd1F7ZiCtmby1NEHX7d/jgCiGmr/IWPftx9eNYUE4Hn yvspo6arUJA7r0pdnbxa1R4GAH+sDVkicesrpWjGGzh7l4B93c4iJo0OzpNd/5Jm 2txn5aUucAORn9ebKbM1/CsMN1YQd1kSxKpkkXdw99QkPIIv6lWLxO2Asxj4GbT8 uKC4tpTd6Sx/IXwoQnpUvg4LHpWvCoKLzYfVxHXMEUUDuNbYRIJsQPlegj3IgcFc DETjEfaB6odlJavHczRT5WcHy7ngWd6VspY8g1Lh4x969+cK7XL2GP4EB4vZ9kHK mpuzZujTx2mG27wuDOLDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661413641; x= 1661500041; bh=8JWOzf32GRpIDkXSkVqxDewn7LWG2w+DtZqaLHYL6Mk=; b=V R2pTT4dZgDH8Q1MRInhpVviTZjn4g9TgZycqA+1zRkO1Jh71GN58mkPS8Pzqfjdv +I+v4/2wxQH9jpOtjVSdP5hyfTTQXxjDdA7wljSFnU79v7i/fDSbUGrt4FvV3M3T d4dLWikBGAolNGJtLPrqaB9b8NgzQijTFMvEIPAcCmwEX6gf3PmYvHwxJ29u+JVW h4RQF3x+QFXVxmoI8BibwpB54hII9hGkCibbf0IhufaziKkHQOY1+5RT0MTYu9kg EF4KVaRV1F04EGFnFdY7nMpsDXgttG4oayOVQ8ouLpPMLOV2rGiy35ZwxASGTjGY ZRVD4869o/8uwTe0naqLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejvddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhggtgfgse htkeertdertdejnecuhfhrohhmpeforgigihhmvgcutfhiphgrrhguuceomhgrgihimhgv segtvghrnhhordhtvggthheqnecuggftrfgrthhtvghrnhepueeigefghfffffeifeehud eiuedvteegueefffevgfetvdffheehkeffvedufeeinecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Aug 2022 03:47:19 -0400 (EDT) From: Maxime Ripard To: airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de, dakr@redhat.com, mripard@kernel.org Subject: Re: [PATCH drm-misc-next v3 0/4] Fixes for vc4 hotplug rework Date: Thu, 25 Aug 2022 09:47:14 +0200 Message-Id: <166141363051.357827.14816951155409708010.b4-ty@cerno.tech> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220824161327.330627-1-dakr@redhat.com> References: <20220824161327.330627-1-dakr@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 24 Aug 2022 18:13:23 +0200, Danilo Krummrich wrote: > I've found a few potential issues left after the hotplug rework. > > In vc4_hdmi.c we're missing two mutex_unlock() calls when the device is > unplugged. > > vc4_crtc and vc4_plane seem to miss some drm_dev_enter()/drm_dev_exit() calls > to protect against resource access after the device/driver is unbound, but the > DRM potentially isn't freed yet and userspace can still call into the driver. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime