From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Jeffy Chen" <jeffy.chen@rock-chips.com>,
"Doug Anderson" <dianders@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
linux-rockchip@lists.infradead.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Stéphane Marchesin" <marcheu@chromium.org>
Subject: Re: [PATCH v3 3/6] dt-bindings: Add panel-timing subnode to simple-panel
Date: Thu, 01 Mar 2018 20:47:57 +0200 [thread overview]
Message-ID: <1788083.LjPZHSgKBb@avalon> (raw)
In-Reply-To: <20180208174855.55620-4-seanpaul@chromium.org>
Hi Sean,
Thank you for the patch.
On Thursday, 8 February 2018 19:48:50 EET Sean Paul wrote:
> This patch adds a new subnode to simple-panel allowing us to override
> the typical timing expressed in the panel's display_timing.
>
> Changes in v2:
> - Split out the binding into a new patch (Rob)
> - display-timings is a new section (Rob)
> - Use the full display-timings subnode instead of picking the timing
> out (Rob/Thierry)
> Changes in v3:
> - Go back to using the timing subnode directly, but rename to
> panel-timing (Rob)
>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Stéphane Marchesin <marcheu@chromium.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> .../bindings/display/panel/simple-panel.txt | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> b/Documentation/devicetree/bindings/display/panel/simple-panel.txt index
> 45a457ad38f0..7788b9ce160b 100644
> --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> @@ -12,6 +12,24 @@ Optional properties:
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel
>
> +panel-timing subnode
> +--------------------
> +
> +This optional subnode is for devices which require a mode differing from
> the
> +panel's "typical" display timing as programmed in the simple-panel driver.
Please don't refer to particular drivers in DT bindings.
> +Overriding the driver mode must only be done in the following scenario:
> + - The restrictions motivating the override cannot be applied to the
> platform's
> + display driver (ie: it must be specific to the device not the platform)
I find this quite ambiguous. I assume that "not the platform" refers to the
platform's display controller. "platform" without a qualifier is too vague, as
I expect the reason to override the mode will come from the platform's
specific interactions between the panel, the display controller, the other
display-related devices if any, and the PCB.
> + - The panel must not have a fixed mode attributed to it in the driver
I'm not sure to follow you here.
> + - The panel must provide at list one display_timing range by which the
> override
> + mode can be validated against
> + - The override mode will use the 'typ' values from the panel-timings
> subnode
The panel-timings subnode has no "typ" values. Do you mean that the
display_timing for the panel will have its "typ" values overridden by the
values contained in the panel-timing node ?
> + - You must provide all required properties for the panel-timing subnode
> +
> +Format information on the panel-timing subnode can be found in
> +display-timing.txt.
> +
> +
> Example:
>
> panel: panel {
> @@ -22,4 +40,16 @@ Example:
> enable-gpios = <&gpio 90 0>;
>
> backlight = <&backlight>;
> +
> + panel-timing {
> + clock-frequency = <266604720>;
> + hactive = <2400>;
> + hfront-porch = <48>;
> + hback-porch = <84>;
> + hsync-len = <32>;
> + vactive = <1600>;
> + vfront-porch = <3>;
> + vback-porch = <120>;
> + vsync-len = <10>;
> + };
> };
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-01 18:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 17:48 [PATCH v3 0/6] drm/panel: simple: Add mode support to devicetree Sean Paul
2018-02-08 17:48 ` [PATCH v3 1/6] dt-bindings: Clarify timing subnode use as panel-timing Sean Paul
2018-02-08 18:43 ` Rob Herring
2018-02-19 14:59 ` Thierry Reding
[not found] ` <20180208174855.55620-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-02-08 17:48 ` [PATCH v3 2/6] dt-bindings: Add headings to simple-panel bindings Sean Paul
[not found] ` <20180208174855.55620-3-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-02-08 18:44 ` Rob Herring
2018-02-08 17:48 ` [PATCH v3 3/6] dt-bindings: Add panel-timing subnode to simple-panel Sean Paul
[not found] ` <20180208174855.55620-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-02-08 18:45 ` Rob Herring
2018-02-19 15:09 ` Thierry Reding
2018-03-01 18:47 ` Laurent Pinchart [this message]
2018-02-08 17:48 ` [PATCH v3 4/6] drm/panel: simple: Add ability to override typical timing Sean Paul
2018-02-19 14:33 ` Enric Balletbo Serra
2018-02-19 15:25 ` Thierry Reding
2018-02-08 17:48 ` [PATCH v3 5/6] drm/panel: simple: Use display_timing for lq123p1jx31 Sean Paul
2018-02-19 14:34 ` Enric Balletbo Serra
2018-02-08 17:48 ` [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel Sean Paul
2018-02-19 14:34 ` Enric Balletbo Serra
2018-02-26 18:23 ` Doug Anderson
2018-04-24 14:31 ` Ezequiel Garcia
2018-04-24 23:02 ` Stéphane Marchesin
2018-04-25 4:29 ` Doug Anderson
2018-04-25 12:36 ` Ezequiel Garcia
2018-04-26 12:05 ` Thierry Reding
2018-04-26 15:29 ` Doug Anderson
2018-03-12 8:35 ` [PATCH v3 0/6] drm/panel: simple: Add mode support to devicetree Thierry Reding
2019-03-28 17:28 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1788083.LjPZHSgKBb@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).