dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, Dave Airlie <airlied@gmail.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/7] libdrm tests for hot-unplug feature
Date: Thu, 3 Jun 2021 23:31:09 -0400	[thread overview]
Message-ID: <191942ca-0773-758f-130d-17c0ad326fc2@amd.com> (raw)
In-Reply-To: <CADnq5_OJt6YUixqhfkvVq6RKACNYtEHNKb8wY1h+7d6G1a3P3Q@mail.gmail.com>


On 2021-06-03 10:53 p.m., Alex Deucher wrote:
> On Thu, Jun 3, 2021 at 9:37 PM Dave Airlie <airlied@gmail.com> wrote:
>> On Fri, 4 Jun 2021 at 07:20, Alex Deucher <alexdeucher@gmail.com> wrote:
>>> Please open a gitlab MR for these.
>>>
>> I'd really prefer these tests all get migrated out of here into igt. I
>> don't think libdrm_amdgpu really should have tests that test the
>> kernel level infrastructure.
>>


I am also a bit confused now what's the policy about libdrm - is it
being slowly deprecated ?
What tests should go to IGT and what to libdrm ?
The kernel feature itself is strictly amdgpu specific and not generic
DRM level feature - why then it's not a good fit for amdgpu tester ?


> We are providing equivalent patches for IGT as well.  There are some
> teams and customers that would prefer to stick with libdrm_amdgpu.


Here are the patches in my cloned gitlab repo - 
https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master
and I sent today for review to igt-dev@lists.freedesktop.org too.

Andrey


>
>> I know some people at AMD had issues in the past with igt because the
>> i might have stood for intel back in time, but at this point I think
>> we should be moving past that.
> I don't think that was ever an issue.  It's more that some teams built
> a bunch of infrastructure that used libdrm tests and haven't had the
> resources to switch to IGT yet.
>
> Alex

      reply	other threads:[~2021-06-04  3:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 20:16 [PATCH 0/7] libdrm tests for hot-unplug feature Andrey Grodzovsky
2021-06-01 20:16 ` [PATCH 1/7] tests/amdgpu: Fix valgrind warning Andrey Grodzovsky
2021-06-01 20:16 ` [PATCH 2/7] xf86drm: Add function to retrieve char device path Andrey Grodzovsky
2021-06-02  9:16   ` Simon Ser
2021-06-02 14:25     ` Andrey Grodzovsky
2021-06-01 20:16 ` [PATCH 3/7] test/amdgpu: Add helper functions for hot unplug Andrey Grodzovsky
2021-06-01 20:16 ` [PATCH 4/7] test/amdgpu/hotunplug: Add test suite for GPU unplug Andrey Grodzovsky
2021-06-01 20:17 ` [PATCH 5/7] test/amdgpu/hotunplug: Add basic test Andrey Grodzovsky
2021-06-01 20:17 ` [PATCH 6/7] tests/amdgpu/hotunplug: Add unplug with cs test Andrey Grodzovsky
2021-06-01 20:17 ` [PATCH 7/7] tests/amdgpu/hotunplug: Add hotunplug with exported bo test Andrey Grodzovsky
2021-06-02  7:59 ` [PATCH 0/7] libdrm tests for hot-unplug feature Daniel Vetter
2021-06-02 14:20   ` Andrey Grodzovsky
2021-06-03 14:22     ` Andrey Grodzovsky
2021-06-03 21:11       ` Daniel Vetter
2021-06-03 21:20         ` Alex Deucher
2021-06-03 21:20 ` Alex Deucher
2021-06-03 22:02   ` [PATCH 0/7] libdrm tests for hot-unplug fe goature Grodzovsky, Andrey
2021-06-04  2:26     ` Alex Deucher
2021-06-07 14:29       ` Andrey Grodzovsky
2021-06-04  1:37   ` [PATCH 0/7] libdrm tests for hot-unplug feature Dave Airlie
2021-06-04  2:53     ` Alex Deucher
2021-06-04  3:31       ` Andrey Grodzovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=191942ca-0773-758f-130d-17c0ad326fc2@amd.com \
    --to=andrey.grodzovsky@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).