From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B67C2D0DE for ; Fri, 13 Dec 2019 21:09:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AAF224671 for ; Fri, 13 Dec 2019 21:09:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AAF224671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1A6B6E09A; Fri, 13 Dec 2019 18:04:03 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AD476E09A for ; Fri, 13 Dec 2019 18:04:02 +0000 (UTC) Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifpIA-00036V-0l; Fri, 13 Dec 2019 19:03:54 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Vetter Subject: Re: [PATCH 06/10] drm/xrockchip: plane_state->fb iff plane_state->crtc Date: Fri, 13 Dec 2019 19:03:53 +0100 Message-ID: <1986448.RzC9sFZk56@diego> In-Reply-To: <20191213172612.1514842-6-daniel.vetter@ffwll.ch> References: <20191213172612.1514842-1-daniel.vetter@ffwll.ch> <20191213172612.1514842-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Daniel Vetter , Sandy Huang , DRI Development , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Freitag, 13. Dezember 2019, 18:26:08 CET schrieb Daniel Vetter: > Checking both is one too much, so wrap a WARN_ON around it to stope > the copypasta. > = > Signed-off-by: Daniel Vetter > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org patch subject should be "drm/rockchip" without the x, otherwise Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/dr= m/rockchip/rockchip_drm_vop.c > index d04b3492bdac..cecb2cc781f5 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -724,7 +724,7 @@ static int vop_plane_atomic_check(struct drm_plane *p= lane, > int max_scale =3D win->phy->scl ? FRAC_16_16(8, 1) : > DRM_PLANE_HELPER_NO_SCALING; > = > - if (!crtc || !fb) > + if (!crtc || WARN_ON(!fb)) > return 0; > = > crtc_state =3D drm_atomic_get_existing_crtc_state(state->state, crtc); > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel