From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
YueHaibing <yuehaibing@huawei.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
sebastian.reichel@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'
Date: Thu, 16 Apr 2020 09:32:24 +0300 [thread overview]
Message-ID: <1c9e1e60-5ff6-3ee7-e31e-e7cfb0cd279e@ti.com> (raw)
In-Reply-To: <20200415153959.GI4758@pendragon.ideasonboard.com>
On 15/04/2020 18:39, Laurent Pinchart wrote:
> Hi Yue,
>
> Thank you for the patch.
>
> On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
>> drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
>> warning: 'venc_config_pal_bdghi' defined but not used [-Wunused-const-variable=]
>> static const struct venc_config venc_config_pal_bdghi = {
>> ^~~~~~~~~~~~~~~~~~~~~
>>
>> It is never used, remove it.
>
> Tomi, is this the right fix, or should we work on making use of this
> structure ?
I think we can remove it. I'll pick you this patch.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-04-16 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 13:21 [PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi' YueHaibing
2020-04-15 15:39 ` Laurent Pinchart
2020-04-16 6:32 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c9e1e60-5ff6-3ee7-e31e-e7cfb0cd279e@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).