From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 047F1C2D0D1 for ; Mon, 6 Jan 2020 10:17:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D12392072C for ; Mon, 6 Jan 2020 10:17:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D12392072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26E946E220; Mon, 6 Jan 2020 10:17:08 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 240616E220 for ; Mon, 6 Jan 2020 10:17:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C1670B159; Mon, 6 Jan 2020 10:17:04 +0000 (UTC) Subject: Re: [PATCH RFC v1 2/6] drm/sprd: add Unisoc's drm kms master From: Thomas Zimmermann To: Kevin Tang , airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com References: <1576496419-12409-1-git-send-email-kevin3.tang@gmail.com> <1576496419-12409-3-git-send-email-kevin3.tang@gmail.com> Autocrypt: addr=tzimmermann@suse.de; keydata= mQENBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAG0J1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPokBVAQTAQgAPhYh BHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsDBQkDwmcABQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEGgNwR1TC3ojR80H/jH+vYavwQ+TvO8ksXL9JQWc3IFSiGpuSVXLCdg62AmR irxW+qCwNncNQyb9rd30gzdectSkPWL3KSqEResBe24IbA5/jSkPweJasgXtfhuyoeCJ6PXo clQQGKIoFIAEv1s8l0ggPZswvCinegl1diyJXUXmdEJRTWYAtxn/atut1o6Giv6D2qmYbXN7 mneMC5MzlLaJKUtoH7U/IjVw1sx2qtxAZGKVm4RZxPnMCp9E1MAr5t4dP5gJCIiqsdrVqI6i KupZstMxstPU//azmz7ZWWxT0JzgJqZSvPYx/SATeexTYBP47YFyri4jnsty2ErS91E6H8os Bv6pnSn7eAq5AQ0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRH UE9eosYbT6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgT RjP+qbU63Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+R dhgATnWWGKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zb ehDda8lvhFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r 12+lqdsAEQEAAYkBPAQYAQgAJhYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJbOdLgAhsMBQkD wmcAAAoJEGgNwR1TC3ojpfcIAInwP5OlcEKokTnHCiDTz4Ony4GnHRP2fXATQZCKxmu4AJY2 h9ifw9Nf2TjCZ6AMvC3thAN0rFDj55N9l4s1CpaDo4J+0fkrHuyNacnT206CeJV1E7NYntxU n+LSiRrOdywn6erjxRi9EYTVLCHcDhBEjKmFZfg4AM4GZMWX1lg0+eHbd5oL1as28WvvI/uI aMyV8RbyXot1r/8QLlWldU3NrTF5p7TMU2y3ZH2mf5suSKHAMtbE4jKJ8ZHFOo3GhLgjVrBW HE9JXO08xKkgD+w6v83+nomsEuf6C6LYrqY/tsZvyEX6zN8CtirPdPWu/VXNRYAl/lat7lSI 3H26qrE= Message-ID: <1ec4fe1e-ebd5-2c00-fbb0-bea8fffadc90@suse.de> Date: Mon, 6 Jan 2020 11:17:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, baolin.wang@linaro.org Content-Type: multipart/mixed; boundary="===============1724815211==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1724815211== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lHMJMfsGq9cSrOUUbQdv4L6jr7UFMUx0i" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lHMJMfsGq9cSrOUUbQdv4L6jr7UFMUx0i Content-Type: multipart/mixed; boundary="nT34rtugaKERXJqCUWbi4xEb3wXN9uJFL"; protected-headers="v1" From: Thomas Zimmermann To: Kevin Tang , airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com Cc: orsonzhai@gmail.com, baolin.wang@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, zhang.lyra@gmail.com Message-ID: <1ec4fe1e-ebd5-2c00-fbb0-bea8fffadc90@suse.de> Subject: Re: [PATCH RFC v1 2/6] drm/sprd: add Unisoc's drm kms master References: <1576496419-12409-1-git-send-email-kevin3.tang@gmail.com> <1576496419-12409-3-git-send-email-kevin3.tang@gmail.com> In-Reply-To: --nT34rtugaKERXJqCUWbi4xEb3wXN9uJFL Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 06.01.20 um 11:11 schrieb Thomas Zimmermann: > Hi Kevin >=20 > Am 16.12.19 um 12:40 schrieb Kevin Tang: >> From: Kevin Tang >> >> Adds drm support for the Unisoc's display subsystem. >> >> This is drm device and gem driver. This driver provides support for th= e >> Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. >> >> Cc: Orson Zhai >> Cc: Baolin Wang >> Cc: Chunyan Zhang >> Signed-off-by: Kevin Tang >> --- >> drivers/gpu/drm/Kconfig | 2 + >> drivers/gpu/drm/Makefile | 1 + >> drivers/gpu/drm/sprd/Kconfig | 14 ++ >> drivers/gpu/drm/sprd/Makefile | 8 ++ >> drivers/gpu/drm/sprd/sprd_drm.c | 286 +++++++++++++++++++++++++++++++= +++++++++ >> drivers/gpu/drm/sprd/sprd_drm.h | 16 +++ >> drivers/gpu/drm/sprd/sprd_gem.c | 178 +++++++++++++++++++++++++ >> drivers/gpu/drm/sprd/sprd_gem.h | 30 +++++ >> 8 files changed, 535 insertions(+) >> create mode 100644 drivers/gpu/drm/sprd/Kconfig >> create mode 100644 drivers/gpu/drm/sprd/Makefile >> create mode 100644 drivers/gpu/drm/sprd/sprd_drm.c >> create mode 100644 drivers/gpu/drm/sprd/sprd_drm.h >> create mode 100644 drivers/gpu/drm/sprd/sprd_gem.c >> create mode 100644 drivers/gpu/drm/sprd/sprd_gem.h >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index bfdadc3..cead12c 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -387,6 +387,8 @@ source "drivers/gpu/drm/aspeed/Kconfig" >> =20 >> source "drivers/gpu/drm/mcde/Kconfig" >> =20 >> +source "drivers/gpu/drm/sprd/Kconfig" >> + >> # Keep legacy drivers last >> =20 >> menuconfig DRM_LEGACY >> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile >> index 9f1c7c4..85ca211 100644 >> --- a/drivers/gpu/drm/Makefile >> +++ b/drivers/gpu/drm/Makefile >> @@ -122,3 +122,4 @@ obj-$(CONFIG_DRM_LIMA) +=3D lima/ >> obj-$(CONFIG_DRM_PANFROST) +=3D panfrost/ >> obj-$(CONFIG_DRM_ASPEED_GFX) +=3D aspeed/ >> obj-$(CONFIG_DRM_MCDE) +=3D mcde/ >> +obj-$(CONFIG_DRM_SPRD) +=3D sprd/ >> diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconf= ig >> new file mode 100644 >> index 0000000..79f286b >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/Kconfig >> @@ -0,0 +1,14 @@ >> +config DRM_SPRD >> + tristate "DRM Support for Unisoc SoCs Platform" >> + depends on ARCH_SPRD >> + depends on DRM && OF >> + select DRM_KMS_HELPER >> + select DRM_GEM_CMA_HELPER >> + select DRM_KMS_CMA_HELPER >> + select DRM_MIPI_DSI >> + select DRM_PANEL >> + select VIDEOMODE_HELPERS >> + select BACKLIGHT_CLASS_DEVICE >> + help >> + Choose this option if you have a Unisoc chipsets. >> + If M is selected the module will be called sprd-drm. >> \ No newline at end of file >> diff --git a/drivers/gpu/drm/sprd/Makefile b/drivers/gpu/drm/sprd/Make= file >> new file mode 100644 >> index 0000000..df0b316 >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/Makefile >> @@ -0,0 +1,8 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> + >> +ccflags-y +=3D -Iinclude/drm >> + >> +subdir-ccflags-y +=3D -I$(src) >> + >> +obj-y :=3D sprd_drm.o \ >> + sprd_gem.o >> \ No newline at end of file >> diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sp= rd_drm.c >> new file mode 100644 >> index 0000000..4aee25fa4 >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/sprd_drm.c >> @@ -0,0 +1,286 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2019 Unisoc Inc. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "sprd_drm.h" >> +#include "sprd_gem.h" >> + >> +#define DRIVER_NAME "sprd" >> +#define DRIVER_DESC "Spreadtrum SoCs' DRM Driver" >> +#define DRIVER_DATE "20191101" >> +#define DRIVER_MAJOR 1 >> +#define DRIVER_MINOR 0 >> + >> +static const struct drm_mode_config_helper_funcs sprd_drm_mode_config= _helper =3D { >> + .atomic_commit_tail =3D drm_atomic_helper_commit_tail_rpm, >> +}; >> + >> +static const struct drm_mode_config_funcs sprd_drm_mode_config_funcs = =3D { >> + .fb_create =3D drm_gem_fb_create, >> + .atomic_check =3D drm_atomic_helper_check, >> + .atomic_commit =3D drm_atomic_helper_commit, >> +}; >> + >> +static void sprd_drm_mode_config_init(struct drm_device *drm) >> +{ >> + drm_mode_config_init(drm); >> + >> + drm->mode_config.min_width =3D 0; >> + drm->mode_config.min_height =3D 0; >> + drm->mode_config.max_width =3D 8192; >> + drm->mode_config.max_height =3D 8192; >> + drm->mode_config.allow_fb_modifiers =3D true; >> + >> + drm->mode_config.funcs =3D &sprd_drm_mode_config_funcs; >> + drm->mode_config.helper_private =3D &sprd_drm_mode_config_helper; >> +} >> + >> +static const struct file_operations sprd_drm_fops =3D { >> + .owner =3D THIS_MODULE, >> + .open =3D drm_open, >> + .release =3D drm_release, >> + .unlocked_ioctl =3D drm_ioctl, >> + .compat_ioctl =3D drm_compat_ioctl, >> + .poll =3D drm_poll, >> + .read =3D drm_read, >> + .llseek =3D no_llseek, >> + .mmap =3D sprd_gem_mmap, >> +}; >> + >> +static struct drm_driver sprd_drm_drv =3D { >> + .driver_features =3D DRIVER_GEM | DRIVER_ATOMIC, >> + .fops =3D &sprd_drm_fops, >> + .gem_vm_ops =3D &drm_gem_cma_vm_ops, >> + .gem_free_object_unlocked =3D sprd_gem_free_object, >> + .dumb_create =3D sprd_gem_dumb_create, >> + .prime_fd_to_handle =3D drm_gem_prime_fd_to_handle, >> + .gem_prime_import =3D drm_gem_prime_import, >> + .gem_prime_import_sg_table =3D sprd_gem_prime_import_sg_table, >> + >> + .name =3D DRIVER_NAME, >> + .desc =3D DRIVER_DESC, >> + .date =3D DRIVER_DATE, >> + .major =3D DRIVER_MAJOR, >> + .minor =3D DRIVER_MINOR, >> +}; >> + >> +static int sprd_drm_bind(struct device *dev) >> +{ >> + struct drm_device *drm; >> + struct sprd_drm *sprd; >> + int err; >> + >> + drm =3D drm_dev_alloc(&sprd_drm_drv, dev); >> + if (IS_ERR(drm)) >> + return PTR_ERR(drm); >> + >> + dev_set_drvdata(dev, drm); >> + >> + sprd =3D devm_kzalloc(drm->dev, sizeof(*sprd), GFP_KERNEL); >> + if (!sprd) { >> + err =3D -ENOMEM; >> + goto err_free_drm; >> + } >> + drm->dev_private =3D sprd; >> + >> + sprd_drm_mode_config_init(drm); >> + >> + /* bind and init sub drivers */ >> + err =3D component_bind_all(drm->dev, drm); >> + if (err) { >> + DRM_ERROR("failed to bind all component.\n"); >> + goto err_dc_cleanup; >> + } >> + >> + /* vblank init */ >> + err =3D drm_vblank_init(drm, drm->mode_config.num_crtc); >> + if (err) { >> + DRM_ERROR("failed to initialize vblank.\n"); >> + goto err_unbind_all; >> + } >> + /* with irq_enabled =3D true, we can use the vblank feature. */ >> + drm->irq_enabled =3D true; >> + >> + /* reset all the states of crtc/plane/encoder/connector */ >> + drm_mode_config_reset(drm); >> + >> + /* init kms poll for handling hpd */ >> + drm_kms_helper_poll_init(drm); >> + >> + err =3D drm_dev_register(drm, 0); >> + if (err < 0) >> + goto err_kms_helper_poll_fini; >> + >> + return 0; >> + >> +err_kms_helper_poll_fini: >> + drm_kms_helper_poll_fini(drm); >> +err_unbind_all: >> + component_unbind_all(drm->dev, drm); >> +err_dc_cleanup: >> + drm_mode_config_cleanup(drm); >> +err_free_drm: >> + drm_dev_put(drm); >> + return err; >> +} >> + >> +static void sprd_drm_unbind(struct device *dev) >> +{ >> + drm_put_dev(dev_get_drvdata(dev)); >> +} >> + >> +static const struct component_master_ops sprd_drm_component_ops =3D {= >> + .bind =3D sprd_drm_bind, >> + .unbind =3D sprd_drm_unbind, >> +}; >> + >> +static int compare_of(struct device *dev, void *data) >> +{ >> + struct device_node *np =3D data; >> + >> + DRM_DEBUG("compare %s\n", np->full_name); >> + >> + return dev->of_node =3D=3D np; >> +} >> + >> +static int sprd_drm_component_probe(struct device *dev, >> + const struct component_master_ops *m_ops) >> +{ >> + struct device_node *ep, *port, *remote; >> + struct component_match *match =3D NULL; >> + int i; >> + >> + if (!dev->of_node) >> + return -EINVAL; >> + >> + /* >> + * Bind the crtc's ports first, so that drm_of_find_possible_crtcs()= >> + * called from encoder's .bind callbacks works as expected >> + */ >> + for (i =3D 0; ; i++) { >> + port =3D of_parse_phandle(dev->of_node, "ports", i); >> + if (!port) >> + break; >> + >> + if (!of_device_is_available(port->parent)) { >> + of_node_put(port); >> + continue; >> + } >> + >> + component_match_add(dev, &match, compare_of, port->parent); >> + of_node_put(port); >> + } >> + >> + if (i =3D=3D 0) { >> + dev_err(dev, "missing 'ports' property\n"); >> + return -ENODEV; >> + } >> + >> + if (!match) { >> + dev_err(dev, "no available port\n"); >> + return -ENODEV; >> + } >> + >> + /* >> + * For bound crtcs, bind the encoders attached to their remote endpo= int >> + */ >> + for (i =3D 0; ; i++) { >> + port =3D of_parse_phandle(dev->of_node, "ports", i); >> + if (!port) >> + break; >> + >> + if (!of_device_is_available(port->parent)) { >> + of_node_put(port); >> + continue; >> + } >> + >> + for_each_child_of_node(port, ep) { >> + remote =3D of_graph_get_remote_port_parent(ep); >> + if (!remote || !of_device_is_available(remote)) { >> + of_node_put(remote); >> + continue; >> + } else if (!of_device_is_available(remote->parent)) { >> + dev_warn(dev, "parent device of %s is not available\n", >> + remote->full_name); >> + of_node_put(remote); >> + continue; >> + } >> + >> + component_match_add(dev, &match, compare_of, remote); >> + of_node_put(remote); >> + } >> + of_node_put(port); >> + } >> + >> + return component_master_add_with_match(dev, m_ops, match); >> +} >> + >> +static int sprd_drm_probe(struct platform_device *pdev) >> +{ >> + int ret; >> + >> + ret =3D dma_set_mask_and_coherent(&pdev->dev, ~0); >> + if (ret) { >> + DRM_ERROR("dma_set_mask_and_coherent failed (%d)\n", ret); >> + return ret; >> + } >> + >> + return sprd_drm_component_probe(&pdev->dev, &sprd_drm_component_ops)= ; >> +} >> + >> +static int sprd_drm_remove(struct platform_device *pdev) >> +{ >> + component_master_del(&pdev->dev, &sprd_drm_component_ops); >> + return 0; >> +} >> + >> +static void sprd_drm_shutdown(struct platform_device *pdev) >> +{ >> + struct drm_device *drm =3D platform_get_drvdata(pdev); >> + >> + if (!drm) { >> + DRM_WARN("drm device is not available, no shutdown\n"); >> + return; >> + } >> + >> + drm_atomic_helper_shutdown(drm); >> +} >> + >> +static const struct of_device_id sprd_drm_match_table[] =3D { >> + { .compatible =3D "sprd,display-subsystem",}, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, sprd_drm_match_table); >> + >> +static struct platform_driver sprd_drm_driver =3D { >> + .probe =3D sprd_drm_probe, >> + .remove =3D sprd_drm_remove, >> + .shutdown =3D sprd_drm_shutdown, >> + .driver =3D { >> + .name =3D "sprd-drm-drv", >> + .of_match_table =3D sprd_drm_match_table, >> + }, >> +}; >> + >> +module_platform_driver(sprd_drm_driver); >> + >> +MODULE_AUTHOR("Leon He "); >> +MODULE_AUTHOR("Kevin Tang "); >> +MODULE_DESCRIPTION("Unisoc DRM KMS Master Driver"); >> +MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/gpu/drm/sprd/sprd_drm.h b/drivers/gpu/drm/sprd/sp= rd_drm.h >> new file mode 100644 >> index 0000000..137cb27 >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/sprd_drm.h >> @@ -0,0 +1,16 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Copyright (C) 2019 Unisoc Inc. >> + */ >> + >> +#ifndef _SPRD_DRM_H_ >> +#define _SPRD_DRM_H_ >> + >> +#include >> +#include >> + >> +struct sprd_drm { >> + struct drm_device *drm; >> +}; >> + >> +#endif /* _SPRD_DRM_H_ */ >> diff --git a/drivers/gpu/drm/sprd/sprd_gem.c b/drivers/gpu/drm/sprd/sp= rd_gem.c >> new file mode 100644 >> index 0000000..9aec78e >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/sprd_gem.c >> @@ -0,0 +1,178 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2019 Unisoc Inc. >> + */ >> + >> +#include >> +#include >> + >> +#include >> + >> +#include "sprd_drm.h" >> +#include "sprd_gem.h" >> + >> +static struct sprd_gem_obj *sprd_gem_obj_create(struct drm_device *dr= m, >> + unsigned long size) >> +{ >> + struct sprd_gem_obj *sprd_gem; >> + int ret; >> + >> + sprd_gem =3D kzalloc(sizeof(*sprd_gem), GFP_KERNEL); >> + if (!sprd_gem) >> + return ERR_PTR(-ENOMEM); >> + >> + ret =3D drm_gem_object_init(drm, &sprd_gem->base, size); >> + if (ret < 0) { >> + DRM_ERROR("failed to initialize gem object\n"); >> + goto error; >> + } >> + >> + ret =3D drm_gem_create_mmap_offset(&sprd_gem->base); >> + if (ret) { >> + drm_gem_object_release(&sprd_gem->base); >> + goto error; >> + } >> + >> + return sprd_gem; >> + >> +error: >> + kfree(sprd_gem); >> + return ERR_PTR(ret); >> +} >> + >> +void sprd_gem_free_object(struct drm_gem_object *obj) >> +{ >> + struct sprd_gem_obj *sprd_gem =3D to_sprd_gem_obj(obj); >> + >> + DRM_DEBUG("gem =3D %p\n", obj); >> + >> + if (sprd_gem->vaddr) >> + dma_free_wc(obj->dev->dev, obj->size, >> + sprd_gem->vaddr, sprd_gem->dma_addr); >> + else if (sprd_gem->sgtb) >> + drm_prime_gem_destroy(obj, sprd_gem->sgtb); >> + >> + drm_gem_object_release(obj); >> + >> + kfree(sprd_gem); >> +} >> + >> +int sprd_gem_dumb_create(struct drm_file *file_priv, struct drm_devic= e *drm, >> + struct drm_mode_create_dumb *args) >> +{ >> + struct sprd_gem_obj *sprd_gem; >> + int ret; >> + >> + args->pitch =3D DIV_ROUND_UP(args->width * args->bpp, 8); >> + args->size =3D round_up(args->pitch * args->height, PAGE_SIZE); >> + >> + sprd_gem =3D sprd_gem_obj_create(drm, args->size); >> + if (IS_ERR(sprd_gem)) >> + return PTR_ERR(sprd_gem); >> + >> + sprd_gem->vaddr =3D dma_alloc_wc(drm->dev, args->size, >> + &sprd_gem->dma_addr, GFP_KERNEL | __GFP_NOWARN | GFP_DMA); >=20 > I might be missing something, but I still don't understand why all this= > GEM code is necessary. I quickly compared with the CMA helpers and the > only meaningful difference is the use of the GFP_DMA flag. >=20 > Rather than duplicating the CMA code, it's better to change the CMA > helpers to provide a way of setting this flag. Further looking at the implementation of dma_alloc_wc(), the GFP_DMA flags get cleared unconditionally. [1] Best regards Thomas [1] https://elixir.bootlin.com/linux/latest/source/kernel/dma/mapping.c#L= 295 >=20 > Best regards > Thomas >=20 >> + if (!sprd_gem->vaddr) { >> + DRM_ERROR("failed to allocate buffer with size %llu\n", >> + args->size); >> + ret =3D -ENOMEM; >> + goto error; >> + } >> + >> + ret =3D drm_gem_handle_create(file_priv, &sprd_gem->base, &args->han= dle); >> + if (ret) >> + goto error; >> + >> + drm_gem_object_put_unlocked(&sprd_gem->base); >> + >> + return 0; >> + >> +error: >> + sprd_gem_free_object(&sprd_gem->base); >> + return ret; >> +} >> + >> +static int sprd_gem_object_mmap(struct drm_gem_object *obj, >> + struct vm_area_struct *vma) >> + >> +{ >> + int ret; >> + struct sprd_gem_obj *sprd_gem =3D to_sprd_gem_obj(obj); >> + >> + vma->vm_flags &=3D ~VM_PFNMAP; >> + vma->vm_pgoff =3D 0; >> + >> + ret =3D dma_mmap_wc(obj->dev->dev, vma, >> + sprd_gem->vaddr, sprd_gem->dma_addr, >> + vma->vm_end - vma->vm_start); >> + if (ret) >> + drm_gem_vm_close(vma); >> + >> + return ret; >> +} >> + >> +int sprd_gem_mmap(struct file *filp, struct vm_area_struct *vma) >> +{ >> + struct drm_gem_object *obj; >> + int ret; >> + >> + ret =3D drm_gem_mmap(filp, vma); >> + if (ret) >> + return ret; >> + >> + obj =3D vma->vm_private_data; >> + >> + return sprd_gem_object_mmap(obj, vma); >> +} >> + >> +int sprd_gem_prime_mmap(struct drm_gem_object *obj, >> + struct vm_area_struct *vma) >> +{ >> + int ret; >> + >> + ret =3D drm_gem_mmap_obj(obj, obj->size, vma); >> + if (ret) >> + return ret; >> + >> + return sprd_gem_object_mmap(obj, vma); >> +} >> + >> +struct sg_table *sprd_gem_prime_get_sg_table(struct drm_gem_object *o= bj) >> +{ >> + struct sprd_gem_obj *sprd_gem =3D to_sprd_gem_obj(obj); >> + struct sg_table *sgtb; >> + int ret; >> + >> + sgtb =3D kzalloc(sizeof(*sgtb), GFP_KERNEL); >> + if (!sgtb) >> + return ERR_PTR(-ENOMEM); >> + >> + ret =3D dma_get_sgtable(obj->dev->dev, sgtb, sprd_gem->vaddr, >> + sprd_gem->dma_addr, obj->size); >> + if (ret) { >> + DRM_ERROR("failed to allocate sg_table, %d\n", ret); >> + kfree(sgtb); >> + return ERR_PTR(ret); >> + } >> + >> + return sgtb; >> +} >> + >> +struct drm_gem_object *sprd_gem_prime_import_sg_table(struct drm_devi= ce *drm, >> + struct dma_buf_attachment *attach, struct sg_table *sgtb) >> +{ >> + struct sprd_gem_obj *sprd_gem; >> + >> + sprd_gem =3D sprd_gem_obj_create(drm, attach->dmabuf->size); >> + if (IS_ERR(sprd_gem)) >> + return ERR_CAST(sprd_gem); >> + >> + DRM_DEBUG("gem =3D %p\n", &sprd_gem->base); >> + >> + if (sgtb->nents =3D=3D 1) >> + sprd_gem->dma_addr =3D sg_dma_address(sgtb->sgl); >> + >> + sprd_gem->sgtb =3D sgtb; >> + >> + return &sprd_gem->base; >> +} >> diff --git a/drivers/gpu/drm/sprd/sprd_gem.h b/drivers/gpu/drm/sprd/sp= rd_gem.h >> new file mode 100644 >> index 0000000..b6740bd >> --- /dev/null >> +++ b/drivers/gpu/drm/sprd/sprd_gem.h >> @@ -0,0 +1,30 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Copyright (C) 2019 Unisoc Inc. >> + */ >> + >> +#ifndef _SPRD_GEM_H_ >> +#define _SPRD_GEM_H_ >> + >> +#include >> + >> +struct sprd_gem_obj { >> + struct drm_gem_object base; >> + dma_addr_t dma_addr; >> + struct sg_table *sgtb; >> + void *vaddr; >> +}; >> + >> +#define to_sprd_gem_obj(x) container_of(x, struct sprd_gem_obj, base)= >> + >> +void sprd_gem_free_object(struct drm_gem_object *gem); >> +int sprd_gem_dumb_create(struct drm_file *file_priv, struct drm_devic= e *dev, >> + struct drm_mode_create_dumb *args); >> +int sprd_gem_mmap(struct file *filp, struct vm_area_struct *vma); >> +int sprd_gem_prime_mmap(struct drm_gem_object *obj, >> + struct vm_area_struct *vma); >> +struct sg_table *sprd_gem_prime_get_sg_table(struct drm_gem_object *o= bj); >> +struct drm_gem_object *sprd_gem_prime_import_sg_table(struct drm_devi= ce *dev, >> + struct dma_buf_attachment *attach, struct sg_table *sgtb); >> + >> +#endif >> >=20 >=20 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --nT34rtugaKERXJqCUWbi4xEb3wXN9uJFL-- --lHMJMfsGq9cSrOUUbQdv4L6jr7UFMUx0i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl4TCRwACgkQaA3BHVML eiNv2ggAnooPtLKkKGP4odI9PntlrQdeYI4r6KB4fIDOVWcYdE3Z2XBuARuaQeII WZyIxfHkXoRUHJ+jGsoOQ36ib77rGagC9fCTKYIdhGvMDMn/VCtQ/i4HbT2T4REK x2a3IZQ04JN6Ip81v57PuelI9LbH/55XfsFGivYlMKPvM4sgOnvrvwfcjIWPneIV QTVmimtCGNkJ3X4t1VVUaKwGXbqLTszS/AiBBKGP6FYobHobzPvPGCUlMigfyHqN ow1AwBXVdi5zLFHVbu23SBodwBOxKDRRvkktiiBipYS9xE34JhRgDJXSG+2JPFXF inA8IzZZBQbK6DxSMXEvYzcS7YeTdQ== =PEHV -----END PGP SIGNATURE----- --lHMJMfsGq9cSrOUUbQdv4L6jr7UFMUx0i-- --===============1724815211== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1724815211==--