From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH 0/5] clean up radeon_asic.h v2 Date: Fri, 12 Mar 2010 10:25:56 +0100 Message-ID: <20100312092556.GA2686@barney.localdomain> References: <1268342358-7532-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1268342358-7532-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Daniel Vetter Cc: dri-devel@lists.sourceforge.net List-Id: dri-devel@lists.freedesktop.org On Thu, Mar 11, 2010 at 10:19:13PM +0100, Daniel Vetter wrote: > Hi all, > > All new patch pile to make radeon_asic.h into a real header file. Now all > the asic structs are gathered in the new radeon_asic.c file. > > Tested on my rv570. > > I've also added a new patch that gathers all r100 specific declarations > into radeon_asic.h (at least where it makes sense). This is just an example > to convince Jerome that radeon_asic.h might not be totally useless ;) > > Again, comments higly welcome. > > Yours, Daniel > I would merge patch 1 & 2 into a single patch, also i think you include radeon_asic.h at top of radeon.h so everyfile would also include radeon_asic.h that would be simplier than adding include to file and reduce the likelyhood to forget doing so in the future. (you might need to add forward declaration like struct radeon; at top of radeon_asic.h no biggy thought). Cheers, Jerome ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --