From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirill Smelkov Subject: Re: Major 2.6.38 / 2.6.39 / 3.0 regression ignored? Date: Tue, 9 Aug 2011 21:40:01 +0400 Message-ID: <20110809174001.GA23408@tugrik.mns.mnsspb.ru> References: <013811$4lfs6@fmsmga002.fm.intel.com> <201108091809.58425.anarsoul@gmail.com> <20110809153446.GA22077@tugrik.mns.mnsspb.ru> <201108091903.00071.anarsoul@gmail.com> <20110809163206.GA3410@tugrik.mns.mnsspb.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ray Lee Cc: "Rafael J. Wysocki" , Herbert Xu , Luke-Jr , intel-gfx@lists.freedesktop.org, LKML , dri-devel@lists.freedesktop.org, Andrew Morton , Linus Torvalds , Pekka Enberg List-Id: dri-devel@lists.freedesktop.org On Tue, Aug 09, 2011 at 09:56:01AM -0700, Ray Lee wrote: > On Tue, Aug 9, 2011 at 9:32 AM, Kirill Smelkov wrote: > > Quite frankly, I don't understand intel-gfx developers attitude: why is > > it me, just random user who is nitpicking here? Why there is no > > interest/will to analyze now obviously buggy/duplicate code and fix it? > = > Because they don't have an infinite amount of manpower.=A0Actual bugs > hitting actual users take precedence over 'cleanups' which always have > a chance of causing regressions, as you're well aware. Code churn for > the sake of abstract prettiness is discouraged, as it has a potential > cost for little potential gain. > = > If you like, submit a patch. You may now be more up-to-date on those > particular code paths than most of the intel-gfx developers. Ray, I'd agree with you if the topic was about cleanups. But here I was talking about copy-pasty commit which introduced regressions and bugs, and if now it's a user dilemma to either "clean up" it after developers himself, or accept that something is broken because developers lack manpower and so plug things in a hurry increasing entropy, I'd like to remind a good rule, at least to me one more time, not to break things in the first place. I'm not talking about cleanup here. I'm talking about original commit which introduced problems, and that there is no need to clean it up, but better revert and redo properly to avoid subsequent code churn in lots of fixes. Sorry, I won't submit a patch. If there is a need to find/fix/cleanup obvious things after company's developers, I have better things to do, and a todo item to re-evaluate hardware for my next project. Thanks, Kirill