From: Thierry Reding <thierry.reding@gmail.com>
To: Jianwei Wang <jianwei.wang@freescale.com>
Cc: devicetree@vger.kernel.org,
Xiubo Li <lixiubo@cmss.chinamobile.com>,
daniel.vetter@ffwll.ch, Alison Wang <b18965@freescale.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
scottwood@freescale.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 2/4] drm/panel: simple: Add support for NEC NL4827HC19-05B 480x272 panel
Date: Tue, 14 Jul 2015 12:53:30 +0200 [thread overview]
Message-ID: <20150714105328.GJ12465@ulmo.nvidia.com> (raw)
In-Reply-To: <1436784692-40560-2-git-send-email-jianwei.wang@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 3896 bytes --]
On Mon, Jul 13, 2015 at 06:51:30PM +0800, Jianwei Wang wrote:
> This adds support for the NEC NL4827HC19-05B 480x272 panel to the DRM
> simple panel driver.
>
> Signed-off-by: Alison Wang <b18965@freescale.com>
> Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
> Signed-off-by: Jianwei Wang <jianwei.wang@freescale.com>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> .../bindings/panel/nec,nl4827hc19_05b.txt | 7 ++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> MAINTAINERS | 1 -
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++
> 4 files changed, 34 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
>
> diff --git a/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt b/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
> new file mode 100644
> index 0000000..20e9473
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
> @@ -0,0 +1,7 @@
> +NEC LCD Technologies,Ltd. WQVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "nec,nl4827hc19_05b"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 8033919..9f22b3e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -131,6 +131,7 @@ mundoreader Mundo Reader S.L.
> murata Murata Manufacturing Co., Ltd.
> mxicy Macronix International Co., Ltd.
> national National Semiconductor
> +nec NEC LCD Technologies, Ltd.
> neonode Neonode Inc.
> netgear NETGEAR
> netlogic Broadcom Corporation (formerly NetLogic Microsystems)
This belongs in a separate patch.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fffb8c9..e191ded 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3410,7 +3410,6 @@ M: Alison Wang <alison.wang@freescale.com>
> L: dri-devel@lists.freedesktop.org
> S: Supported
> F: drivers/gpu/drm/fsl-dcu/
> -F: Documentation/devicetree/bindings/drm/fsl-dcu/
What's this doing here?
> F: Documentation/devicetree/bindings/panel/nec,nl4827hc19_05b.txt
>
> DRM DRIVERS FOR NVIDIA TEGRA
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index f94201b..eb12fe4 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1036,6 +1036,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
> .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> };
>
> +static const struct drm_display_mode nec_nl4827hc19_05b_mode = {
> + .clock = 10870,
> + .hdisplay = 480,
> + .hsync_start = 480 + 2,
> + .hsync_end = 480 + 2 + 41,
> + .htotal = 480 + 2 + 41 + 2,
> + .vdisplay = 272,
> + .vsync_start = 272 + 2,
> + .vsync_end = 272 + 2 + 4,
> + .vtotal = 272 + 2 + 4 + 2,
> + .vrefresh = 74,
> +};
> +
> +static const struct panel_desc nec_nl4827hc19_05b = {
> + .modes = &nec_nl4827hc19_05b_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 95,
> + .height = 54,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24
> +};
> +
Please keep these...
> static const struct of_device_id platform_of_match[] = {
> {
> .compatible = "ampire,am800480r3tmqwa1h",
> @@ -1125,6 +1148,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "shelly,sca07010-bfn-lnn",
> .data = &shelly_sca07010_bfn_lnn,
> }, {
> + .compatible = "nec,nl4827hc19_05b",
> + .data = &nec_nl4827hc19_05b,
> + }, {
and this sorted alphabetically.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-14 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 10:51 [PATCH v9 1/4] drm/layerscape: Add Freescale DCU DRM driver Jianwei Wang
2015-07-13 10:51 ` [PATCH v9 2/4] drm/panel: simple: Add support for NEC NL4827HC19-05B 480x272 panel Jianwei Wang
2015-07-14 10:53 ` Thierry Reding [this message]
2015-07-16 11:15 ` Wang J.W.
2015-07-13 10:51 ` [PATCH v9 3/4] arm/dts/ls1021a: Add DCU dts node Jianwei Wang
2015-07-14 10:59 ` Thierry Reding
2015-07-17 5:06 ` Wang J.W.
2015-07-13 10:51 ` [PATCH v9 4/4] arm/dts/ls1021a: Add a TFT LCD panel " Jianwei Wang
2015-07-14 10:49 ` [PATCH v9 1/4] drm/layerscape: Add Freescale DCU DRM driver Thierry Reding
2015-07-16 11:10 ` Wang J.W.
2015-07-16 11:31 ` Thierry Reding
2015-07-17 3:17 ` Wang J.W.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714105328.GJ12465@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=b18965@freescale.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianwei.wang@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).