From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 02/16] drm: Create Color Management DRM properties Date: Wed, 15 Jul 2015 15:25:12 +0200 Message-ID: <20150715132510.GH15045@ulmo.nvidia.com> References: <1436965780-6061-1-git-send-email-Kausal.Malladi@intel.com> <1436965780-6061-3-git-send-email-Kausal.Malladi@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1242132024==" Return-path: In-Reply-To: <1436965780-6061-3-git-send-email-Kausal.Malladi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Kausal Malladi Cc: annie.j.matheson@intel.com, dhanya.p.r@intel.com, dri-devel@lists.freedesktop.org, vijay.a.purushothaman@intel.com, hverkuil@xs4all.nl, jesse.barnes@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, susanta.bhattacharjee@intel.com List-Id: dri-devel@lists.freedesktop.org --===============1242132024== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="smOfPzt+Qjm5bNGJ" Content-Disposition: inline --smOfPzt+Qjm5bNGJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 15, 2015 at 06:39:26PM +0530, Kausal Malladi wrote: [...] > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 57ca8cc..408d39a 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -1178,6 +1178,12 @@ struct drm_mode_config { > struct drm_property *suggested_x_property; > struct drm_property *suggested_y_property; > =20 > + /* Color Management Properties */ > + struct drm_property *prop_color_capabilities; > + struct drm_property *prop_palette_before_ctm; > + struct drm_property *prop_palette_after_ctm; > + struct drm_property *prop_ctm; All existing properties are named *_property, and it'd be good to keep things consistent by following that scheme. Perhaps they could have a common prefix (cm_?) to group them? Thierry --smOfPzt+Qjm5bNGJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVpl8zAAoJEN0jrNd/PrOhT/EP/AzBZkerK1aOQ2B7UVXUiGXF 7r+tL3JXnd8sIY0i5eUsy3YHQpZG1qFqElcoc4nL1roXwjWMTj54AMe6VFgnX3FI jQ2F52geeteQ2vYgQIHnBoioMpraXfntsqdhQQOXiw6735/LN7AZjTwhRoEWzIpO asYu/UkgsOeiZStYF2BHSf09CG7BKvDKxBlW26Ykw3LUIfyP4v4+O3Y0g0fgQxgg 4PZX9gCuLQ4BIPcpR4DHG5HE5C2U9Iy1UmGfm4i5vP4XiPnYurE7Yl0QkwYvdGzl uD8UsUEQvWLJB+d4o2D5rIX12FgDXNIRwIz86e8FrR9Ce4fzDxKvZ3FW+7zolc5s siG+Vz1Q2SLcfWlDj3jYj2NtuvT5s1BjwNuxCT3RG+ZoELmhbIlylUbcDelsuOdK /f+uT1EGAWMbyPUSWbt9/yoVCXG9eGZb7hhuKTnKkQOVaSgpkOIGlyXoFMdVkRVZ T7/SFXQfprLYJyZJMARZAF7MFLZvz/huFr44dmAacAJN376zOmCkRLotPoYB7E8Y +ifWZs8Wv4QhkwXIRQKM9QksyAMwdBlM3GKXglsT+x9FJ8zt4AKOHheYZrXMohdQ SBe4Oqx/NS+U3ueGKGG5h1JUuoDjRKxEZX176u0AdDr8ans9v+dO9HO7GG9BqTqe kO+noMBPG6oYcYh24fvI =bNu8 -----END PGP SIGNATURE----- --smOfPzt+Qjm5bNGJ-- --===============1242132024== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1242132024==--