From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] drm/sysfs: Grab lock for edid/modes_show
Date: Thu, 19 Nov 2015 17:22:00 +0100 [thread overview]
Message-ID: <20151119162200.GM17050@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo51n7YXBoOgPer6=dJk80ppwktD6PWgmmgO4D37HESjkLQ@mail.gmail.com>
On Fri, Oct 02, 2015 at 01:08:40PM +0100, Emil Velikov wrote:
> On 2 October 2015 at 12:01, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > We chase pointers/lists without taking the locks protecting them,
> > which isn't that good.
> >
> > Fix it.
> >
> > v2: Actually unlock properly, spotted by Julia.
> >
> > v3: Put the label _before_ the mutex_unlock (Emil)
> >
> > Cc: Emil Velikov <emil.l.velikov@gmail.com>
> > Cc: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Patch does exactly what it says on the tin.
>
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-19 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 7:37 [PATCH] drm: Fix locking for sysfs dpms file Daniel Vetter
2015-09-29 7:56 ` Daniel Vetter
2015-09-29 13:30 ` Jani Nikula
2015-09-29 14:37 ` Jens Axboe
2015-09-29 8:06 ` [PATCH 1/3] drm/sysfs: Annote lockless show functions with READ_ONCE Daniel Vetter
2015-09-29 8:06 ` [PATCH 2/3] drm/sysfs: Grab lock for edid/modes_show Daniel Vetter
2015-10-02 8:39 ` [PATCH] " Daniel Vetter
2015-10-02 11:01 ` Daniel Vetter
2015-10-02 12:08 ` Emil Velikov
2015-11-19 16:22 ` Daniel Vetter [this message]
2015-10-02 15:02 ` Julia Lawall
2015-09-29 8:06 ` [PATCH 3/3] drm/sysfs: Nuke TV/DVI property files Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119162200.GM17050@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=julia.lawall@lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).