From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 14/29] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl Date: Mon, 23 Nov 2015 11:00:51 +0100 Message-ID: <20151123100051.GC31868@ulmo.nvidia.com> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> <1448271183-20523-15-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0888677217==" Return-path: In-Reply-To: <1448271183-20523-15-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0888677217== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bKyqfOwhbdpXa4YI" Content-Disposition: inline --bKyqfOwhbdpXa4YI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 23, 2015 at 10:32:47AM +0100, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > v2: Finally get rid of the copypasta from another commit in this > commit message. And convert to _unlocked like we need to (Patrik). >=20 > Cc: Patrik Jakobsson > Cc: Thierry Reding > Acked-by: Thierry Reding > Reviewed-by: Patrik Jakobsson > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/gem.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks. Thierry --bKyqfOwhbdpXa4YI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWUuPTAAoJEN0jrNd/PrOhYn8P/jAhGsfVVo6uQGIQUK+yMz+m PLRlsC35/yym4cKuLB606ND40ffCUSl569mRBuWIqbQDT3YKUQBhDdqBrkO6sdh2 EMz96onhvrgX0jzgEizfPMi7tc10jZOETh2KgeogWW7PlwmEdv0plbs2LJI3RvAQ UhtMly9jr/BKNSOsqU+g/du5VRylStoVdS2pdy/SWSqO0OaNJTCMQ1oUl0SNF8af STNnLAgx1Ga6iXQGCni8y+5opPBq8Y64yT6oNIdGLfRpyXAiKBT88RnNQCurYIyp gC56CDca6jdeiq4MOB03sTgVgFvQGTv2H7szNuivfu+S4phSvmjv7OnyaxexLDJU a3nXP9+1J+LV9xJDKbaWd9s/l+0+l+2X5YQwL/HTLi5WMBTjgFllXNdJ5w5q+Qwo iHZgrzYQpUq1vx9+WDQ+6PJue8kRwKsn6uwnzqO+r8NeeUhc5uArzRgpmvZtLSTt AFsOnmScj8XaxGnOR/dfOKfssqXAYc5YCmtoPPYT20XynhMU3UV1P4uE2CnH4VFP MrCz96RHSzMtZogc8hlqOzHgY3NB9EX5LOrpe5wze5R8UZ6QYpHGGSvrCVxtsBN7 /Twf4CopHLeJ9IOU0w5st5JVLXQpUtGN208ib72x6zPKxCmiSGmIDBnHHc7mSj8j FJXjzygDrtQbb6jqqNX8 =LIQj -----END PGP SIGNATURE----- --bKyqfOwhbdpXa4YI-- --===============0888677217== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0888677217==--