From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: simple: Add Innolux N133HSE panel support Date: Mon, 23 Nov 2015 12:26:47 +0100 Message-ID: <20151123112647.GA8911@ulmo.nvidia.com> References: <1447840063-8356-1-git-send-email-marex@denx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0679509224==" Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id B09D1721CC for ; Mon, 23 Nov 2015 03:26:50 -0800 (PST) Received: by pacdm15 with SMTP id dm15so188661006pac.3 for ; Mon, 23 Nov 2015 03:26:50 -0800 (PST) In-Reply-To: <1447840063-8356-1-git-send-email-marex@denx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marek Vasut Cc: Fabio Estevam , Shawn Guo , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0679509224== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 18, 2015 at 10:47:43AM +0100, Marek Vasut wrote: > From: Sean Cross >=20 > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an > integrated backlight, and connects via eDP. >=20 > It is used in the Kosagi Novena. >=20 > Signed-off-by: Sean Cross > Cc: Shawn Guo > Cc: Fabio Estevam > Cc: Thierry Reding > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) This is missing a device tree binding document. Otherwise looks good, except one minor nit below. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index f97b73e..d0fd427 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -856,6 +856,29 @@ static const struct panel_desc innolux_n116bge =3D { > }, > }; > =20 > +static const struct drm_display_mode innolux_n133hse_ea1_mode =3D { > + .clock =3D 138500, > + .hdisplay =3D 1920, > + .hsync_start =3D 1920 + 46, > + .hsync_end =3D 1920 + 46 + 30, > + .htotal =3D 1920 + 160, Can you split out the .htotal into its various components, for consistency with the entries for other panels? > + .vdisplay =3D 1080, > + .vsync_start =3D 1080 + 2, > + .vsync_end =3D 1080 + 2 + 4, > + .vtotal =3D 1080 + 32, Same for .vtotal here. Thierry --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWUvf2AAoJEN0jrNd/PrOhjJ4QAJ4KtCwFcbK7c8wnp7xHMD5Y h/EYmjWp3KocY/RrbHr0LTtV/xNudKk+6RSWSx6UE6KKp6/CiqFq+pRetTJMVEw9 hNx3C+HORb0Go+9Wh4tC9W+sgYEMaZR8kRlRNvsNWSiGj/SorYuIgRlQCoj5kSLc B45LgJD+p9lXfwRy/bfHkZRx4jmN8nGt2VcKkWxitLInWnFx1nv4IE9Rn4QzyW4j +5jjB/XJgcvSpFHoHUKWNeI1lz9nuyXslYXupzyBMR60zrgjb8gqURxzzqQWkAWf eChLSkcYewSk4gwuXPZpkRLfX8Q006OU7aUboifku3+q7JDmlS7WkQW6PfKKe+iA KMTK2+DgydA6MoL0m1R/O5hP71wT5QS7M0MS+cPuVgi13/WRfjjNCVzZjwNv5QUS rX3v5fc4Bc/0FCoiCoZFuIdAJByeji0tPbrcCzmtLW2jzlyYPluhhN8VBVfyVPNT B2dMhv3kMf4q4v8rsSrY0UL2GKHrsewhyg/sxz38Io0vpnyJdObUgSyqb154sDxS nE+TNo7cKyNtymo1Td5y5dJj5jhc9h3UkYjEedFL8Vh2RQ9ys/sHG7RqReO7WiYj anh6PQteDwdadWc8QQQ6A7bwIaN2Jo61H1+JmpNbZ5DhCFuz/D+4U0S20sKMddpb 87eywXSxuD7AXFtugYpS =piVu -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- --===============0679509224== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0679509224==--