From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/atomic-helper: Fix leak in disable_all
Date: Sat, 15 Jul 2017 13:03:15 +0200
Message-ID: <20170715110315.dzu6g67alw7mtq7n@phenom.ffwll.local>
References: <20170714224656.6431-1-daniel.vetter@ffwll.ch>
 <150011340734.13756.16671918664577003548@mail.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com
 [IPv6:2a00:1450:400c:c09::243])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 615406E905
 for <dri-devel@lists.freedesktop.org>; Sat, 15 Jul 2017 11:03:21 +0000 (UTC)
Received: by mail-wm0-x243.google.com with SMTP id j85so14836983wmj.0
 for <dri-devel@lists.freedesktop.org>; Sat, 15 Jul 2017 04:03:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <150011340734.13756.16671918664577003548@mail.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gU2F0LCBKdWwgMTUsIDIwMTcgYXQgMTE6MTA6MDdBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxNy0wNy0xNCAyMzo0Njo1NCkKPiA+IEBA
IC0yOTAyLDYgKzI5MDcsOCBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X2R1cGxpY2F0
ZWRfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4gICAgICAgICBzdHJ1
Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqbmV3X2Nvbm5fc3RhdGU7Cj4gPiAgICAgICAgIHN0cnVj
dCBkcm1fY3J0YyAqY3J0YzsKPiA+ICAgICAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdf
Y3J0Y19zdGF0ZTsKPiA+ICsgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHN0YXRlLT5k
ZXY7Cj4gPiArICAgICAgIGludCByZXQ7Cj4gPiAgCj4gPiAgICAgICAgIHN0YXRlLT5hY3F1aXJl
X2N0eCA9IGN0eDsKPiA+ICAKPiA+IEBAIC0yOTE0LDcgKzI5MjEsMTAgQEAgaW50IGRybV9hdG9t
aWNfaGVscGVyX2NvbW1pdF9kdXBsaWNhdGVkX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl
ICpzdGF0ZSwKPiA+ICAgICAgICAgZm9yX2VhY2hfbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0
ZSwgY29ubmVjdG9yLCBuZXdfY29ubl9zdGF0ZSwgaSkKPiA+ICAgICAgICAgICAgICAgICBzdGF0
ZS0+Y29ubmVjdG9yc1tpXS5vbGRfc3RhdGUgPSBjb25uZWN0b3ItPnN0YXRlOwo+ID4gIAo+ID4g
LSAgICAgICByZXR1cm4gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ID4gKyAgICAgICByZXQg
PSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gPiArICAgICAgIGRybV9hdG9taWNfY2xlYW5f
b2xkX2ZiKGRldiwgfjBVLCByZXQpOwo+IAo+IEkgaGF2ZSBubyBpZGVhIHdoYXQgdGhlIHJ1bGVz
IHNob3VsZCBiZSBoZXJlLiBPciBob3cgaXQgc2hvdWxkIGludGVyYWN0Cj4gd2l0aCBlcnJvci4g
U2hvdWxkIHdlIGp1c3QgdHJ5IHRoZSAiZHJtOiBUcmFjayBmcmFtZWJ1ZmZlciByZWZlcmVuY2Vz
IGF0Cj4gdGhlIHBvaW50IG9mIGFzc2lnbm1lbnQiIGFwcHJvYWNoIHRvIHNpbXBsaWZ5IHRoZSBy
dWxlcyAoYXQgbGVhc3QgZnJvbQo+IG15IHBlcnNwZWN0aXZlKT8gVGhlIHByb2JsZW0gd2l0aCB0
aGF0IHBhdGNoIGlzIHNvcnRpbmcgb3V0IHRoZSBzdGF0ZQo+IGR1cGxpY2F0aW9uIGRvbmUgaW4g
YSBjb3VwbGUgb2YgZHJpdmVycyBhbmQgZmlndXJpbmcgb3V0IGlmIHRoZXkgYXJlCj4gdHJhbnNm
ZXJyaW5nIG93bmVyc2hpcCBvciBub3QuCgpZZWFoIHRoaXMgaXMgYSBkZWNlbnQgbWVzcy4gSSB0
aGluayBhIGZpcnN0IGluY3JlbWVudGFsIHN0ZXAgd291bGQgYmUgdG8KbW92ZSB0aGUgLT5vbGRf
ZmIgYW5kIC0+ZmIgcmVmY291bnQgdXBkYXRpbmcgaW50byBkcm1fYXRvbWljX2NvbW1pdCAtCmNs
ZWFuX29sZF9mYiBpcyBhIHN1cGVyYmx5IG1pc25hbWVkIGZ1bmN0aW9uLCB3aGF0IGl0IHJlYWxs
eSBkb2VzIGlzCnVwZGF0ZSB0aGUgbGVnYWN5IGZyYW1lYnVmZmVyIHBvaW50ZXIgcmVmY291bnRz
LiBUaGUga2VybmVsLWRvYyBpdCBoYXMKYWxzbyBqdXN0IHNlcnZlcyB0byBpbmNyZWFzZSB0aGUg
Y29uZnVzaW9uIDotLwoKVGhlIG9ubHkgcHJvYmxlbSBpcyB0aGF0IGZvciBhbiBkcm1fYXRvbWlj
X2NvbW1pdCBpbiBvbmUgb2YgdGhlIGxlZ2FjeQpjYWxsYmFja3Mgd2UgbXVzdCBfbm90XyBkbyB0
aGF0LCBiZWNhdXNlIHRoZSBjb3JlIGFscmVhZHkgdGFrZXMgY2FyZSBmbwp0aGF0LiBCdXQgaGF2
aW5nIGEgZHJtX2F0b21pY19jb21taXRfbGVnYWN5IGZvciB0aGF0IHdvdWxkIGJlIGEgbG90CmNs
ZWFuZXIgSSB0aGluay4KCk9uY2Ugd2UgaGF2ZSB0aGF0IEkgZ3Vlc3Mgd2UgY291bGQgdHJ5IGFu
ZCBmaWd1cmUgb3V0IHdoYXQgdG8gZG8gd2l0aCB0aGUKcmVmY291bnRpbmcgb2YgdGhlIGxlZ2Fj
eSBwb2ludGVycyBhdCBsYXJnZS4KCk1lYW53aGlsZSB0aGUgcnVsZXMgYXJlOgotIElmIHlvdSBk
byBhbiBhdG9taWMgY29tbWl0LCB5b3UgbXVzdCBjYWxsIGNsZWFuX29sZF9mYi4gRXZlcnl3aGVy
ZS4gV2UKICBnb3QgYXdheSBpbiBhIGZldyBjYXNlcyBiZWNhdXNlIHdlJ3ZlIG1hZGUgbmljZSBz
eW1tZXRyaWMgY29tbWl0cyAobGlrZQogIHN1c3BlbmQvcmVzdW1lKSBvciBjb21taXRzIHdoZXJl
IHdlIGtub3cgdGhlIGZiIGRvZXNuJ3QgZ2V0IHVwZGF0ZWQuCgotIEV4Y2VwdGlvbjogV2hlbiBj
YWxsZWQgZnJvbSAtPnBsYW5lX3VwZGF0ZS9kaXNhYmxlLCAtPnNldF9jb25maWcgb3IKICAtPnBh
Z2VfZmxpcCwgdGhlIGNvcmUgZG9lcyBpdCBmb3IgeW91LgoKSXQncyBhIG1lc3MsIGJ1dCBJJ2Qg
bGlrZSB0byBkZWNvdXBsZSBmaXhpbmcgdGhhdCBtZXNzIGZyb20gZml4aW5nIHRoZQp1bmxvYWQg
YnVnIHdlIGhhdmUuIEknbGwgdHJ5IHRvIHR5cGUgdXAgdGhlIGRybV9hdG9taWNfY29tbWl0L19s
ZWdhY3kKcGF0Y2ggbmV4dCB3ZWVrLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl
IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu
ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl
ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK