From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: Marek Vasut <marex@denx.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked
Date: Tue, 18 Jul 2017 08:31:11 +0200 [thread overview]
Message-ID: <20170718063111.u5rej2lzwjzgixq3@phenom.ffwll.local> (raw)
In-Reply-To: <87k237c58i.fsf@eliezer.anholt.net>
On Mon, Jul 17, 2017 at 11:01:33AM -0700, Eric Anholt wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
> > CMA helpers are struct_mutex free, and so is the mxsfb itself. And
> > that's the only valid reason for using gem_free_object. Please read
> > the kerneldoc for this stuff :-)
>
> I'm sure all of these came from copy and paste, not the docs. That
> said, the CMA docs currently say:
>
> * Drivers using the CMA helpers should set this as their
> * &drm_driver.gem_free_object callback.
>
> If you drop the complaint about us reading the docs, the series is:
I did double-check the docs for the two hooks to make sure they explain
this, but forgot to check the one in the cma helpers. I'll follow-up with
a patch to rectify that.
> Reviewed-by: Eric Anholt <eric@anholt.net>
Thanks for your review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-07-18 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:10 [PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked Daniel Vetter
2017-07-17 15:10 ` [PATCH 2/3] drm/pl111: " Daniel Vetter
2017-07-17 15:10 ` [PATCH 3/3] drm/zte: " Daniel Vetter
2017-07-17 20:37 ` Sean Paul
2017-07-17 18:01 ` [PATCH 1/3] drm/mxsfb: " Eric Anholt
2017-07-18 6:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718063111.u5rej2lzwjzgixq3@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).