From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity Date: Thu, 20 Jul 2017 10:53:11 -0300 Message-ID: <20170720105311.147b2308@vento.lan> References: <20170626181226.29575-1-laurent.pinchart+renesas@ideasonboard.com> <20170626181226.29575-5-laurent.pinchart+renesas@ideasonboard.com> <7dbc0bcd-bc72-b45c-0fcd-56b0780880a9@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7dbc0bcd-bc72-b45c-0fcd-56b0780880a9@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org To: Kieran Bingham Cc: kieran.bingham@ideasonboard.com, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Em Thu, 13 Jul 2017 14:00:31 +0100 Kieran Bingham escreveu: > Hi Laurent, > > This looks like a good simplification/removal of obfuscation to me! > > On 26/06/17 19:12, Laurent Pinchart wrote: > > The internal VSP entity source and sink pointers are stored as > > media_entity pointers, which are then cast to a vsp1_entity. As all > > sources and sinks are vsp1_entity instances, we can store the > > vsp1_entity pointers directly. > > > > Signed-off-by: Laurent Pinchart > > Reviewed-by: Kieran Bingham Acked-by: Mauro Carvalho Chehab Thanks, Mauro