On Fri, Jul 14, 2017 at 11:13:53AM +0800, Chen-Yu Tsai wrote: > On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard > wrote: > > Some options were not padded as they should, and the order in the Makefile > > was chaotic. Fix that. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/sun4i/Makefile | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile > > index e29fd3a2ba9c..42871ee7acf6 100644 > > --- a/drivers/gpu/drm/sun4i/Makefile > > +++ b/drivers/gpu/drm/sun4i/Makefile > > @@ -1,23 +1,23 @@ > > -sun4i-drm-y += sun4i_drv.o > > -sun4i-drm-y += sun4i_framebuffer.o > > +sun4i-backend-y += sun4i_backend.o sun4i_layer.o > > > > -sun4i-drm-hdmi-y += sun4i_hdmi_enc.o > > -sun4i-drm-hdmi-y += sun4i_hdmi_ddc_clk.o > > -sun4i-drm-hdmi-y += sun4i_hdmi_tmds_clk.o > > +sun4i-drm-y += sun4i_drv.o > > +sun4i-drm-y += sun4i_framebuffer.o > > I don't think this applies on top of Jonathan's HDMI I2C patch > you already have queued up. > > Also you might want to leave a comment describe what the > ordering should be. Otherwise it will still be messed up > down the road. Good point, I'll do that, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com