From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Thu, 25 Oct 2018 11:33:14 +0200 Message-ID: <20181025093314.GB21967@phenom.ffwll.local> References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181023095508.21a9cabd@bbrezillon> <20181023134443.GQ324@phenom.ffwll.local> <20181025100931.50fddf7e@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBFA96E3AC for ; Thu, 25 Oct 2018 09:33:18 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id c15-v6so7800998eds.4 for ; Thu, 25 Oct 2018 02:33:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181025100931.50fddf7e@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: "Hollingworth, Gordon" , dri-devel@lists.freedesktop.org, Eben Upton List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMTA6MDk6MzFBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IE9uIFR1ZSwgMjMgT2N0IDIwMTggMTU6NDQ6NDMgKzAyMDAKPiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+IAo+ID4gT24gVHVlLCBPY3QgMjMsIDIwMTgg YXQgMDk6NTU6MDhBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gPiBIaSBEYW5p ZWwsCj4gPiA+IAo+ID4gPiBPbiBUdWUsIDE2IE9jdCAyMDE4IDE0OjU3OjQzICswMjAwCj4gPiA+ IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiA+ICAgCj4gPiA+ID4g T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMTE6NDA6NDVBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOiAgCj4gPiA+ID4gPiBUaGUgSFZTIGJsb2NrIGlzIHN1cHBvc2VkIHRvIGZpbGwgdGhl IHBpeGVsdmFsdmUgRklGT3MgZmFzdCBlbm91Z2ggdG8KPiA+ID4gPiA+IG1lZXQgdGhlIHJlcXVl c3RlZCBmcmFtZXJhdGUuIFRoZSBwcm9ibGVtIGlzLCB0aGUgSFZTIGFuZCBtZW1vcnkgYnVzCj4g PiA+ID4gPiBiYW5kd2lkdGhzIGFyZSBsaW1pdGVkLCBhbmQgaWYgd2UgZG9uJ3QgdGFrZSB0aGVz ZSBsaW1pdGF0aW9ucyBpbnRvCj4gPiA+ID4gPiBhY2NvdW50IHdlIG1pZ2h0IGVuZCB1cCB3aXRo IEhWUyB1bmRlcmZsb3cgZXJyb3JzLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGlzIHBhdGNoIGlz IHRyeWluZyB0byBtb2RlbCB0aGUgcGVyLXBsYW5lIEhWUyBhbmQgbWVtb3J5IGJ1cyBiYW5kd2lk dGgKPiA+ID4gPiA+IGNvbnN1bXB0aW9uIGFuZCB0YWtlIGEgZGVjaXNpb24gYXQgYXRvbWljX2No ZWNrKCkgdGltZSB3aGV0aGVyIHRoZQo+ID4gPiA+ID4gZXN0aW1hdGVkIGxvYWQgd2lsbCBmaXQg aW4gdGhlIEhWUyBhbmQgbWVtYnVzIGJ1ZGdldC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gTm90ZSB0 aGF0IHdlIHRha2UgYW4gZXh0cmEgbWFyZ2luIG9uIHRoZSBtZW1vcnkgYnVzIGNvbnN1bXB0aW9u IHRvIGxldAo+ID4gPiA+ID4gdGhlIHN5c3RlbSBydW4gc21vb3RobHkgd2hlbiBvdGhlciBibG9j a3MgYXJlIGRvaW5nIGhlYXZ5IHVzZSBvZiB0aGUKPiA+ID4gPiA+IG1lbW9yeSBidXMuIFNhbWUg Z29lcyBmb3IgdGhlIEhWUyBsaW1pdCwgZXhjZXB0IHRoZSBtYXJnaW4gaXMgc21hbGxlciBpbgo+ ID4gPiA+ID4gdGhpcyBjYXNlLCBzaW5jZSB0aGUgSFZTIGlzIG5vdCB1c2VkIGJ5IGV4dGVybmFs IGNvbXBvbmVudHMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJy ZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ ID4gPiBUaGlzIGxvZ2ljIGhhcyBiZWVuIHZhbGlkYXRlZCB1c2luZyBhIHNpbXBsZSBzaGVsbCBz Y3JpcHQgYW5kCj4gPiA+ID4gPiBzb21lIGluc3RydW1lbnRhdGlvbiBpbiB0aGUgVkM0IGRyaXZl cjoKPiA+ID4gPiA+IAo+ID4gPiA+ID4gLSBjYXB0dXJlIHVuZGVyZmxvdyBlcnJvcnMgYXQgdGhl IEhWUyBsZXZlbCBhbmQgZXhwb3NlIGEgZGVidWdmcyBmaWxlCj4gPiA+ID4gPiAgIHJlcG9ydGlu ZyB0aG9zZSBlcnJvcnMKPiA+ID4gPiA+IC0gYWRkIGRlYnVnZnMgZmlsZXMgdG8gZXhwb3NlIHdo ZW4gYXRvbWljX2NoZWNrIGZhaWxzIGJlY2F1c2Ugb2YgdGhlCj4gPiA+ID4gPiAgIEhWUyBvciBt ZW1idXMgbG9hZCBsaW1pdGF0aW9uIG9yIHdoZW4gaXQgZmFpbHMgZm9yIG90aGVyIHJlYXNvbnMK PiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhlIGJyYW5jaCBjb250YWluaW5nIHRob3NlIG1vZGlmaWNh dGlvbiBpcyBhdmFpbGFibGUgaGVyZSBbMV0sIGFuZCB0aGUKPiA+ID4gPiA+IHNjcmlwdCAod2hp Y2ggaXMgaW50ZXJuYWxseSB1c2luZyBtb2RldGVzdCkgaXMgaGVyZSBbMl0gKHBsZWFzZSBub3Rl Cj4gPiA+ID4gPiB0aGF0IEknbSBiYWQgYXQgd3JpdGluZyBzaGVsbCBzY3JpcHRzIDotKSkuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IE5vdGUgdGhhdCB0aG9zZSBtb2RpZmljYXRpb24gdGVuZCB0byBv dmVyLWVzdGltYXRlIHRoZSBsb2FkLCBhbmQgdGh1cwo+ID4gPiA+ID4gcmVqZWN0IHNldHVwcyB0 aGF0IG1pZ2h0IGhhdmUgcHJldmlvdXNseSB3b3JrZWQsIHNvIHdlIG1pZ2h0IHdhbnQgdG8KPiA+ ID4gPiA+IGFkanVzdCB0aGUgbGltaXRzIHRvIGF2b2lkIHRoYXQuCj4gPiA+ID4gPiAKPiA+ID4g PiA+IFsxXWh0dHBzOi8vZ2l0aHViLmNvbS9iYnJlemlsbG9uL2xpbnV4L3RyZWUvdmM0L2h2cy1i YW5kd2lkdGgtZXZhbAo+ID4gPiA+ID4gWzJdaHR0cHM6Ly9naXRodWIuY29tL2JicmV6aWxsb24v dmM0LWh2cy1iYW5kd2lkdGgtdGVzdCAgICAKPiA+ID4gPiAKPiA+ID4gPiBBbnkgaW50ZXJlc3Qg aW4gdXNpbmcgaWd0IHRvIHRlc3QgdGhpcyBzdHVmZj8gV2UgaGF2ZSBhdCBsZWFzdCBhIGJ1bmNo IG9mCj4gPiA+ID4gdGVzdHMgYWxyZWFkeSBpbiB0aGVyZSB0aGF0IHRyeSBhbGwga2luZHMgb2Yg cGxhbmUgc2V0dXBzLiBBbmQgd2UgdXNlCj4gPiA+ID4gdGhvc2UgdG8gaHVudCBmb3IgdW5kZXJy dW5zIG9uIGk5MTUgaHcuCj4gPiA+ID4gCj4gPiA+ID4gV3J0IHVuZGVycnVuIHJlcG9ydGluZzog T24gaTkxNSB3ZSBqdXN0IGR1bXAgdGhlbSBpbnRvIGRtZXNnIGF0IHRoZSBlcnJvcgo+ID4gPiA+ IGxldmVsLCB1c2luZyBEUk1fRVJST1IsICAKPiA+ID4gCj4gPiA+IEFyZSB5b3UgbWFza2luZyB0 aGUgdW5kZXJydW4gaW50ZXJydXB0IGFmdGVyIGl0J3MgYmVlbiByZXBvcnRlZD8gSWYgd2UKPiA+ ID4gZG9uJ3QgZG8gdGhhdCBvbiBWQzQgd2UganVzdCBlbmQgdXAgZmxvb2RpbmcgdGhlIGtlcm5l bC1sb2cgYnVmZmVyIHVudGlsCj4gPiA+IHNvbWVvbmUgY29tZXMgYW5kIHVwZGF0ZSB0aGUgY29u ZmlnLiAgCj4gPiAKPiA+IFllYWggd2UgZG8gdGhhdCB0b28uIFJ1bGUgaXMgdGhhdCBhIGZ1bGwg bW9kZXNldCB3aWxsIGNsZWFyIGFueSB1bmRlcnJ1bgo+ID4gbWFza2luZyAoc28gdGVzdHMgbmVl ZCB0byBtYWtlIHN1cmUgdGhleSBzdGFydCB3aXRoIGEgbW9kZXNldCwgb3IgaXQnbGwgYmUKPiA+ IGZvciBub3RoaW5nKS4KPiA+IAo+ID4gPiAgIAo+ID4gPiA+IHBsdXMgYSB0cmFjZXBvaW50LiBT ZWUgZS5nLgo+ID4gPiA+IGludGVsX3BjaF9maWZvX3VuZGVycnVuX2lycV9oYW5kbGVyKCkuIElm IHRoZXJlJ3MgaW50ZXJlc3Qgd2UgY291bGQKPiA+ID4gPiBwZXJoYXBzIGV4dHJhY3QgdGhpcyBp bnRvIHNvbWV0aGluZyBjb21tb24sIHNpbWlsYXIgdG8gd2hhdCB3YXMgZG9uZSB3aXRoCj4gPiA+ ID4gY3JjIHN1cHBvcnQgYWxyZWFkeS4KPiA+ID4gPiAgIAo+ID4gPiAKPiA+ID4gSSdtIG5vdCBh IGJpZyBmYW4gb2YgaGFyZGNvZGVkIHRyYWNlIHBvaW50cyBpbiBnZW5lcmFsIChiZWNhdXNlIG9m IHRoZQo+ID4gPiB3aG9sZSAiaXQncyBwYXJ0IG9mIHRoZSBzdGFibGUgQUJJIiB0aGluZyksIGFu ZCBpbiB0aGlzIGNhc2UsIG1ha2luZyB0aGUKPiA+ID4gdHJhY2Vwb2ludCBnZW5lcmljIHNvdW5k cyBldmVuIG1vcmUgcmlza3kgdG8gbWUuIEluZGVlZCwgaG93IGNhbiB3ZSBrbm93Cj4gPiA+IGFi b3V0IGFsbCB0aGUgSFcgc3BlY2lmaWMgYml0cyBvbmUgbWlnaHQgd2FudCB0byBleHBvc2UuIEZv ciBpbnN0YW5jZSwKPiA+ID4gSSBzZWUgdGhlIGludGVsIHVuZGVycnVuIHRyYWNlcG9pbnQgZXhw b3NlcyBhIHN0cnVjdCB3aXRoIGEgZnJhbWUgYW5kCj4gPiA+IHNjYW5saW5lIGZpZWxkLCBhbmQg QUZBSUNULCB3ZSBkb24ndCBoYXZlIHN1Y2ggaW5mb3JtYXRpb24gaW4gdGhlIFZDNAo+ID4gPiBj YXNlLgo+ID4gPiAKPiA+ID4gQW55IG9waW5pb24gb24gdGhhdD8gIAo+ID4gCj4gPiBJdCdzIG9u bHkgYWJpIGlmIHlvdSdyZSB1bmx1Y2t5LiBJZiBpdCdzIGp1c3QgZm9yIGRlYnVnZ2luZyBhbmQK PiA+IHZhbGlkYXRpb24sIHlvdSBjYW4gY2hhbmdlIGl0IGFnYWluLiBUYmgsIG5vIGlkZWEgd2h5 IHdlIGV2ZW4gaGF2ZSB0aGVzZQo+ID4gdHJhY2Vwb2ludHMsIHRoZXkncmUgZmFpcmx5IHVzZWxl c3MgaW1vLiBDSSBvbmx5IHJlbGllcyB1cG9uIHRoZSBkbWVzZwo+ID4gb3V0cHV0LiBNYXliZSBy dW4gZ2l0IGJsYW1lIGFuZCBhc2sgdGhlIG9yaWdpbmFsIGF1dGhvciwgd2UgY2FuIHByb2JhYmx5 Cj4gPiB1cGRhdGUgdGhlbSB0byBzdWl0IG91ciBuZWVkcy4KPiAKPiBPa2F5LCBJIHRoaW5rIEkn bGwgZ28gZm9yIGEgZ2VuZXJpYyBkZWJ1Z2ZzIGVudHJ5IHRoYXQgcmV0dXJucyB0cnVlCj4gd2hl biBhbiB1bmRlcnJ1biBlcnJvciBoYXBwZW5lZCBzaW5jZSB0aGUgbGFzdCBtb2Rlc2V0LCBmYWxz ZSBvdGhlcndpc2UuCj4gCj4gTmV4dCBxdWVzdGlvbiBpczogc2hvdWxkIEkgYXR0YWNoIHRoZSB1 bmRlcnJ1biBzdGF0dXMgdG8gdGhlIGRybV9kZXZpY2UKPiBvciBoYXZlIG9uZSBwZXIgQ1JUQz8g SW4gbXkgY2FzZSwgSSBvbmx5IGNhcmUgYWJvdXQgdGhlICJoYXMgYW4KPiB1bmRlcnJ1biBlcnJv ciBvY2N1cnJlZCBvbiBhbnkgb2YgdGhlIGFjdGl2ZSBDUlRDIiBjYXNlLCBzbyBJJ2Qgdm90ZSBm b3IKPiBhIHBlci1kZXZpY2UgdW5kZXJydW4gc3RhdHVzLgoKWWVhaCBwcm9iYWJseSBnb29kIGVu b3VnaC4gRm9yIG91ciBDSSBhbGwgd2UgY2FyZSBhYm91dCBpcyB0aGUgd2Fybi9lcnJvcgpsZXZl bCBkbWVzZyBvdXRwdXQuIEFueXRoaW5nIGF0IHRoYXQgbGV2ZWwgaXMgY29uc2lkZXJlZCBhIENJ IGZhaWx1cmUuCgpXaGF0IGRvIHlvdSBuZWVkIHRoZSBkZWJ1Z2ZzIGZpbGUgZm9yPwotRGFuaWVs Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK