From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Fri, 26 Oct 2018 15:57:48 +0200 Message-ID: <20181026155748.70b9a6bd@bbrezillon> References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181023095508.21a9cabd@bbrezillon> <20181023134443.GQ324@phenom.ffwll.local> <20181025100931.50fddf7e@bbrezillon> <20181025093314.GB21967@phenom.ffwll.local> <20181025114114.42caf97d@bbrezillon> <20181026133026.GM21967@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 91AF46E485 for ; Fri, 26 Oct 2018 13:57:50 +0000 (UTC) In-Reply-To: <20181026133026.GM21967@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: "Hollingworth, Gordon" , dri-devel@lists.freedesktop.org, Eben Upton List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNiBPY3QgMjAxOCAxNTozMDoyNiArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWxA ZmZ3bGwuY2g+IHdyb3RlOgoKPiBPbiBUaHUsIE9jdCAyNSwgMjAxOCBhdCAxMTo0MToxNEFNICsw MjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiBPbiBUaHUsIDI1IE9jdCAyMDE4IDExOjMz OjE0ICswMjAwCj4gPiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4g ICAKPiA+ID4gT24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMTA6MDk6MzFBTSArMDIwMCwgQm9yaXMg QnJlemlsbG9uIHdyb3RlOiAgCj4gPiA+ID4gT24gVHVlLCAyMyBPY3QgMjAxOCAxNTo0NDo0MyAr MDIwMAo+ID4gPiA+IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiA+ ID4gICAgIAo+ID4gPiA+ID4gT24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMDk6NTU6MDhBTSArMDIw MCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOiAgICAKPiA+ID4gPiA+ID4gSGkgRGFuaWVsLAo+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gT24gVHVlLCAxNiBPY3QgMjAxOCAxNDo1Nzo0MyArMDIwMAo+ ID4gPiA+ID4gPiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4gPiA+ ID4gPiAgICAgICAKPiA+ID4gPiA+ID4gPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAxMTo0MDo0 NUFNICswMjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6ICAgICAgCj4gPiA+ID4gPiA+ID4gPiBU aGUgSFZTIGJsb2NrIGlzIHN1cHBvc2VkIHRvIGZpbGwgdGhlIHBpeGVsdmFsdmUgRklGT3MgZmFz dCBlbm91Z2ggdG8KPiA+ID4gPiA+ID4gPiA+IG1lZXQgdGhlIHJlcXVlc3RlZCBmcmFtZXJhdGUu IFRoZSBwcm9ibGVtIGlzLCB0aGUgSFZTIGFuZCBtZW1vcnkgYnVzCj4gPiA+ID4gPiA+ID4gPiBi YW5kd2lkdGhzIGFyZSBsaW1pdGVkLCBhbmQgaWYgd2UgZG9uJ3QgdGFrZSB0aGVzZSBsaW1pdGF0 aW9ucyBpbnRvCj4gPiA+ID4gPiA+ID4gPiBhY2NvdW50IHdlIG1pZ2h0IGVuZCB1cCB3aXRoIEhW UyB1bmRlcmZsb3cgZXJyb3JzLgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBUaGlz IHBhdGNoIGlzIHRyeWluZyB0byBtb2RlbCB0aGUgcGVyLXBsYW5lIEhWUyBhbmQgbWVtb3J5IGJ1 cyBiYW5kd2lkdGgKPiA+ID4gPiA+ID4gPiA+IGNvbnN1bXB0aW9uIGFuZCB0YWtlIGEgZGVjaXNp b24gYXQgYXRvbWljX2NoZWNrKCkgdGltZSB3aGV0aGVyIHRoZQo+ID4gPiA+ID4gPiA+ID4gZXN0 aW1hdGVkIGxvYWQgd2lsbCBmaXQgaW4gdGhlIEhWUyBhbmQgbWVtYnVzIGJ1ZGdldC4KPiA+ID4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gTm90ZSB0aGF0IHdlIHRha2UgYW4gZXh0cmEgbWFy Z2luIG9uIHRoZSBtZW1vcnkgYnVzIGNvbnN1bXB0aW9uIHRvIGxldAo+ID4gPiA+ID4gPiA+ID4g dGhlIHN5c3RlbSBydW4gc21vb3RobHkgd2hlbiBvdGhlciBibG9ja3MgYXJlIGRvaW5nIGhlYXZ5 IHVzZSBvZiB0aGUKPiA+ID4gPiA+ID4gPiA+IG1lbW9yeSBidXMuIFNhbWUgZ29lcyBmb3IgdGhl IEhWUyBsaW1pdCwgZXhjZXB0IHRoZSBtYXJnaW4gaXMgc21hbGxlciBpbgo+ID4gPiA+ID4gPiA+ ID4gdGhpcyBjYXNlLCBzaW5jZSB0aGUgSFZTIGlzIG5vdCB1c2VkIGJ5IGV4dGVybmFsIGNvbXBv bmVudHMuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJv cmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gPiA+ID4gPiA+ ID4gLS0tCj4gPiA+ID4gPiA+ID4gPiBUaGlzIGxvZ2ljIGhhcyBiZWVuIHZhbGlkYXRlZCB1c2lu ZyBhIHNpbXBsZSBzaGVsbCBzY3JpcHQgYW5kCj4gPiA+ID4gPiA+ID4gPiBzb21lIGluc3RydW1l bnRhdGlvbiBpbiB0aGUgVkM0IGRyaXZlcjoKPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ ID4gLSBjYXB0dXJlIHVuZGVyZmxvdyBlcnJvcnMgYXQgdGhlIEhWUyBsZXZlbCBhbmQgZXhwb3Nl IGEgZGVidWdmcyBmaWxlCj4gPiA+ID4gPiA+ID4gPiAgIHJlcG9ydGluZyB0aG9zZSBlcnJvcnMK PiA+ID4gPiA+ID4gPiA+IC0gYWRkIGRlYnVnZnMgZmlsZXMgdG8gZXhwb3NlIHdoZW4gYXRvbWlj X2NoZWNrIGZhaWxzIGJlY2F1c2Ugb2YgdGhlCj4gPiA+ID4gPiA+ID4gPiAgIEhWUyBvciBtZW1i dXMgbG9hZCBsaW1pdGF0aW9uIG9yIHdoZW4gaXQgZmFpbHMgZm9yIG90aGVyIHJlYXNvbnMKPiA+ ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gVGhlIGJyYW5jaCBjb250YWluaW5nIHRob3Nl IG1vZGlmaWNhdGlvbiBpcyBhdmFpbGFibGUgaGVyZSBbMV0sIGFuZCB0aGUKPiA+ID4gPiA+ID4g PiA+IHNjcmlwdCAod2hpY2ggaXMgaW50ZXJuYWxseSB1c2luZyBtb2RldGVzdCkgaXMgaGVyZSBb Ml0gKHBsZWFzZSBub3RlCj4gPiA+ID4gPiA+ID4gPiB0aGF0IEknbSBiYWQgYXQgd3JpdGluZyBz aGVsbCBzY3JpcHRzIDotKSkuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IE5vdGUg dGhhdCB0aG9zZSBtb2RpZmljYXRpb24gdGVuZCB0byBvdmVyLWVzdGltYXRlIHRoZSBsb2FkLCBh bmQgdGh1cwo+ID4gPiA+ID4gPiA+ID4gcmVqZWN0IHNldHVwcyB0aGF0IG1pZ2h0IGhhdmUgcHJl dmlvdXNseSB3b3JrZWQsIHNvIHdlIG1pZ2h0IHdhbnQgdG8KPiA+ID4gPiA+ID4gPiA+IGFkanVz dCB0aGUgbGltaXRzIHRvIGF2b2lkIHRoYXQuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g PiA+IFsxXWh0dHBzOi8vZ2l0aHViLmNvbS9iYnJlemlsbG9uL2xpbnV4L3RyZWUvdmM0L2h2cy1i YW5kd2lkdGgtZXZhbAo+ID4gPiA+ID4gPiA+ID4gWzJdaHR0cHM6Ly9naXRodWIuY29tL2JicmV6 aWxsb24vdmM0LWh2cy1iYW5kd2lkdGgtdGVzdCAgICAgICAgCj4gPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+ID4gQW55IGludGVyZXN0IGluIHVzaW5nIGlndCB0byB0ZXN0IHRoaXMgc3R1ZmY/IFdl IGhhdmUgYXQgbGVhc3QgYSBidW5jaCBvZgo+ID4gPiA+ID4gPiA+IHRlc3RzIGFscmVhZHkgaW4g dGhlcmUgdGhhdCB0cnkgYWxsIGtpbmRzIG9mIHBsYW5lIHNldHVwcy4gQW5kIHdlIHVzZQo+ID4g PiA+ID4gPiA+IHRob3NlIHRvIGh1bnQgZm9yIHVuZGVycnVucyBvbiBpOTE1IGh3Lgo+ID4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFdydCB1bmRlcnJ1biByZXBvcnRpbmc6IE9uIGk5MTUgd2Ug anVzdCBkdW1wIHRoZW0gaW50byBkbWVzZyBhdCB0aGUgZXJyb3IKPiA+ID4gPiA+ID4gPiBsZXZl bCwgdXNpbmcgRFJNX0VSUk9SLCAgICAgIAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gQXJlIHlv dSBtYXNraW5nIHRoZSB1bmRlcnJ1biBpbnRlcnJ1cHQgYWZ0ZXIgaXQncyBiZWVuIHJlcG9ydGVk PyBJZiB3ZQo+ID4gPiA+ID4gPiBkb24ndCBkbyB0aGF0IG9uIFZDNCB3ZSBqdXN0IGVuZCB1cCBm bG9vZGluZyB0aGUga2VybmVsLWxvZyBidWZmZXIgdW50aWwKPiA+ID4gPiA+ID4gc29tZW9uZSBj b21lcyBhbmQgdXBkYXRlIHRoZSBjb25maWcuICAgICAgCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFll YWggd2UgZG8gdGhhdCB0b28uIFJ1bGUgaXMgdGhhdCBhIGZ1bGwgbW9kZXNldCB3aWxsIGNsZWFy IGFueSB1bmRlcnJ1bgo+ID4gPiA+ID4gbWFza2luZyAoc28gdGVzdHMgbmVlZCB0byBtYWtlIHN1 cmUgdGhleSBzdGFydCB3aXRoIGEgbW9kZXNldCwgb3IgaXQnbGwgYmUKPiA+ID4gPiA+IGZvciBu b3RoaW5nKS4KPiA+ID4gPiA+ICAgICAKPiA+ID4gPiA+ID4gICAgICAgCj4gPiA+ID4gPiA+ID4g cGx1cyBhIHRyYWNlcG9pbnQuIFNlZSBlLmcuCj4gPiA+ID4gPiA+ID4gaW50ZWxfcGNoX2ZpZm9f dW5kZXJydW5faXJxX2hhbmRsZXIoKS4gSWYgdGhlcmUncyBpbnRlcmVzdCB3ZSBjb3VsZAo+ID4g PiA+ID4gPiA+IHBlcmhhcHMgZXh0cmFjdCB0aGlzIGludG8gc29tZXRoaW5nIGNvbW1vbiwgc2lt aWxhciB0byB3aGF0IHdhcyBkb25lIHdpdGgKPiA+ID4gPiA+ID4gPiBjcmMgc3VwcG9ydCBhbHJl YWR5Lgo+ID4gPiA+ID4gPiA+ICAgICAgIAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gSSdtIG5v dCBhIGJpZyBmYW4gb2YgaGFyZGNvZGVkIHRyYWNlIHBvaW50cyBpbiBnZW5lcmFsIChiZWNhdXNl IG9mIHRoZQo+ID4gPiA+ID4gPiB3aG9sZSAiaXQncyBwYXJ0IG9mIHRoZSBzdGFibGUgQUJJIiB0 aGluZyksIGFuZCBpbiB0aGlzIGNhc2UsIG1ha2luZyB0aGUKPiA+ID4gPiA+ID4gdHJhY2Vwb2lu dCBnZW5lcmljIHNvdW5kcyBldmVuIG1vcmUgcmlza3kgdG8gbWUuIEluZGVlZCwgaG93IGNhbiB3 ZSBrbm93Cj4gPiA+ID4gPiA+IGFib3V0IGFsbCB0aGUgSFcgc3BlY2lmaWMgYml0cyBvbmUgbWln aHQgd2FudCB0byBleHBvc2UuIEZvciBpbnN0YW5jZSwKPiA+ID4gPiA+ID4gSSBzZWUgdGhlIGlu dGVsIHVuZGVycnVuIHRyYWNlcG9pbnQgZXhwb3NlcyBhIHN0cnVjdCB3aXRoIGEgZnJhbWUgYW5k Cj4gPiA+ID4gPiA+IHNjYW5saW5lIGZpZWxkLCBhbmQgQUZBSUNULCB3ZSBkb24ndCBoYXZlIHN1 Y2ggaW5mb3JtYXRpb24gaW4gdGhlIFZDNAo+ID4gPiA+ID4gPiBjYXNlLgo+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gQW55IG9waW5pb24gb24gdGhhdD8gICAgICAKPiA+ID4gPiA+IAo+ID4gPiA+ ID4gSXQncyBvbmx5IGFiaSBpZiB5b3UncmUgdW5sdWNreS4gSWYgaXQncyBqdXN0IGZvciBkZWJ1 Z2dpbmcgYW5kCj4gPiA+ID4gPiB2YWxpZGF0aW9uLCB5b3UgY2FuIGNoYW5nZSBpdCBhZ2Fpbi4g VGJoLCBubyBpZGVhIHdoeSB3ZSBldmVuIGhhdmUgdGhlc2UKPiA+ID4gPiA+IHRyYWNlcG9pbnRz LCB0aGV5J3JlIGZhaXJseSB1c2VsZXNzIGltby4gQ0kgb25seSByZWxpZXMgdXBvbiB0aGUgZG1l c2cKPiA+ID4gPiA+IG91dHB1dC4gTWF5YmUgcnVuIGdpdCBibGFtZSBhbmQgYXNrIHRoZSBvcmln aW5hbCBhdXRob3IsIHdlIGNhbiBwcm9iYWJseQo+ID4gPiA+ID4gdXBkYXRlIHRoZW0gdG8gc3Vp dCBvdXIgbmVlZHMuICAgIAo+ID4gPiA+IAo+ID4gPiA+IE9rYXksIEkgdGhpbmsgSSdsbCBnbyBm b3IgYSBnZW5lcmljIGRlYnVnZnMgZW50cnkgdGhhdCByZXR1cm5zIHRydWUKPiA+ID4gPiB3aGVu IGFuIHVuZGVycnVuIGVycm9yIGhhcHBlbmVkIHNpbmNlIHRoZSBsYXN0IG1vZGVzZXQsIGZhbHNl IG90aGVyd2lzZS4KPiA+ID4gPiAKPiA+ID4gPiBOZXh0IHF1ZXN0aW9uIGlzOiBzaG91bGQgSSBh dHRhY2ggdGhlIHVuZGVycnVuIHN0YXR1cyB0byB0aGUgZHJtX2RldmljZQo+ID4gPiA+IG9yIGhh dmUgb25lIHBlciBDUlRDPyBJbiBteSBjYXNlLCBJIG9ubHkgY2FyZSBhYm91dCB0aGUgImhhcyBh bgo+ID4gPiA+IHVuZGVycnVuIGVycm9yIG9jY3VycmVkIG9uIGFueSBvZiB0aGUgYWN0aXZlIENS VEMiIGNhc2UsIHNvIEknZCB2b3RlIGZvcgo+ID4gPiA+IGEgcGVyLWRldmljZSB1bmRlcnJ1biBz dGF0dXMuICAgIAo+ID4gPiAKPiA+ID4gWWVhaCBwcm9iYWJseSBnb29kIGVub3VnaC4gRm9yIG91 ciBDSSBhbGwgd2UgY2FyZSBhYm91dCBpcyB0aGUgd2Fybi9lcnJvcgo+ID4gPiBsZXZlbCBkbWVz ZyBvdXRwdXQuIEFueXRoaW5nIGF0IHRoYXQgbGV2ZWwgaXMgY29uc2lkZXJlZCBhIENJIGZhaWx1 cmUuICAKPiA+IAo+ID4gU28gaWd0IGlzIGdyZXBwaW5nIGRtZXNnIHRvIGRldGVjdCB3aGVuIGFu IHVuZGVycnVuIGhhcHBlbnM/ICAKPiAKPiBObywgYnV0IHRoZSBDSSBydW5uZXIgaXMgYWxzbyBv YnNlcnZpbmcgZG1lc2cuIEFueXRoaW5nIGluIHRoZXJlIGF0Cj4gd2FybmluZyBvciBoaWdoZXIg bGV2ZWwgaXMgY29uc2lkZXJlZCBhIGZhaWx1cmUuCgpFcmljLCBkbyB5b3UgZG8gdGhlIHNhbWUg d2hlbiB5b3UgbGF1bmNoIHRoZSBJR1QgdGVzdHN1aXRlPwoKPiAKPiA+ID4gV2hhdCBkbyB5b3Ug bmVlZCB0aGUgZGVidWdmcyBmaWxlIGZvcj8gIAo+ID4gCj4gPiBJIGp1c3QgdGhvdWdodCBoYXZp bmcgYSBkZWJ1Z2ZzIGZpbGUgdG8gZXhwb3NlIHRoZSB1bmRlcnJ1biBpbmZvcm1hdGlvbgo+ID4g d291bGQgYmUgY2xlYW5lciB0aGFuIGhhdmluZyB0byBncmVwIGluIGRtZXNnIHRvIGRldGVjdCBz dWNoIGZhaWx1cmVzLiAgCj4gCj4gVGhlIGlzc3VlIGlzIHRoYXQgeW91IHdhbnQgdG8gZGV0ZWN0 IHVuZGVycnVucyBldmVyeXdoZXJlLCBub3QganVzdCBpbiB0aGUKPiBzcGVjaWZpYyB0ZXN0cyB5 b3UncmUgY2hlY2tpbmcgZm9yIGl0LiBBbnl0aGluZyB0aGF0IGRvZXMgYSBtb2Rlc2V0IGNvdWxk Cj4gY2F1c2UgYW4gdW5kZXJydW4gKGF0IGxlYXN0IHdlJ3ZlIG1hbmFnZWQgdG8gZG8gc28gcHJl dHR5IG11Y2ggZXZlcnl3aGVyZQo+IG9uIGk5MTUgaHcsIGlmIHlvdSBtaXNwcm9ncmFtIGlzIHN1 ZmZpY2llbnRseSkuCgpJbiBteSBzcGVjaWZpYyBjYXNlLCBJIHdhbnQgdG8gaGF2ZSB0aGUgSUdU IHRlc3QgY2hlY2sgdGhlIHVuZGVycnVuCnZhbHVlIHdoaWxlIHRoZSB0ZXN0IGlzIGJlaW5nIGV4 ZWN1dGVkIHNvIHRoYXQgSSBrbm93IHdoaWNoIGV4YWN0CmNvbmZpZ3VyYXRpb24gdHJpZ2dlcnMg dGhlIHVuZGVycnVuIHNpdHVhdGlvbi4gQXQgbGVhc3QgdGhhdCdzIGhvdyBJCmRpZCB0byBhZGp1 c3QvZGVidWcgdGhlIEhWUyBsb2FkIHRyYWNraW5nIGNvZGUuIE1heWJlIGl0J3Mgbm90IHJlYWxs eSBhCnByb2JsZW0gd2hlbiBhbGwgd2UgZG8gaXMgdHJhY2tpbmcgcmVncmVzc2lvbnMuCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=