From: Daniel Vetter <daniel@ffwll.ch>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"Hollingworth, Gordon" <gordon@raspberrypi.org>,
Eben Upton <eben@raspberrypi.org>
Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors
Date: Mon, 29 Oct 2018 14:48:47 +0100 [thread overview]
Message-ID: <20181029134846.GW21967@phenom.ffwll.local> (raw)
In-Reply-To: <20181029101056.3a33ac66@bbrezillon>
On Mon, Oct 29, 2018 at 10:10:56AM +0100, Boris Brezillon wrote:
> On Mon, 29 Oct 2018 10:03:01 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Oct 29, 2018 at 09:41:36AM +0100, Boris Brezillon wrote:
> > > On Mon, 29 Oct 2018 09:06:40 +0100
> > > > The other upshot of a counter is that there's no problem with resetting.
> > > > Userspace simply grabs the counter before and after the test and compares.
> > > > If you only have 0/1 you need some way to reset, or otherwise automated
> > > > running in a CI farm isn't possible.
> > >
> > > The reset was done during atomic commit in my proposal, so no action
> > > was required on the user side apart from applying a new config.
> > > Anyway, I'll change that for a real counter.
> >
> > We want to measure underruns while doing full modesets too (specifically,
> > when shutting down the pipeline). At least for our hw this has
> > historically helped greatly in catching programming sequence issues.
>
> Looks like you have particular needs for intel HW which I don't know
> about, maybe I shouldn't be the one driving this rework...
No one is expecting you do drive i915 work, we just want to make sure that
whatever you come up for igt tests is generally useful, and not just only
for the limited use case of vc4. Atm the only two drivers interested in
underrun reporting are i915 and vc4, and it looks like they span a pretty
broad spectrum alredy.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-10-29 13:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:40 [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Boris Brezillon
2018-10-16 12:57 ` Daniel Vetter
2018-10-16 13:10 ` Boris Brezillon
2018-10-16 13:12 ` Daniel Vetter
2018-10-16 13:28 ` Ville Syrjälä
2018-10-16 16:41 ` Daniel Vetter
2018-10-16 17:39 ` Ville Syrjälä
2018-10-16 17:51 ` Daniel Vetter
2018-10-17 13:45 ` Boris Brezillon
2018-10-23 7:55 ` Boris Brezillon
2018-10-23 13:44 ` Daniel Vetter
2018-10-25 8:09 ` Boris Brezillon
2018-10-25 9:33 ` Daniel Vetter
2018-10-25 9:41 ` Boris Brezillon
2018-10-26 13:30 ` Daniel Vetter
2018-10-26 13:57 ` Boris Brezillon
2018-10-26 14:26 ` Daniel Vetter
2018-10-26 14:52 ` Boris Brezillon
2018-10-26 15:10 ` Ville Syrjälä
2018-10-29 8:06 ` Daniel Vetter
2018-10-29 8:41 ` Boris Brezillon
2018-10-29 9:03 ` Daniel Vetter
2018-10-29 9:10 ` Boris Brezillon
2018-10-29 13:48 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029134846.GW21967@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eben@raspberrypi.org \
--cc=gordon@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).