From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 4/4] drm/nouveau: Use atomic VCPI helpers for MST Date: Mon, 29 Oct 2018 15:11:34 +0100 Message-ID: <20181029141134.GA21967@phenom.ffwll.local> References: <20181026203549.1796-1-lyude@redhat.com> <20181026203549.1796-5-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFAD589F75 for ; Mon, 29 Oct 2018 14:11:38 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id v18-v6so7397161edq.13 for ; Mon, 29 Oct 2018 07:11:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181026203549.1796-5-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude Paul Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMjYsIDIwMTggYXQgMDQ6MzU6NDlQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBDdXJyZW50bHksIG5vdXZlYXUgdXNlcyB0aGUgeW9sbyBtZXRob2Qgb2Ygc2V0dGluZyB1 cCBNU1QgZGlzcGxheXM6IGl0Cj4gdXNlcyB0aGUgb2xkIFZDUEkgaGVscGVycyAoZHJtX2RwX2Zp bmRfdmNwaV9zbG90cygpKSBmb3IgY29tcHV0aW5nIHRoZQo+IGRpc3BsYXkgY29uZmlndXJhdGlv bi4gVGhlc2UgaGVscGVycyBkb24ndCB0YWtlIGNhcmUgdG8gbWFrZSBzdXJlIHRoZXkKPiB0YWtl IGEgcmVmZXJlbmNlIHRvIHRoZSBtc3RiIHBvcnQgdGhhdCB0aGV5J3JlIGNoZWNraW5nLCBhbmQK PiBhZGRpdGlvbmFsbHkgZG9uJ3QgYWN0dWFsbHkgY2hlY2sgd2hldGhlciBvciBub3QgdGhlIHRv cG9sb2d5IHN0aWxsIGhhcwo+IGVub3VnaCBiYW5kd2lkdGggdG8gcHJvdmlkZSB0aGUgVkNQSSB0 b2tlbnMgcmVxdWlyZWQuCj4gCj4gU28sIGRyb3AgdXNhZ2Ugb2YgdGhlIG9sZCBoZWxwZXJzIGFu ZCBtb3ZlIGVudGlyZWx5IG92ZXIgdG8gdGhlIGF0b21pYwo+IGhlbHBlcnMuCj4gCj4gU2lnbmVk LW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiBDYzogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL25vdXZl YXUvZGlzcG52NTAvZGlzcC5jIHwgNTQgKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAvZGlzcC5jIGIvZHJpdmVycy9n cHUvZHJtL25vdXZlYXUvZGlzcG52NTAvZGlzcC5jCj4gaW5kZXggNmNiYmFlM2Y0MzhiLi4zNzUw MzMxOWU1YjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAv ZGlzcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAvZGlzcC5jCj4g QEAgLTc0NywxNiArNzQ3LDIyIEBAIG52NTBfbXN0b19hdG9taWNfY2hlY2soc3RydWN0IGRybV9l bmNvZGVyICplbmNvZGVyLAo+ICAJCSAgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNf c3RhdGUsCj4gIAkJICAgICAgIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRl KQo+ICB7Cj4gLQlzdHJ1Y3QgbnY1MF9tc3RjICptc3RjID0gbnY1MF9tc3RjKGNvbm5fc3RhdGUt PmNvbm5lY3Rvcik7Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBjcnRjX3N0 YXRlLT5zdGF0ZTsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IgPSBjb25uX3N0 YXRlLT5jb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgbnY1MF9tc3RjICptc3RjID0gbnY1MF9tc3RjKGNv bm5lY3Rvcik7Cj4gIAlzdHJ1Y3QgbnY1MF9tc3RtICptc3RtID0gbXN0Yy0+bXN0bTsKPiAtCWlu dCBicHAgPSBjb25uX3N0YXRlLT5jb25uZWN0b3ItPmRpc3BsYXlfaW5mby5icGMgKiAzOwo+ICsJ aW50IGJwcCA9IGNvbm5lY3Rvci0+ZGlzcGxheV9pbmZvLmJwYyAqIDM7Cj4gIAlpbnQgc2xvdHM7 Cj4gIAo+IC0JbXN0Yy0+cGJuID0gZHJtX2RwX2NhbGNfcGJuX21vZGUoY3J0Y19zdGF0ZS0+YWRq dXN0ZWRfbW9kZS5jbG9jaywgYnBwKTsKPiAtCj4gLQlzbG90cyA9IGRybV9kcF9maW5kX3ZjcGlf c2xvdHMoJm1zdG0tPm1nciwgbXN0Yy0+cGJuKTsKPiAtCWlmIChzbG90cyA8IDApCj4gLQkJcmV0 dXJuIHNsb3RzOwo+ICsJbXN0Yy0+cGJuID0gZHJtX2RwX2NhbGNfcGJuX21vZGUoY3J0Y19zdGF0 ZS0+YWRqdXN0ZWRfbW9kZS5jbG9jaywKPiArCQkJCQkgYnBwKTsKPiArCS8qIFpvbWJpZXMgZG9u J3QgbmVlZCBWQ1BJICovCj4gKwlpZiAoIWRybV9jb25uZWN0b3JfaXNfdW5yZWdpc3RlcmVkKGNv bm5lY3RvcikpIHsKPiArCQlzbG90cyA9IGRybV9kcF9hdG9taWNfZmluZF92Y3BpX3Nsb3RzKHN0 YXRlLCAmbXN0bS0+bWdyLAo+ICsJCQkJCQkgICAgICBtc3RjLT5wb3J0LCBtc3RjLT5wYm4pOwo+ ICsJCWlmIChzbG90cyA8IDApCj4gKwkJCXJldHVybiBzbG90czsKPiArCX0KPiAgCj4gIAlyZXR1 cm4gbnY1MF9vdXRwX2F0b21pY19jaGVja192aWV3KGVuY29kZXIsIGNydGNfc3RhdGUsIGNvbm5f c3RhdGUsCj4gIAkJCQkJICAgbXN0Yy0+bmF0aXZlKTsKPiBAQCAtOTIwLDEyICs5MjYsMzggQEAg bnY1MF9tc3RjX2dldF9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJ cmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIGludAo+ICtudjUwX21zdGNfYXRvbWljX2No ZWNrKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJICAgICAgIHN0cnVjdCBk cm1fY29ubmVjdG9yX3N0YXRlICpuZXdfY29ubl9zdGF0ZSkKPiArewo+ICsJc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlID0gbmV3X2Nvbm5fc3RhdGUtPnN0YXRlOwo+ICsJc3RydWN0IG52 NTBfbXN0YyAqbXN0YyA9IG52NTBfbXN0Yyhjb25uZWN0b3IpOwo+ICsJc3RydWN0IGRybV9kcF9t c3RfdG9wb2xvZ3lfbWdyICptZ3IgPSAmbXN0Yy0+bXN0bS0+bWdyOwo+ICsJc3RydWN0IGRybV9j b25uZWN0b3Jfc3RhdGUgKm9sZF9jb25uX3N0YXRlOwo+ICsJc3RydWN0IGRybV9jcnRjICpvbGRf Y3J0YzsKPiArCj4gKwlvbGRfY29ubl9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X29sZF9jb25uZWN0 b3Jfc3RhdGUoc3RhdGUsIGNvbm5lY3Rvcik7Cj4gKwlvbGRfY3J0YyA9IG9sZF9jb25uX3N0YXRl LT5jcnRjOwo+ICsKPiArCS8qIFdlIG9ubHkgbmVlZCB0byByZWxlYXNlIFZDUEkgaGVyZSBpZiB3 ZSdyZSBnb2luZyBmcm9tIGhhdmluZyBhIENSVEMKPiArCSAqIG9uIHRoaXMgY29ubmVjdG9yLCB0 byBub3QgaGF2aW5nIG9uZQo+ICsJICovCj4gKwlpZiAoIW9sZF9jcnRjIHx8IG5ld19jb25uX3N0 YXRlLT5jcnRjKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCS8qIFJlbGVhc2UgdGhlIHByZXZpb3Vz IFZDUEkgYWxsb2NhdGlvbiBzaW5jZSB0aGUgZW5jb2RlcidzCj4gKwkgKiBhdG9taWNfY2hlY2so KSB3b24ndCBiZSBjYWxsZWQKPiArCSAqLwo+ICsJcmV0dXJuIGRybV9kcF9hdG9taWNfcmVsZWFz ZV92Y3BpX3Nsb3RzKHN0YXRlLCBtZ3IsIG1zdGMtPnBvcnQpOwo+ICt9Cj4gKwo+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzCj4gIG52NTBfbXN0Y19oZWxw ID0gewo+ICAJLmdldF9tb2RlcyA9IG52NTBfbXN0Y19nZXRfbW9kZXMsCj4gIAkubW9kZV92YWxp ZCA9IG52NTBfbXN0Y19tb2RlX3ZhbGlkLAo+ICAJLmJlc3RfZW5jb2RlciA9IG52NTBfbXN0Y19i ZXN0X2VuY29kZXIsCj4gIAkuYXRvbWljX2Jlc3RfZW5jb2RlciA9IG52NTBfbXN0Y19hdG9taWNf YmVzdF9lbmNvZGVyLAo+ICsJLmF0b21pY19jaGVjayA9IG52NTBfbXN0Y19hdG9taWNfY2hlY2ss Cj4gIH07Cj4gIAo+ICBzdGF0aWMgZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1cwo+IEBAIC0yMDg0 LDYgKzIxMTYsOCBAQCBudjUwX2Rpc3BfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCXN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRl Owo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ICsJc3RydWN0IGRybV9kcF9tc3RfdG9wb2xv Z3lfbWdyICptZ3I7Cj4gKwlzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9zdGF0ZSAqbXN0X3N0 YXRlOwo+ICAJaW50IHJldCwgaTsKPiAgCj4gIAkvKiBXZSBuZWVkIHRvIGhhbmRsZSBjb2xvdXIg bWFuYWdlbWVudCBvbiBhIHBlci1wbGFuZSBiYXNpcy4gKi8KPiBAQCAtMjEwOSw2ICsyMTQzLDEy IEBAIG52NTBfZGlzcF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAKPiAr CWZvcl9lYWNoX25ld19tc3RfbWdyX2luX3N0YXRlKHN0YXRlLCBtZ3IsIG1zdF9zdGF0ZSwgaSkg ewo+ICsJCXJldCA9IGRybV9kcF9tc3RfYXRvbWljX2NoZWNrKG1zdF9zdGF0ZSk7Cj4gKwkJaWYg KHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiArCX0KCkZvciBldmVuIGxlc3MgY29kZSBJIHRoaW5r IHlvdSBjb3VsZCBhbHNvIHB1c2ggdGhpcyBsb29wIGludG8gdGhlIGhlbHBlcnMuCkkgY2FuJ3Qg Y29tZSB1cCB3aXRoIGFueSBzY2VuYXJpbyB3aGVyZSBhIGRyaXZlciBkb2VzIG5vdCB3YW50IHRv IGNoZWNrCmFsbCBvZiB0aGVtIGF0IHRoZSBzYW1lIHRpbWUgaW4gdGhlIGF0b21pY19jaGVjayBz ZXF1ZW5jZS4KCk90aGVyd2lzZSBsZ3RtLgotRGFuaWVsCgo+ICsKPiAgCXJldHVybiAwOwo+ICB9 Cj4gIAo+IC0tIAo+IDIuMTcuMgo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=