From: Daniel Vetter <daniel@ffwll.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] drm/mcde: Add new driver for ST-Ericsson MCDE
Date: Thu, 7 Feb 2019 23:28:35 +0100 [thread overview]
Message-ID: <20190207222835.GD23159@phenom.ffwll.local> (raw)
In-Reply-To: <20190207222239.GC23159@phenom.ffwll.local>
On Thu, Feb 07, 2019 at 11:22:39PM +0100, Daniel Vetter wrote:
> On Thu, Feb 07, 2019 at 09:36:46AM +0100, Linus Walleij wrote:
> > +static const struct drm_mode_config_funcs mode_config_funcs = {
> > + .fb_create = drm_gem_fb_create,
>
> You need drm_gem_fb_create_with_dirty here because you have a manual
> upload screen. Also might head the advice from the kerneldoc and check
> your buffer alignment constraints here instead of in the check callback.
> But I guess either works, best would be if dumb_create would align stuff
> correctly (which it should), but since this is super theoretical (usually
> modes are even enough), who cares :-)
Forgot to mention: You might want to wire up the damage rect stuff and
only upload the part of the screen that userspace/fbdev tells you has
actually changed. Doesn't apply to all (or even most) userspace just yet,
since brand new stuff.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-07 22:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 8:36 [PATCH 0/4] DRM driver for ST-Ericsson MCDE Linus Walleij
2019-02-07 8:36 ` [PATCH 1/4] drm/simple_kms_helper: enable use of external encoder Linus Walleij
2019-02-07 9:17 ` Daniel Vetter
2019-02-07 21:02 ` Linus Walleij
2019-02-07 21:43 ` Daniel Vetter
2019-02-07 8:36 ` [PATCH 2/4] drm/mcde: Add device tree bindings Linus Walleij
2019-02-25 22:31 ` Rob Herring
2019-02-07 8:36 ` [PATCH 3/4] drm/mcde: Add new driver for ST-Ericsson MCDE Linus Walleij
2019-02-07 22:22 ` Daniel Vetter
2019-02-07 22:28 ` Daniel Vetter [this message]
2019-02-08 19:31 ` Sam Ravnborg
2019-02-07 8:36 ` [PATCH 4/4] ARM: dts: Ux500: Add MCDE and Samsung display Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207222835.GD23159@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).