hi, On Fri, Feb 08, 2019 at 03:24:12PM +0300, Konstantin Sudakov wrote: > Hello, Maxime! > > >+mode = drm_mode_duplicate(panel->drm, &default_mode); > >+if (!mode) { > >+DRM_DEV_ERROR(&ctx->dsi->dev, > >+ "Failed to add mode " DRM_MODE_FMT "\n", > >+ DRM_MODE_ARG(mode)); > >+return -EINVAL; > >+} > > Just small fix: DRM_MODE_ARG(mode) -> DRM_MODE_ARG(&default_mode). > The "mode" variable is NULL, it leads to the UB. Good catch, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com