From: Sam Ravnborg <sam@ravnborg.org>
To: Qiang Yu <yuq825@gmail.com>
Cc: "Marek Vasut" <marex@denx.de>,
"Simon Shields" <simon@lineageos.org>,
lima@lists.freedesktop.org,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
dri-devel@lists.freedesktop.org,
"Vasily Khoruzhick" <anarsoul@gmail.com>,
"David Airlie" <airlied@linux.ie>, "Sean Paul" <sean@poorly.run>,
"Andreas Baierl" <ichgeh@imkreisrum.de>,
"Erico Nunes" <nunes.erico@gmail.com>
Subject: Re: [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs
Date: Wed, 27 Feb 2019 21:29:27 +0100 [thread overview]
Message-ID: <20190227202927.GB27395@ravnborg.org> (raw)
In-Reply-To: <20190227134124.28602-1-yuq825@gmail.com>
Hi Qiang.
Two general comments:
- We are trying to avoid drmP.h in new drivers, please drop
- The use of idr is being replaced with XArray, see patch-set
posted by Matthew Wilcox.
Try to use XArray so we do not introduce a new user.
This was from a very quick looks at the driver.
In general things looked good, but these two issues
I stumbled upon.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-27 20:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 13:41 [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs Qiang Yu
2019-02-27 20:29 ` Sam Ravnborg [this message]
2019-02-27 21:41 ` Rob Herring
2019-03-02 2:32 ` Qiang Yu
2019-03-02 18:23 ` Rob Clark
2019-03-04 17:20 ` Rob Herring
2019-03-05 1:36 ` Qiang Yu
2019-03-02 5:22 ` Qiang Yu
2019-03-05 15:31 ` Rob Herring
2019-03-05 20:18 ` Eric Anholt
2019-03-06 2:01 ` Qiang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227202927.GB27395@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ichgeh@imkreisrum.de \
--cc=lima@lists.freedesktop.org \
--cc=marex@denx.de \
--cc=maxime.ripard@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=nunes.erico@gmail.com \
--cc=sean@poorly.run \
--cc=simon@lineageos.org \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).