From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: fabrizio.castro@bp.renesas.com, devicetree@vger.kernel.org,
Songjun.Wu@atmel.com, tony@atomide.com,
dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com,
tomi.valkeinen@ti.com, voice.shen@atmel.com
Subject: Re: [PATCH v2 4/5] drm/bridge: sii902x: Select I2C_MUX
Date: Mon, 4 Mar 2019 18:05:21 +0200 [thread overview]
Message-ID: <20190304160521.GQ6325@pendragon.ideasonboard.com> (raw)
In-Reply-To: <077964b92af5c0fdf6a8e6767ef8dfccfe4c008f.1551303673.git.jsarha@ti.com>
Hi Jyri,
Thank you for the patch.
On Wed, Feb 27, 2019 at 11:54:22PM +0200, Jyri Sarha wrote:
> "drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to
> I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting
> I2C_MUX for DRM_SII902X config option.
>
> Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback")
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index fb0b37918382..a6f6ff8f06b3 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -95,6 +95,7 @@ config DRM_SII902X
> depends on OF
> select DRM_KMS_HELPER
> select REGMAP_I2C
> + select I2C_MUX
> ---help---
> Silicon Image sii902x bridge chip driver.
>
This is already present in v5.0.
commit ea6b13e9fed0fda9532ee04d38ed1bef1edbfdbf
Author: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Date: Mon Nov 19 13:26:18 2018 +0000
drm/bridge/sii902x: Add missing dependency on I2C_MUX
Fabrizio stated in the commit message that "Quite obviously the driver
depends on I2C_MUX, but adding a "depends on" introduces a recursive
dependency, therefore this patch selects I2C_MUX instead.". Given that
I2C_MUX is a tristate user-selectable option, "depend on" should be the
right solution. I wonder if we could fix the root cause of the recursive
dependency.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-04 16:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 21:54 [PATCH v2 0/5] drm/bridge: sii902x: HDMI-audio support and some fixes Jyri Sarha
2019-02-27 21:54 ` [PATCH v2 1/5] drm/bridge: sii902x: add input_bus_flags Jyri Sarha
2019-03-04 12:48 ` Laurent Pinchart
2019-02-27 21:54 ` [PATCH v2 2/5] drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID Jyri Sarha
2019-03-04 12:52 ` Laurent Pinchart
2019-03-04 14:15 ` Jyri Sarha
2019-02-27 21:54 ` [PATCH v2 3/5] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Jyri Sarha
2019-03-04 15:59 ` Laurent Pinchart
2019-02-27 21:54 ` [PATCH v2 4/5] drm/bridge: sii902x: Select I2C_MUX Jyri Sarha
2019-03-04 8:54 ` Andrzej Hajda
2019-03-04 16:05 ` Laurent Pinchart [this message]
2019-02-27 21:54 ` [PATCH v2 5/5] drm/bridge: sii902x: Implement HDMI audio support Jyri Sarha
2019-03-04 9:26 ` Andrzej Hajda
2019-03-12 16:11 ` Rob Herring
2019-03-04 12:42 ` [PATCH v2 0/5] drm/bridge: sii902x: HDMI-audio support and some fixes Laurent Pinchart
2019-03-04 14:29 ` Jyri Sarha
2019-03-04 16:10 ` Laurent Pinchart
2019-03-06 14:18 ` Olivier MOYSAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304160521.GQ6325@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Songjun.Wu@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=jsarha@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).