From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Date: Tue, 5 Mar 2019 09:08:48 +0100 Message-ID: <20190305080848.jifr5rgcz2rejlz5@flea> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87imwymyki.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0883298244==" Return-path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF7A289F19 for ; Tue, 5 Mar 2019 08:08:53 +0000 (UTC) In-Reply-To: <87imwymyki.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: eben@raspberrypi.org, David Airlie , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============0883298244== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cmkzq2xdszje3roz" Content-Disposition: inline --cmkzq2xdszje3roz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 04, 2019 at 05:47:09PM +0200, Jani Nikula wrote: > On Mon, 04 Mar 2019, Maxime Ripard wrote: > > In some cases, in order to accomodate with displays with poor EDIDs, we > > need to ignore that the monitor alledgedly supports audio output and > > disable the audio output. >=20 > *sad trombone* >=20 > Trying to figure this out automatically in kernel is better than a > quirk. >=20 > A quirk is better than requiring the user to provide an override EDID > via the firmware loader (drm.edid_firmware parameter). >=20 > Requiring an override EDID is better than adding a module parameter. >=20 > I'd much rather we exhausted the other options before adding module > parameters to address specific issues with EDIDs. That's a rabbit hole > with no end. We should also consider the usability of these solutions. Sure, the quirks are the ideal solution long term, but do we really expect the average user that just got its device from Amazon and connected it to its display to figure out: - That if it's display doesn't work, it's because the display is broken - That it is broken due to poor EDIDs - To find out that it's supposed to be handled in DRM through a quirk - How to make such a quirk - How to recompile the kernel on its distro of choice - That they need to send a patch later on to upstream Linux, and then wait for a year or so (depending on their distro) before it's actually working. Chances are that they would stop at 1, call the device trash and never submit any quirk, therefore making the quirk approach useless in the process. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --cmkzq2xdszje3roz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH4ufwAKCRDj7w1vZxhR xbxyAQDXQWJS7ZD3RJngrfWIiNIb6+M3t9l/iHql/dF0XMV56wEAp5c8diNdSUvX W8eSWOwB2pSWLdFsJqZcnc7ldSXkuQg= =h1Kc -----END PGP SIGNATURE----- --cmkzq2xdszje3roz-- --===============0883298244== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0883298244==--