Re: [PATCH v3 1/7] dt-bindings: interconnect: Add a dma interconnect name

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Robin Murphy <robin.murphy@arm.com>,
	dri-devel@lists.freedesktop.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	Yong Deng <yong.deng@magewell.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Dave Martin <dave.martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] dt-bindings: interconnect: Add a dma interconnect name
Date: Tue, 5 Mar 2019 16:53:37 +0100	[thread overview]
Message-ID: <20190305155337.glfvgyddvnkv774m@flea> (raw)
In-Reply-To: <553c987c-da9a-1f85-fb16-4b9fe17dd14b@linaro.org>

[-- Attachment #1.1: Type: text/plain, Size: 1979 bytes --]

Hi,

On Fri, Mar 01, 2019 at 07:48:15PM +0200, Georgi Djakov wrote:
> On 2/11/19 17:02, Maxime Ripard wrote:
> > The current DT bindings assume that the DMA will be performed by the
> > devices through their parent DT node, and rely on that assumption for the
> > address translation using dma-ranges.
> > 
> > However, some SoCs have devices that will perform DMA through another bus,
> > with separate address translation rules. We therefore need to express that
> > relationship, through the special interconnect name "dma".
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> >  Documentation/devicetree/bindings/interconnect/interconnect.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > index 5a3c575b387a..e69fc2d992c3 100644
> > --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> > @@ -51,6 +51,9 @@ interconnect-names : List of interconnect path name strings sorted in the same
> >  		     interconnect-names to match interconnect paths with interconnect
> >  		     specifier pairs.
> >  
> > +                     Reserved interconnect names:
> > +                         * dma: Path from the device to the main memory of the system
> 
> Bikeshed: As it's from the device to the main memory, maybe here we can
> also denote this my calling the path dma-mem or dma-memory. For other
> paths, we are trying to mention both the source and the destination and
> maybe it would be good to be consistent although this is special one.

I'm not sure I understand what you mean. You'd like two interconnect
names, one called dma-memory, and one memory-dma?

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel