From: Rob Herring <robh@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Russell King <linux@armlinux.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings
Date: Tue, 12 Mar 2019 13:42:27 -0500 [thread overview]
Message-ID: <20190312184227.GA1766@bogus> (raw)
In-Reply-To: <20190304202006.3863-5-lkundrak@v3.sk>
On Mon, Mar 04, 2019 at 09:20:05PM +0100, Lubomir Rintel wrote:
> There's a generic compatible string and the driver will work on a MMP2 as
> well, using the same binding.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Added marvell,armada-lcdc compatible string.
>
> .../devicetree/bindings/display/marvell,armada-lcdc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> index 2606a8efc956..4ef66bc2845c 100644
> --- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> +++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> @@ -3,7 +3,9 @@ Marvell Armada LCD controller
>
> Required properties:
>
> - - compatible: value should be "marvell,dove-lcd".
> + - compatible: value should be "marvell,armada-lcdc" along with
> + "marvell,dove-lcd" or "marvell,mmp2-lcd", depending on the
> + exact SoC model.
It is not exactly clear what the order is here. The preferred form is:
compatible: must be one of:
a
b
c
followed by 'fallback'
So "marvell,armada-lcdc" is the fallback, but you can't start requiring
the existing "marvell,dove-lcd" to have a fallback. At least you can't
depend on that.
> - reg: base address and size of the LCD controller
> - interrupts: single interrupt number for the LCD controller
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-03-12 18:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer Lubomir Rintel
2019-03-12 18:42 ` Rob Herring
2019-03-04 20:20 ` [PATCH v2 2/5] dt-bindings: display: armada: Rename the binding doc file Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation Lubomir Rintel
2019-03-12 18:42 ` Rob Herring
2019-03-04 20:20 ` [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings Lubomir Rintel
2019-03-12 18:42 ` Rob Herring [this message]
2019-03-04 20:20 ` [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
2019-03-12 18:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312184227.GA1766@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).