From: Rob Herring <robh@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: fabrizio.castro@bp.renesas.com, devicetree@vger.kernel.org,
Songjun.Wu@atmel.com, dri-devel@lists.freedesktop.org,
peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
laurent.pinchart@ideasonboard.com, voice.shen@atmel.com
Subject: Re: [PATCH v4 5/6] dt-bindings: display: sii902x: Add HDMI audio bindings
Date: Mon, 25 Mar 2019 14:20:04 -0500 [thread overview]
Message-ID: <20190315234539.GA14772@bogus> (raw)
In-Reply-To: <da7c2a4f469a81d8cdc5c04ab245529a094dbfd3.1552562385.git.jsarha@ti.com>
On Thu, Mar 14, 2019 at 01:27:51PM +0200, Jyri Sarha wrote:
> The sii902x chip family supports also HDMI audio. Add binding for
> describing the necessary i2s and mclk wiring for it.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
> .../bindings/display/bridge/sii902x.txt | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> index c4c1855ca654..1a37bbe7c597 100644
> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt
> @@ -9,6 +9,33 @@ Optional properties:
> about hotplug events.
> - reset-gpios: OF device-tree gpio specification for RST_N pin.
>
> + HDMI audio properties:
> + - i2s-data-lanes: Array of up to 4 integers with values of 0-3
> + Each integer indicates which i2s pin is connected to which
> + audio fifo. The first integer selects i2s audio pin for the
> + first audio fifo#0 (HDMI channels 1&2), second for fifo#1
> + (HDMI channels 3&4), and so on. There is 4 fifos and 4 i2s
> + pins (SD0 - SD3). Any i2s pin can be connected to any fifo,
> + but there can be no gaps. E.g. an i2s pin must be mapped to
> + fifo#0 and fifo#1 before mapping a channel to fifo#2.
> + I2S HDMI audio is configured only if this property is found.
Seems like a default should be allowed and you should enable audio based
on #sound-dai-cells which you didn't document.
> + - clocks: phandle and clock specifier for each clock listed in
> + the clock-names property
> + - clock-names: "mclk"
> + Describes SII902x MCLK input. MCLK is used to produce
> + HDMI audio CTS values. This property is required if
> + "i2s-data-lanes"-property is present. This property follows
> + Documentation/devicetree/bindings/clock/clock-bindings.txt
> + consumer binding.
> +
> + If HDMI audio is configured the sii902x device becomes an ASoC
> + codec component, that can be used in configuring full audio
> + devices with ASoC simple-card or audio-graph-card. See their
With the graph-card, don't you need to define which port is audio?
> + binding documents on how to describe how the sii902x device is
> + connected to the rest of the audio system:
> + Documentation/devicetree/bindings/sound/simple-card.txt
> + Documentation/devicetree/bindings/sound/audio-graph-card.txt
> +
> Optional subnodes:
> - video input: this subnode can contain a video input port node
> to connect the bridge to a display controller output (See this
> @@ -21,6 +48,12 @@ Example:
> compatible = "sil,sii9022";
> reg = <0x39>;
> reset-gpios = <&pioA 1 0>;
> +
> + #sound-dai-cells = <0>;
> + i2s-data-lanes = < 0 1 2 >;
> + clocks = <&mclk>;
> + clock-names = "mclk";
> +
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-25 19:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 11:27 [PATCH v4 0/6] drm/bridge: sii902x: HDMI-audio support and some fixes Jyri Sarha
2019-03-14 11:27 ` [PATCH v4 1/6] drm/bridge: sii902x: add input_bus_flags Jyri Sarha
2019-03-14 11:27 ` [PATCH v4 2/6] drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID Jyri Sarha
2019-03-14 11:27 ` [PATCH v4 3/6] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Jyri Sarha
2019-03-14 11:27 ` [PATCH v4 4/6] dt-bindings: display: sii902x: Remove trailing white space Jyri Sarha
2019-03-15 23:38 ` Rob Herring
2019-03-14 11:27 ` [PATCH v4 5/6] dt-bindings: display: sii902x: Add HDMI audio bindings Jyri Sarha
2019-03-17 16:16 ` Laurent Pinchart
2019-03-19 14:38 ` Jyri Sarha
2019-04-20 23:12 ` Laurent Pinchart
2019-03-25 19:20 ` Rob Herring [this message]
2019-03-14 11:27 ` [PATCH v4 6/6] drm/bridge: sii902x: Implement HDMI audio support Jyri Sarha
2019-03-14 15:44 ` Olivier MOYSAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315234539.GA14772@bogus \
--to=robh@kernel.org \
--cc=Songjun.Wu@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).