From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] drm: rcar-du: Link CRTCs to the DU device
Date: Mon, 18 Mar 2019 00:55:25 +0200 [thread overview]
Message-ID: <20190317225525.GC12636@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190315170110.23280-2-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Fri, Mar 15, 2019 at 05:01:05PM +0000, Kieran Bingham wrote:
> The rcar_du_crtc functions have a heavy reliance on the rcar_du_group
> structure, in many cases just to access the DU device context.
>
> To better separate the groups out of the CRTC handling code, give the
> rcar_du_crtc its own pointer to the device and remove the indirection
> through the group pointers.
I've thought about doing this so many times, every time I had to access
the device from the crtc.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
And taken in my tree.
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 48 +++++++++++++-------------
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 ++
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
> 3 files changed, 27 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> index 57fd5c00494b..471ce464654a 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> @@ -32,21 +32,21 @@
>
> static u32 rcar_du_crtc_read(struct rcar_du_crtc *rcrtc, u32 reg)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> return rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
> }
>
> static void rcar_du_crtc_write(struct rcar_du_crtc *rcrtc, u32 reg, u32 data)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcar_du_write(rcdu, rcrtc->mmio_offset + reg, data);
> }
>
> static void rcar_du_crtc_clr(struct rcar_du_crtc *rcrtc, u32 reg, u32 clr)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
> rcar_du_read(rcdu, rcrtc->mmio_offset + reg) & ~clr);
> @@ -54,7 +54,7 @@ static void rcar_du_crtc_clr(struct rcar_du_crtc *rcrtc, u32 reg, u32 clr)
>
> static void rcar_du_crtc_set(struct rcar_du_crtc *rcrtc, u32 reg, u32 set)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
> rcar_du_read(rcdu, rcrtc->mmio_offset + reg) | set);
> @@ -62,7 +62,7 @@ static void rcar_du_crtc_set(struct rcar_du_crtc *rcrtc, u32 reg, u32 set)
>
> void rcar_du_crtc_dsysr_clr_set(struct rcar_du_crtc *rcrtc, u32 clr, u32 set)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcrtc->dsysr = (rcrtc->dsysr & ~clr) | set;
> rcar_du_write(rcdu, rcrtc->mmio_offset + DSYSR, rcrtc->dsysr);
> @@ -157,10 +157,9 @@ static void rcar_du_dpll_divider(struct rcar_du_crtc *rcrtc,
> }
>
> done:
> - dev_dbg(rcrtc->group->dev->dev,
> + dev_dbg(rcrtc->dev->dev,
> "output:%u, fdpll:%u, n:%u, m:%u, diff:%lu\n",
> - dpll->output, dpll->fdpll, dpll->n, dpll->m,
> - best_diff);
> + dpll->output, dpll->fdpll, dpll->n, dpll->m, best_diff);
> }
>
> struct du_clk_params {
> @@ -212,7 +211,7 @@ static const struct soc_device_attribute rcar_du_r8a7795_es1[] = {
> static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
> {
> const struct drm_display_mode *mode = &rcrtc->crtc.state->adjusted_mode;
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> unsigned long mode_clock = mode->clock * 1000;
> u32 dsmr;
> u32 escr;
> @@ -277,7 +276,7 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
> rcar_du_escr_divider(rcrtc->extclock, mode_clock,
> ESCR_DCLKSEL_DCLKIN, ¶ms);
>
> - dev_dbg(rcrtc->group->dev->dev, "mode clock %lu %s rate %lu\n",
> + dev_dbg(rcrtc->dev->dev, "mode clock %lu %s rate %lu\n",
> mode_clock, params.clk == rcrtc->clock ? "cpg" : "ext",
> params.rate);
>
> @@ -285,7 +284,7 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
> escr = params.escr;
> }
>
> - dev_dbg(rcrtc->group->dev->dev, "%s: ESCR 0x%08x\n", __func__, escr);
> + dev_dbg(rcrtc->dev->dev, "%s: ESCR 0x%08x\n", __func__, escr);
>
> rcar_du_crtc_write(rcrtc, rcrtc->index % 2 ? ESCR13 : ESCR02, escr);
> rcar_du_crtc_write(rcrtc, rcrtc->index % 2 ? OTAR13 : OTAR02, 0);
> @@ -333,7 +332,7 @@ plane_format(struct rcar_du_plane *plane)
> static void rcar_du_crtc_update_planes(struct rcar_du_crtc *rcrtc)
> {
> struct rcar_du_plane *planes[RCAR_DU_NUM_HW_PLANES];
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> unsigned int num_planes = 0;
> unsigned int dptsr_planes;
> unsigned int hwplanes = 0;
> @@ -463,7 +462,7 @@ static bool rcar_du_crtc_page_flip_pending(struct rcar_du_crtc *rcrtc)
>
> static void rcar_du_crtc_wait_page_flip(struct rcar_du_crtc *rcrtc)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> if (wait_event_timeout(rcrtc->flip_wait,
> !rcar_du_crtc_page_flip_pending(rcrtc),
> @@ -493,7 +492,7 @@ static void rcar_du_crtc_setup(struct rcar_du_crtc *rcrtc)
> rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR, 0);
>
> /* Enable the VSP compositor. */
> - if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> + if (rcar_du_has(rcrtc->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> rcar_du_vsp_enable(rcrtc);
>
> /* Turn vertical blanking interrupt reporting on. */
> @@ -564,7 +563,7 @@ static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
>
> static void rcar_du_crtc_disable_planes(struct rcar_du_crtc *rcrtc)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> struct drm_crtc *crtc = &rcrtc->crtc;
> u32 status;
>
> @@ -617,7 +616,7 @@ static void rcar_du_crtc_stop(struct rcar_du_crtc *rcrtc)
> drm_crtc_vblank_off(crtc);
>
> /* Disable the VSP compositor. */
> - if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> + if (rcar_du_has(rcrtc->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> rcar_du_vsp_disable(rcrtc);
>
> /*
> @@ -627,7 +626,7 @@ static void rcar_du_crtc_stop(struct rcar_du_crtc *rcrtc)
> * TODO: Find another way to stop the display for DUs that don't support
> * TVM sync.
> */
> - if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_TVM_SYNC))
> + if (rcar_du_has(rcrtc->dev, RCAR_DU_FEATURE_TVM_SYNC))
> rcar_du_crtc_dsysr_clr_set(rcrtc, DSYSR_TVM_MASK,
> DSYSR_TVM_SWITCH);
>
> @@ -661,7 +660,7 @@ static void rcar_du_crtc_atomic_enable(struct drm_crtc *crtc,
> {
> struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
> struct rcar_du_crtc_state *rstate = to_rcar_crtc_state(crtc->state);
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcar_du_crtc_get(rcrtc);
>
> @@ -689,7 +688,7 @@ static void rcar_du_crtc_atomic_disable(struct drm_crtc *crtc,
> {
> struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
> struct rcar_du_crtc_state *rstate = to_rcar_crtc_state(old_state);
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
>
> rcar_du_crtc_stop(rcrtc);
> rcar_du_crtc_put(rcrtc);
> @@ -735,7 +734,7 @@ static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
> */
> rcar_du_crtc_get(rcrtc);
>
> - if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> + if (rcar_du_has(rcrtc->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> rcar_du_vsp_atomic_begin(rcrtc);
> }
>
> @@ -757,7 +756,7 @@ static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
> spin_unlock_irqrestore(&dev->event_lock, flags);
> }
>
> - if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> + if (rcar_du_has(rcrtc->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
> rcar_du_vsp_atomic_flush(rcrtc);
> }
>
> @@ -766,7 +765,7 @@ rcar_du_crtc_mode_valid(struct drm_crtc *crtc,
> const struct drm_display_mode *mode)
> {
> struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> bool interlaced = mode->flags & DRM_MODE_FLAG_INTERLACE;
> unsigned int vbp;
>
> @@ -798,7 +797,7 @@ static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
>
> static void rcar_du_crtc_crc_init(struct rcar_du_crtc *rcrtc)
> {
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> const char **sources;
> unsigned int count;
> int i = -1;
> @@ -1080,7 +1079,7 @@ static const struct drm_crtc_funcs crtc_funcs_gen3 = {
> static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
> {
> struct rcar_du_crtc *rcrtc = arg;
> - struct rcar_du_device *rcdu = rcrtc->group->dev;
> + struct rcar_du_device *rcdu = rcrtc->dev;
> irqreturn_t ret = IRQ_NONE;
> u32 status;
>
> @@ -1172,6 +1171,7 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex,
> init_waitqueue_head(&rcrtc->vblank_wait);
> spin_lock_init(&rcrtc->vblank_lock);
>
> + rcrtc->dev = rcdu;
> rcrtc->group = rgrp;
> rcrtc->mmio_offset = mmio_offsets[hwindex];
> rcrtc->index = hwindex;
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> index 3f339a7e8d14..11814eafef77 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
> @@ -24,6 +24,7 @@ struct rcar_du_vsp;
> /**
> * struct rcar_du_crtc - the CRTC, representing a DU superposition processor
> * @crtc: base DRM CRTC
> + * @dev: the DU device
> * @clock: the CRTC functional clock
> * @extclock: external pixel dot clock (optional)
> * @mmio_offset: offset of the CRTC registers in the DU MMIO block
> @@ -43,6 +44,7 @@ struct rcar_du_vsp;
> struct rcar_du_crtc {
> struct drm_crtc crtc;
>
> + struct rcar_du_device *dev;
> struct clk *clock;
> struct clk *extclock;
> unsigned int mmio_offset;
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> index 0878accbd134..f6deea90dcce 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> @@ -43,7 +43,7 @@ static void rcar_du_vsp_complete(void *private, bool completed, u32 crc)
> void rcar_du_vsp_enable(struct rcar_du_crtc *crtc)
> {
> const struct drm_display_mode *mode = &crtc->crtc.state->adjusted_mode;
> - struct rcar_du_device *rcdu = crtc->group->dev;
> + struct rcar_du_device *rcdu = crtc->dev;
> struct vsp1_du_lif_config cfg = {
> .width = mode->hdisplay,
> .height = mode->vdisplay,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-17 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:01 [PATCH v2 0/6] drm: rcar-du: Rework CRTC and groups for atomic commits Kieran Bingham
2019-03-15 17:01 ` [PATCH v2 1/6] drm: rcar-du: Link CRTCs to the DU device Kieran Bingham
2019-03-17 22:55 ` Laurent Pinchart [this message]
2019-03-15 17:01 ` [PATCH v2 2/6] drm: rcar-du: Add CRTC standby helpers Kieran Bingham
2019-05-12 13:24 ` Laurent Pinchart
2019-03-15 17:01 ` [PATCH v2 3/6] drm: rcar-du: Add pre/post commit CRTC helpers Kieran Bingham
2019-05-12 13:35 ` Laurent Pinchart
2019-03-15 17:01 ` [PATCH v2 4/6] drm: rcar-du: Provide for_each_group helper Kieran Bingham
2019-05-12 13:48 ` Laurent Pinchart
2019-03-15 17:01 ` [PATCH v2 5/6] drm: rcar-du: Create a group state object Kieran Bingham
2019-05-12 13:55 ` Laurent Pinchart
2019-03-15 17:01 ` [PATCH v2 6/6] drm: rcar-du: Add group hooks for atomic-commit Kieran Bingham
2019-05-12 16:41 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317225525.GC12636@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).