From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: nicholas.kazlauskas@amd.com, dri-devel@lists.freedesktop.org
Subject: AMD Freesync patches for proper vblank and pageflip timestamping in VRR mode.
Date: Mon, 18 Mar 2019 18:19:48 +0100 [thread overview]
Message-ID: <20190318171952.24302-1-mario.kleiner.de@gmail.com> (raw)
Hi
This series implements properly working vblank and pageflip completion
timestamping for amdgpu in VRR / FreeSync mode.
Now pageflip timestamps for pageflip events always carry the
vblank timestamp of the vblank in which the flip completed,
and the vblank timestamp is as accurate as in fixed refresh
rate mode.
It was successfully tested on a DCE-8 gpu by myself, and also
lightly tested on a DCN-1 gpu by Nicholas Kazlauskas.
I want to thank Nicholas for helpful discussions, testing and
feedback on this patch series.
The series applies cleanly to current agd5f/drm-next-5.2-wip, against
which it was tested. It also applies against current amd-staging-drm-next
with a trivial fix to patch 2/4 like shown in the diff below:
Thanks,
-mario
@@ -80,2 +80,3 @@
- uint32_t target, target_vblank;
+ bool pflip_present = false;
- uint64_t last_flip_vblank;
@@ -84,3 +85,2 @@
+ bool vrr_active = amdgpu_dm_vrr_active(acrtc_state);
- bool pflip_present = false;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-03-18 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:19 Mario Kleiner [this message]
2019-03-18 17:19 ` [PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active Mario Kleiner
[not found] ` <20190318171952.24302-2-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-18 17:29 ` Kazlauskas, Nicholas
2019-03-20 8:14 ` Mario Kleiner
[not found] ` <20190318171952.24302-1-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-18 17:19 ` [PATCH 2/4] drm/amd/display: Rework vrr flip throttling for late vblank irq Mario Kleiner
2019-03-18 17:59 ` Kazlauskas, Nicholas
2019-03-18 17:19 ` [PATCH 4/4] drm/amd/display: Make pageflip event delivery compatible with VRR Mario Kleiner
[not found] ` <20190318171952.24302-5-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-19 13:05 ` Kazlauskas, Nicholas
2019-03-18 17:19 ` [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank Mario Kleiner
[not found] ` <20190318171952.24302-4-mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-19 7:17 ` Paul Menzel
2019-03-19 13:23 ` Kazlauskas, Nicholas
[not found] ` <8ef78169-1893-0aee-9cb1-cce4054ebbcc-5C7GfCeVMHo@public.gmane.org>
2019-03-19 13:32 ` Kazlauskas, Nicholas
2019-03-20 7:51 ` Mario Kleiner
2019-03-20 12:53 ` Kazlauskas, Nicholas
[not found] ` <b00cc1c5-f710-6c75-cdd2-c9ad30c633aa-5C7GfCeVMHo@public.gmane.org>
2019-03-21 9:39 ` Mario Kleiner
2019-03-21 15:38 ` Wentland, Harry
[not found] ` <929bad72-fb12-661e-d7e3-ac837d32c01c-5C7GfCeVMHo@public.gmane.org>
2019-03-21 15:48 ` Kazlauskas, Nicholas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318171952.24302-1-mario.kleiner.de@gmail.com \
--to=mario.kleiner.de@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=nicholas.kazlauskas@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).