dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel
@ 2018-11-24 20:06 Brian Masney
  2018-11-24 20:06 ` [PATCH 2/2] " Brian Masney
  2019-03-05 22:42 ` [PATCH 1/2] dt-bindings: " Linus Walleij
  0 siblings, 2 replies; 6+ messages in thread
From: Brian Masney @ 2018-11-24 20:06 UTC (permalink / raw)
  To: thierry.reding, airlied, robh+dt, mark.rutland
  Cc: dri-devel, linux-kernel, devicetree, jonathan

Add binding for the LG ACX467AKM-7 4.95" 1080×1920 LCD panel that is
found on the LG Nexus 5 (hammerhead) phone. This appears to be a JDI
panel based on some Internet searches, however a specific model number
could not be found. I disassembled an old Nexus 5 with a broken
screen and the LG part number is the only model number present on the
back of the panel, so I think that is probably the best ID to use.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 .../devicetree/bindings/display/panel/lg,acx467akm-7.txt   | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,acx467akm-7.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,acx467akm-7.txt b/Documentation/devicetree/bindings/display/panel/lg,acx467akm-7.txt
new file mode 100644
index 000000000000..fc1e1b325e49
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,acx467akm-7.txt
@@ -0,0 +1,7 @@
+LG ACX467AKM-7 4.95" 1080×1920 LCD Panel
+
+Required properties:
+- compatible: must be "lg,acx467akm-7"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] drm/panel: simple: add lg,acx467akm-7 panel
  2018-11-24 20:06 [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel Brian Masney
@ 2018-11-24 20:06 ` Brian Masney
  2019-03-05 22:43   ` Linus Walleij
  2019-03-05 22:42 ` [PATCH 1/2] dt-bindings: " Linus Walleij
  1 sibling, 1 reply; 6+ messages in thread
From: Brian Masney @ 2018-11-24 20:06 UTC (permalink / raw)
  To: thierry.reding, airlied, robh+dt, mark.rutland
  Cc: dri-devel, linux-kernel, devicetree, jonathan

From: Jonathan Marek <jonathan@marek.ca>

Add ACX467AKM-7 4.95" 1080×1920 LCD panel that is found on the LG Nexus
5 (hammerhead) phone.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[masneyb@onstation.org: checkpatch fixes; rename jdi,1080p-hammerhead
binding to lg,acx467akm-7.]
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
See patch 1 in this series for why I went with the LG model number.

 drivers/gpu/drm/panel/panel-simple.c | 31 ++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 97964f7f2ace..a772a8cc1eae 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2761,6 +2761,34 @@ static const struct panel_desc_dsi panasonic_vvx10f004b00 = {
 	.lanes = 4,
 };
 
+static const struct drm_display_mode lg_acx467akm_7_mode = {
+	.clock = 150000,
+	.hdisplay = 1080,
+	.hsync_start = 1080 + 2,
+	.hsync_end = 1080 + 2 + 2,
+	.htotal = 1080 + 2 + 2 + 2,
+	.vdisplay = 1920,
+	.vsync_start = 1920 + 2,
+	.vsync_end = 1920 + 2 + 2,
+	.vtotal = 1920 + 2 + 2 + 2,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc_dsi lg_acx467akm_7 = {
+	.desc = {
+		.modes = &lg_acx467akm_7_mode,
+		.num_modes = 1,
+		.bpc = 8,
+		.size = {
+			.width = 62,
+			.height = 110,
+		},
+	},
+	.flags = 0,
+	.format = MIPI_DSI_FMT_RGB888,
+	.lanes = 4,
+};
+
 static const struct of_device_id dsi_of_match[] = {
 	{
 		.compatible = "auo,b080uan01",
@@ -2777,6 +2805,9 @@ static const struct of_device_id dsi_of_match[] = {
 	}, {
 		.compatible = "panasonic,vvx10f004b00",
 		.data = &panasonic_vvx10f004b00
+	}, {
+		.compatible = "lg,acx467akm-7",
+		.data = &lg_acx467akm_7
 	}, {
 		/* sentinel */
 	}
-- 
2.17.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel
  2018-11-24 20:06 [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel Brian Masney
  2018-11-24 20:06 ` [PATCH 2/2] " Brian Masney
@ 2019-03-05 22:42 ` Linus Walleij
  2019-03-20  9:17   ` Brian Masney
  1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2019-03-05 22:42 UTC (permalink / raw)
  To: Brian Masney
  Cc: thierry.reding, Dave Airlie, Rob Herring, Mark Rutland,
	open list:DRM PANEL DRIVERS, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Jonathan Marek

On Sat, Nov 24, 2018 at 9:06 PM Brian Masney <masneyb@onstation.org> wrote:

> Add binding for the LG ACX467AKM-7 4.95" 1080×1920 LCD panel that is
> found on the LG Nexus 5 (hammerhead) phone. This appears to be a JDI
> panel based on some Internet searches, however a specific model number
> could not be found. I disassembled an old Nexus 5 with a broken
> screen and the LG part number is the only model number present on the
> back of the panel, so I think that is probably the best ID to use.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Tell me if you need me to merge this to the DRM misc tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] drm/panel: simple: add lg,acx467akm-7 panel
  2018-11-24 20:06 ` [PATCH 2/2] " Brian Masney
@ 2019-03-05 22:43   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-03-05 22:43 UTC (permalink / raw)
  To: Brian Masney
  Cc: thierry.reding, Dave Airlie, Rob Herring, Mark Rutland,
	open list:DRM PANEL DRIVERS, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Jonathan Marek

On Sat, Nov 24, 2018 at 9:06 PM Brian Masney <masneyb@onstation.org> wrote:

> From: Jonathan Marek <jonathan@marek.ca>
>
> Add ACX467AKM-7 4.95" 1080×1920 LCD panel that is found on the LG Nexus
> 5 (hammerhead) phone.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> [masneyb@onstation.org: checkpatch fixes; rename jdi,1080p-hammerhead
> binding to lg,acx467akm-7.]
> Signed-off-by: Brian Masney <masneyb@onstation.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Tell me if you need me to merge this to the DRI misc tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel
  2019-03-05 22:42 ` [PATCH 1/2] dt-bindings: " Linus Walleij
@ 2019-03-20  9:17   ` Brian Masney
  2019-04-17 21:04     ` Linus Walleij
  0 siblings, 1 reply; 6+ messages in thread
From: Brian Masney @ 2019-03-20  9:17 UTC (permalink / raw)
  To: Linus Walleij
  Cc: thierry.reding, Dave Airlie, Rob Herring, Mark Rutland,
	open list:DRM PANEL DRIVERS, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Jonathan Marek

Hi Linus,

On Tue, Mar 05, 2019 at 11:42:15PM +0100, Linus Walleij wrote:
> On Sat, Nov 24, 2018 at 9:06 PM Brian Masney <masneyb@onstation.org> wrote:
> 
> > Add binding for the LG ACX467AKM-7 4.95" 1080×1920 LCD panel that is
> > found on the LG Nexus 5 (hammerhead) phone. This appears to be a JDI
> > panel based on some Internet searches, however a specific model number
> > could not be found. I disassembled an old Nexus 5 with a broken
> > screen and the LG part number is the only model number present on the
> > back of the panel, so I think that is probably the best ID to use.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Tell me if you need me to merge this to the DRM misc tree.

It would be great if you could take this patch, plus the corresponding
change to panel-simple.c [1]

[1] https://lore.kernel.org/lkml/20181124200628.24393-2-masneyb@onstation.org/

Thanks,

Brian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel
  2019-03-20  9:17   ` Brian Masney
@ 2019-04-17 21:04     ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-04-17 21:04 UTC (permalink / raw)
  To: Brian Masney
  Cc: thierry.reding, Dave Airlie, Rob Herring, Mark Rutland,
	open list:DRM PANEL DRIVERS, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Jonathan Marek

On Wed, Mar 20, 2019 at 10:17 AM Brian Masney <masneyb@onstation.org> wrote:
> On Tue, Mar 05, 2019 at 11:42:15PM +0100, Linus Walleij wrote:
> > On Sat, Nov 24, 2018 at 9:06 PM Brian Masney <masneyb@onstation.org> wrote:
> >
> > > Add binding for the LG ACX467AKM-7 4.95" 1080×1920 LCD panel that is
> > > found on the LG Nexus 5 (hammerhead) phone. This appears to be a JDI
> > > panel based on some Internet searches, however a specific model number
> > > could not be found. I disassembled an old Nexus 5 with a broken
> > > screen and the LG part number is the only model number present on the
> > > back of the panel, so I think that is probably the best ID to use.
> > >
> > > Signed-off-by: Brian Masney <masneyb@onstation.org>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Tell me if you need me to merge this to the DRM misc tree.
>
> It would be great if you could take this patch, plus the corresponding
> change to panel-simple.c [1]
>
> [1] https://lore.kernel.org/lkml/20181124200628.24393-2-masneyb@onstation.org/

Both patches applied to drm-misc-next (will be in v5.2). Sorry for taking so
long, I had some urgent other priorities.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-17 21:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-24 20:06 [PATCH 1/2] dt-bindings: drm/panel: simple: add lg,acx467akm-7 panel Brian Masney
2018-11-24 20:06 ` [PATCH 2/2] " Brian Masney
2019-03-05 22:43   ` Linus Walleij
2019-03-05 22:42 ` [PATCH 1/2] dt-bindings: " Linus Walleij
2019-03-20  9:17   ` Brian Masney
2019-04-17 21:04     ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).