From: Andrzej Hajda <a.hajda@samsung.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
dri-devel@lists.freedesktop.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v3 RESEND 22/24] drm/exynos/decon5433: wait for finish previous update
Date: Mon, 25 Mar 2019 08:13:47 +0100 [thread overview]
Message-ID: <20190325071349.22600-23-a.hajda@samsung.com> (raw)
In-Reply-To: <20190325071349.22600-1-a.hajda@samsung.com>
DECON should wait for previous update before starting new one. Otherwise
internal registers can be updated in non-atomic, error prone way.
This patch fixes occasional occurrences of vblank timeouts on tm2 platform:
[ 3167.968742] [CRTC:55:crtc-0] vblank wait timed out
[ 3167.987440] WARNING: CPU: 1 PID: 194 at ../drivers/gpu/drm/drm_atomic_helper.c:1423 drm_atomic_helper_wait_for_vblanks.part.9+0x2c0/0x2c8
[ 3168.029990] Modules linked in:
[ 3168.047240] CPU: 1 PID: 194 Comm: modetest Tainted: G W 5.0.0-rc1+ #694
[ 3168.069539] Hardware name: Samsung TM2 board (DT)
...
[ 3168.453566] Call trace:
[ 3168.469705] drm_atomic_helper_wait_for_vblanks.part.9+0x2c0/0x2c8
[ 3168.489983] drm_atomic_helper_commit_tail_rpm+0x60/0x78
[ 3168.509463] commit_tail+0x44/0x78
[ 3168.527053] drm_atomic_helper_commit+0xe8/0x160
[ 3168.546010] drm_atomic_commit+0x48/0x58
[ 3168.564304] drm_atomic_helper_update_plane+0x11c/0x140
[ 3168.584080] __setplane_atomic+0x130/0x150
[ 3168.602799] setplane_internal+0xb0/0x1a8
[ 3168.621493] drm_mode_setplane+0xc4/0x1b8
[ 3168.640219] drm_ioctl_kernel+0x94/0x110
[ 3168.658920] drm_ioctl+0x1c8/0x428
...
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index b0332763594e..09f035f52444 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -406,6 +406,11 @@ static void decon_set_gscl_mode(struct decon_context *ctx)
static void decon_atomic_begin(struct exynos_drm_crtc *crtc)
{
struct decon_context *ctx = to_decon(crtc);
+ u32 val;
+
+ /* wait for finish previous updates */
+ if (readl_poll_timeout(ctx->addr + DECON_UPDATE, val, !val, 1000, 20000) < 0)
+ dev_err(ctx->dev, "DECON_UPDATE timeout\n");
decon_shadow_protect(ctx, true);
decon_set_gscl_mode(ctx);
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-25 7:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190325071353eucas1p185d973e14dac923aab381083b2b67445@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433 Andrzej Hajda
[not found] ` <CGME20190325071353eucas1p13470b85473aa92b25d38fcf4eceea76e@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 01/24] arm64: dts: exynos: configure GSCALER related clocks Andrzej Hajda
2019-03-25 7:50 ` Krzysztof Kozlowski
2019-03-25 8:31 ` Andrzej Hajda
2019-03-25 8:44 ` Krzysztof Kozlowski
[not found] ` <CGME20190325071354eucas1p17f990ee93878c5909800044779b41451@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 02/24] arm64: dts: exynos: add DSD/GSD clocks to DECONs and GSCALERs Andrzej Hajda
[not found] ` <CGME20190325071354eucas1p181987b86e0e2df42f704f3e95f0c2b18@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 03/24] drm/exynos: remove exynos_drm_plane.h header Andrzej Hajda
[not found] ` <CGME20190325071354eucas1p11b39f3a06807b8619cea583c7dc40c18@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 04/24] drm/exynos: remove spare macro Andrzej Hajda
[not found] ` <CGME20190325071355eucas1p1bc10232953b0d9f122ee7d3d532374e8@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 05/24] drm/exynos: drop exynos_drm_plane_config structure Andrzej Hajda
[not found] ` <CGME20190325071355eucas1p1cbb56752b2560cb6384d79df9c4124a3@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 06/24] drm/exynos: add exynos_drm_crtc_init function Andrzej Hajda
[not found] ` <CGME20190325071356eucas1p111ff1323f9ef55582b6983ce91a0e58a@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 07/24] drm/exynos/decon5433: embed exynos_drm_crtc directly into context Andrzej Hajda
[not found] ` <CGME20190325071356eucas1p17598af50b99cecd3f04bd5bd7b665468@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 08/24] drm/exynos/decon7: " Andrzej Hajda
[not found] ` <CGME20190325071356eucas1p169112fff9a6b5914c93b162a267348f1@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 09/24] drm/exynos/fimd: " Andrzej Hajda
[not found] ` <CGME20190325071357eucas1p1d1def486ebc1697def8c4d670b7cd15c@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 10/24] drm/exynos/mixer: " Andrzej Hajda
[not found] ` <CGME20190325071357eucas1p107f56a7c71d033687e02d8eab03c8635@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 11/24] drm/exynos/vidi: " Andrzej Hajda
[not found] ` <CGME20190325071358eucas1p19d8fa7080e588979618ac4bb4aeccbeb@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 12/24] drm/exynos: remove standalone exynos_drm_crtc leftovers Andrzej Hajda
[not found] ` <CGME20190325071358eucas1p1e7f9aa715ac8f04b20fe6a64aa83700d@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 13/24] drm/exynos/vidi: remove encoder_to_vidi helper Andrzej Hajda
[not found] ` <CGME20190325071359eucas1p1b08952b714f0f81d694a0c0db8332521@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 14/24] drm/exynos: unify plane type assignment Andrzej Hajda
[not found] ` <CGME20190325071359eucas1p1701719f798584cd23cc8058d2f2c495b@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 15/24] drm/exynos: set primary plane in exynos_drm_crtc_init Andrzej Hajda
[not found] ` <CGME20190325071359eucas1p1b97bf55b51b840f4a049df4779800f11@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 16/24] drm/exynos: set cursor " Andrzej Hajda
[not found] ` <CGME20190325071400eucas1p1f80832bb0feba9bd11187aecf1ae61c7@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 17/24] drm/exynos: add plane update/disable callbacks for planes Andrzej Hajda
[not found] ` <CGME20190325071400eucas1p1a6740040c56d51b0a3658ec01c1bb9f6@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 18/24] drm/exynos: add GSCALER plane capability Andrzej Hajda
[not found] ` <CGME20190325071401eucas1p1ddc56702c8ff146f0fd84277f3f84e08@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 19/24] drm/exynos/gscaler: fix id assignement Andrzej Hajda
[not found] ` <CGME20190325071401eucas1p10d9ad1fcfc4a5e4f2b964cf04e5e5fe8@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 20/24] drm/exynos/gscaler: add local path support Andrzej Hajda
[not found] ` <CGME20190325071401eucas1p10df709b256570f1aba9cbc4e875da1b3@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 21/24] drm/exynos/decon5433: " Andrzej Hajda
2022-02-06 16:51 ` Krzysztof Kozlowski
2022-03-02 1:00 ` Inki Dae
2022-03-03 16:03 ` Krzysztof Kozlowski
2022-03-03 16:11 ` Marek Szyprowski
2022-03-03 16:12 ` Krzysztof Kozlowski
[not found] ` <CGME20190325071402eucas1p12176421bacd4f9bcf9341bc776044c56@eucas1p1.samsung.com>
2019-03-25 7:13 ` Andrzej Hajda [this message]
[not found] ` <CGME20190325071402eucas1p1b21cd8cb6a2bfa0349821597b6291af5@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 23/24] drm/exynos/gscaler: change supported color format BGRX8888 to XBGR8888 Andrzej Hajda
[not found] ` <CGME20190325071403eucas1p15267241039dc4b1911f2357b7a43baac@eucas1p1.samsung.com>
2019-03-25 7:13 ` [PATCH v3 RESEND 24/24] drm/exynos/gscaler: fix handling YVU420 pixel format Andrzej Hajda
2019-03-26 8:45 ` [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433 Inki Dae
2019-03-26 13:51 ` Andrzej Hajda
2019-03-27 2:26 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325071349.22600-23-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).