From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacopo Mondi Subject: Re: [PATCH 2/9] v4l: Add definitions for missing 16-bit RGB4444 formats Date: Thu, 4 Apr 2019 18:00:49 +0200 Message-ID: <20190404160049.cref72fegfwqiffy@uno.localdomain> References: <20190328070723.26553-1-laurent.pinchart+renesas@ideasonboard.com> <20190328070723.26553-3-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0852136279==" Return-path: Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBC406E1B7 for ; Thu, 4 Apr 2019 16:00:05 +0000 (UTC) In-Reply-To: <20190328070723.26553-3-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, Maxime Ripard , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============0852136279== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eg4rmzo2hyharnnz" Content-Disposition: inline --eg4rmzo2hyharnnz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Laurent, On Thu, Mar 28, 2019 at 09:07:16AM +0200, Laurent Pinchart wrote: > The V4L2 API is missing the 16-bit RGB4444 formats for the RGBA, RGBX, > ABGR, XBGR, BGRA and BGRX component orders. Add them, using the same > 4CCs as DRM. > > Signed-off-by: Laurent Pinchart I checked the documentation and it seems right, I cannot relate the name to the ordering but I guess this is intended. Reviewed-by: Jacopo Mondi Thanks j > --- > .../media/uapi/v4l/pixfmt-packed-rgb.rst | 138 ++++++++++++++++++ > include/uapi/linux/videodev2.h | 6 + > 2 files changed, 144 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst b/Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst > index 055f9c89e787..b475cbba492f 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst > @@ -139,6 +139,144 @@ next to each other in memory. > - r\ :sub:`1` > - r\ :sub:`0` > - > + * .. _V4L2-PIX-FMT-RGBA444: > + > + - ``V4L2_PIX_FMT_RGBA444`` > + - 'RA12' > + > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - a\ :sub:`3` > + - a\ :sub:`2` > + - a\ :sub:`1` > + - a\ :sub:`0` > + > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - > + * .. _V4L2-PIX-FMT-RGBX444: > + > + - ``V4L2_PIX_FMT_RGBX444`` > + - 'RX12' > + > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - > + - > + - > + - > + > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - > + * .. _V4L2-PIX-FMT-ABGR444: > + > + - ``V4L2_PIX_FMT_ABGR444`` > + - 'AB12' > + > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + > + - a\ :sub:`3` > + - a\ :sub:`2` > + - a\ :sub:`1` > + - a\ :sub:`0` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - > + * .. _V4L2-PIX-FMT-XBGR444: > + > + - ``V4L2_PIX_FMT_XBGR444`` > + - 'XB12' > + > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + > + - > + - > + - > + - > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - > + * .. _V4L2-PIX-FMT-BGRA444: > + > + - ``V4L2_PIX_FMT_BGRA444`` > + - 'BA12' > + > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - a\ :sub:`3` > + - a\ :sub:`2` > + - a\ :sub:`1` > + - a\ :sub:`0` > + > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - > + * .. _V4L2-PIX-FMT-BGRX444: > + > + - ``V4L2_PIX_FMT_BGRX444`` > + - 'BX12' > + > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > + - > + - > + - > + - > + > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - > * .. _V4L2-PIX-FMT-ARGB555: > > - ``V4L2_PIX_FMT_ARGB555`` > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 4e5222726719..df9fa78a6ab7 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -514,6 +514,12 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_RGB444 v4l2_fourcc('R', '4', '4', '4') /* 16 xxxxrrrr ggggbbbb */ > #define V4L2_PIX_FMT_ARGB444 v4l2_fourcc('A', 'R', '1', '2') /* 16 aaaarrrr ggggbbbb */ > #define V4L2_PIX_FMT_XRGB444 v4l2_fourcc('X', 'R', '1', '2') /* 16 xxxxrrrr ggggbbbb */ > +#define V4L2_PIX_FMT_RGBA444 v4l2_fourcc('R', 'A', '1', '2') /* 16 rrrrgggg bbbbaaaa */ > +#define V4L2_PIX_FMT_RGBX444 v4l2_fourcc('R', 'X', '1', '2') /* 16 rrrrgggg bbbbxxxx */ > +#define V4L2_PIX_FMT_ABGR444 v4l2_fourcc('A', 'B', '1', '2') /* 16 aaaabbbb ggggrrrr */ > +#define V4L2_PIX_FMT_XBGR444 v4l2_fourcc('X', 'B', '1', '2') /* 16 xxxxbbbb ggggrrrr */ > +#define V4L2_PIX_FMT_BGRA444 v4l2_fourcc('B', 'A', '1', '2') /* 16 bbbbgggg rrrraaaa */ > +#define V4L2_PIX_FMT_BGRX444 v4l2_fourcc('B', 'X', '1', '2') /* 16 bbbbgggg rrrrxxxx */ > #define V4L2_PIX_FMT_RGB555 v4l2_fourcc('R', 'G', 'B', 'O') /* 16 RGB-5-5-5 */ > #define V4L2_PIX_FMT_ARGB555 v4l2_fourcc('A', 'R', '1', '5') /* 16 ARGB-1-5-5-5 */ > #define V4L2_PIX_FMT_XRGB555 v4l2_fourcc('X', 'R', '1', '5') /* 16 XRGB-1-5-5-5 */ > -- > Regards, > > Laurent Pinchart > --eg4rmzo2hyharnnz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAlymKjAACgkQcjQGjxah VjzqmA//efK6SohvLYy9x5UMX5e6Y1NbI5u3O+N6j9xLUfDNgLvGM8Oc/9XGBSOX cISIOsfIVfSzTd9TPy5S15/cXhConcaMZeeIdO+j6KFk0iak3HAnevxEjXnSgxEx 8+UFrpgsP9dN8sDuhisxswzX8gcwqHYuWYK2qcICHQS2+WwxP4kxx5TtCDAay7u6 dHyfOve8EWGes4a/DhqBycl3osSqW9iJP0yJc/t+nrKXxjM0I/QIcNEfBc1ripQT imWsQFxakOXPXJbgNI6KClR02fxchcpPNRnde3aP4R2e5PnTh0qgoQWTV5yOEw9z NO8mdgmXFqxIJ4PyfaK5SB8NkkB3qeejgiLTb2Z++0U3H4P41VTIRYLj60Xkpt9m kMKW8yCyJE7tbcPfcEKnXPzaqLPTeFw/QwbCkC7z3mVUzY5HtXT3PpVjySEVbG3x IT2SLG2nePtuUN2zoi11/Prl5M8kMvCmOuHslFD8tcYRqwBK2StaPweVUXHfYHFr MZObAfDaQpbh28o0bfXikCNKBhLfkeHtLq1RKSHeXObUX7qctoSw+QyLxSS2O5NB e0/qakqqyi6NtknmFbxQ2aLJi8C8h2wUu6PSJgQFanDO6x1EEPKo+vaHnMWlVHAc 7FbqzfANgjmdlvA79IMGue7Bb3lmv3eXr1wHL+6ceWi9p3seCmE= =xMMM -----END PGP SIGNATURE----- --eg4rmzo2hyharnnz-- --===============0852136279== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0852136279==--