From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 1/2] drm: bridge: dw-hdmi: Add hooks for suspend/resume Date: Wed, 15 May 2019 14:05:03 -0400 Message-ID: <20190515180503.GU17077@art_vandelay> References: <20190502223808.185180-1-dianders@chromium.org> <20190515175826.GT17077@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Sean Paul , Heiko Stuebner , Sandy Huang , Andrzej Hajda , Laurent Pinchart , "open list:ARM/Rockchip SoC..." , Neil Armstrong , Matthias Kaehlcke , Sean Paul , Zheng Yang , Sam Ravnborg , dri-devel , LKML , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , David Airlie , Jernej Skrabec , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org On Wed, May 15, 2019 at 11:01:26AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 15, 2019 at 10:58 AM Sean Paul wrote: > > > On Thu, May 02, 2019 at 03:38:07PM -0700, Douglas Anderson wrote: > > > On Rockchip rk3288-based Chromebooks when you do a suspend/resume > > > cycle: > > > > > > 1. You lose the ability to detect an HDMI device being plugged in. > > > > > > 2. If you're using the i2c bus built in to dw_hdmi then it stops > > > working. > > > > > > Let's add a hook to the core dw-hdmi driver so that we can call it in > > > dw_hdmi-rockchip in the next commit. > > > > > > NOTE: the exact set of steps I've done here in resume come from > > > looking at the normal dw_hdmi init sequence in upstream Linux plus the > > > sequence that we did in downstream Chrome OS 3.14. Testing show that > > > it seems to work, but if an extra step is needed or something here is > > > not needed we could improve it. > > > > > > Signed-off-by: Douglas Anderson > > > --- > > > > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 +++++++++++++++++++++ > > > include/drm/bridge/dw_hdmi.h | 3 +++ > > > 2 files changed, 24 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > index db761329a1e3..4b38bfd43e59 100644 > > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > > @@ -2780,6 +2780,27 @@ void dw_hdmi_unbind(struct dw_hdmi *hdmi) > > > } > > > EXPORT_SYMBOL_GPL(dw_hdmi_unbind); > > > > > > +int dw_hdmi_suspend(struct dw_hdmi *hdmi) > > > +{ > > > + return 0; > > > +} > > > +EXPORT_SYMBOL_GPL(dw_hdmi_suspend); > > > + > > > +int dw_hdmi_resume(struct dw_hdmi *hdmi) > > > +{ > > > + initialize_hdmi_ih_mutes(hdmi); > > > + > > > + dw_hdmi_setup_i2c(hdmi); > > > + if (hdmi->i2c) > > > + dw_hdmi_i2c_init(hdmi); > > > + > > > + if (hdmi->phy.ops->setup_hpd) > > > + hdmi->phy.ops->setup_hpd(hdmi, hdmi->phy.data); > > > + > > > + return 0; > > > +} > > > +EXPORT_SYMBOL_GPL(dw_hdmi_resume); > > > > Both patches look good to me, I'd probably prefer to just smash them together, > > but meh. > > > > If no one more authoritative chimes in, I'll apply them to -misc in a few days. > > Sure. I can smash them and re-post or you can smash them for me or we > can keep them as-is. I originally separated because I wasn't sure if > they'd eventually go through different trees. Just let me know! :-) Definitely no need to repost. It's entirely possible Andrzej or Heiko prefer to have the dw-hdmi stuff broken out anyways. My opinion is of little value here :) Sean > > -Doug -- Sean Paul, Software Engineer, Google / Chromium OS