From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 07/10] drm/vkms: Dont flush crc worker when we change crc status
Date: Fri, 7 Jun 2019 00:27:48 +0200 [thread overview]
Message-ID: <20190606222751.32567-8-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190606222751.32567-1-daniel.vetter@ffwll.ch>
The crc core code can cope with some late crc, the race is kinda
unavoidable. So no need to flush pending workers, they'll complete in
time.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
drivers/gpu/drm/vkms/vkms_crc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_crc.c b/drivers/gpu/drm/vkms/vkms_crc.c
index 96806cd35ad4..9d15e5e85830 100644
--- a/drivers/gpu/drm/vkms/vkms_crc.c
+++ b/drivers/gpu/drm/vkms/vkms_crc.c
@@ -249,9 +249,6 @@ int vkms_set_crc_source(struct drm_crtc *crtc, const char *src_name)
ret = vkms_crc_parse_source(src_name, &enabled);
- /* make sure nothing is scheduled on crtc workq */
- flush_workqueue(out->crc_workq);
-
spin_lock_irq(&out->lock);
out->crc_enabled = enabled;
spin_unlock_irq(&out->lock);
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-06 22:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 22:27 [PATCH 00/10] drm/vkms: rework crc worker Daniel Vetter
2019-06-06 22:27 ` [PATCH 01/10] drm/vkms: Fix crc worker races Daniel Vetter
2019-06-12 13:33 ` Rodrigo Siqueira
2019-06-12 14:48 ` Daniel Vetter
2019-06-18 2:39 ` Rodrigo Siqueira
2019-06-18 8:49 ` Daniel Vetter
2019-06-06 22:27 ` [PATCH 02/10] drm/vkms: Use spin_lock_irq in process context Daniel Vetter
2019-06-12 13:34 ` Rodrigo Siqueira
2019-06-12 14:54 ` Daniel Vetter
2019-06-06 22:27 ` [PATCH 03/10] drm/vkms: Rename vkms_output.state_lock to crc_lock Daniel Vetter
2019-06-12 13:38 ` Rodrigo Siqueira
2019-06-13 7:48 ` Daniel Vetter
2019-06-06 22:27 ` [PATCH 04/10] drm/vkms: Move format arrays to vkms_plane.c Daniel Vetter
2019-06-12 13:39 ` Rodrigo Siqueira
2019-06-19 2:12 ` Rodrigo Siqueira
2019-06-06 22:27 ` [PATCH 05/10] drm/vkms: Add our own commit_tail Daniel Vetter
2019-06-06 22:27 ` [PATCH 06/10] drm/vkms: flush crc workers earlier in commit flow Daniel Vetter
2019-06-12 13:42 ` Rodrigo Siqueira
2019-06-13 7:53 ` Daniel Vetter
2019-06-13 7:55 ` Daniel Vetter
2019-06-18 2:31 ` Rodrigo Siqueira
2019-06-06 22:27 ` Daniel Vetter [this message]
2019-06-19 2:17 ` [PATCH 07/10] drm/vkms: Dont flush crc worker when we change crc status Rodrigo Siqueira
2019-06-19 7:47 ` Daniel Vetter
2019-06-06 22:27 ` [PATCH 08/10] drm/vkms: No _irqsave within spin_lock_irq needed Daniel Vetter
2019-06-12 13:43 ` Rodrigo Siqueira
2019-06-06 22:27 ` [PATCH 09/10] drm/vkms: totally reworked crc data tracking Daniel Vetter
2019-06-12 13:46 ` Rodrigo Siqueira
2019-06-13 7:59 ` Daniel Vetter
2019-06-06 22:27 ` [PATCH 10/10] drm/vkms: No need for ->pages_lock in crc work anymore Daniel Vetter
2019-06-12 13:47 ` Rodrigo Siqueira
2019-06-12 13:28 ` [PATCH 00/10] drm/vkms: rework crc worker Rodrigo Siqueira
2019-06-12 14:42 ` Daniel Vetter
2019-06-18 2:49 ` Rodrigo Siqueira
2019-06-18 8:56 ` Daniel Vetter
2019-06-18 21:54 ` Rodrigo Siqueira
2019-06-18 22:06 ` Daniel Vetter
2019-06-18 22:07 ` Daniel Vetter
2019-06-18 22:25 ` Rodrigo Siqueira
2019-06-18 22:39 ` Daniel Vetter
2019-06-26 1:44 ` Rodrigo Siqueira
2019-06-26 7:54 ` Daniel Vetter
2019-06-26 13:46 ` Rodrigo Siqueira
2019-07-01 3:30 ` Rodrigo Siqueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606222751.32567-8-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).