From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v3 hmm 04/12] mm/hmm: Simplify hmm_get_or_create and make
 it reliable
Date: Tue, 18 Jun 2019 15:55:55 -0300
Message-ID: <20190618185555.GO6961@ziepe.ca>
References: <20190614004450.20252-1-jgg@ziepe.ca>
 <20190614004450.20252-5-jgg@ziepe.ca>
 <20190615141211.GD17724@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com
 [IPv6:2607:f8b0:4864:20::741])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 542ED8919E
 for <dri-devel@lists.freedesktop.org>; Tue, 18 Jun 2019 18:55:57 +0000 (UTC)
Received: by mail-qk1-x741.google.com with SMTP id c70so9267632qkg.7
 for <dri-devel@lists.freedesktop.org>; Tue, 18 Jun 2019 11:55:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20190615141211.GD17724@infradead.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>, Philip Yang <Philip.Yang@amd.com>, Ralph Campbell <rcampbell@nvidia.com>, linux-rdma@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>, Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse <jglisse@redhat.com>, amd-gfx@lists.freedesktop.org, Ira Weiny <ira.weiny@intel.com>, Ben Skeggs <bskeggs@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

T24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDc6MTI6MTFBTSAtMDcwMCwgQ2hyaXN0b3BoIEhlbGx3
aWcgd3JvdGU6Cj4gPiArCXNwaW5fbG9jaygmbW0tPnBhZ2VfdGFibGVfbG9jayk7Cj4gPiArCWlm
IChtbS0+aG1tKSB7Cj4gPiArCQlpZiAoa3JlZl9nZXRfdW5sZXNzX3plcm8oJm1tLT5obW0tPmty
ZWYpKSB7Cj4gPiArCQkJc3Bpbl91bmxvY2soJm1tLT5wYWdlX3RhYmxlX2xvY2spOwo+ID4gKwkJ
CXJldHVybiBtbS0+aG1tOwo+ID4gKwkJfQo+ID4gKwl9Cj4gPiArCXNwaW5fdW5sb2NrKCZtbS0+
cGFnZV90YWJsZV9sb2NrKTsKPiAKPiBUaGlzIGNvdWxkIGJlY29tZToKPiAKPiAJc3Bpbl9sb2Nr
KCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKPiAJaG1tID0gbW0tPmhtbQo+IAlpZiAoaG1tICYmIGty
ZWZfZ2V0X3VubGVzc196ZXJvKCZobW0tPmtyZWYpKQo+IAkJZ290byBvdXRfdW5sb2NrOwo+IAlz
cGluX3VubG9jaygmbW0tPnBhZ2VfdGFibGVfbG9jayk7Cj4gCj4gYXMgdGhlIGxhc3QgdHdvIGxp
bmVzIG9mIHRoZSBmdW5jdGlvbiBhbHJlYWR5IGRyb3AgdGhlIHBhZ2VfdGFibGVfbG9jawo+IGFu
ZCB0aGVuIHJldHVybiBobW0uICBPciBkcm9wIHRoZSAiaG1tID0gbW0tPmhtbSIgYXNpZ25tZW50
IGFib3ZlIGFuZAo+IHJldHVybiBtbS0+aG1tIGFzIHRoYXQgc2hvdWxkIGJlIGFsd2F5cyBpZGVu
dGljYWwgdG8gaG1tIGF0IHRoZSBlbmQKPiB0byBzYXZlIGFub3RoZXIgbGluZS4KPiAKPiA+ICsJ
LyoKPiA+ICsJICogVGhlIG1tLT5obW0gcG9pbnRlciBpcyBrZXB0IHZhbGlkIHdoaWxlIG5vdGlm
aWVyIG9wcyBjYW4gYmUgcnVubmluZwo+ID4gKwkgKiBzbyB0aGV5IGRvbid0IGhhdmUgdG8gZGVh
bCB3aXRoIGEgTlVMTCBtbS0+aG1tIHZhbHVlCj4gPiArCSAqLwo+IAo+IFRoZSBjb21tZW50IGNv
bmZ1c2VzIG1lLiAgSG93IGRvZXMgdGhlIHBhZ2VfdGFibGVfbG9jayByZWxhdGUgdG8KPiBwb3Nz
aWJseSBydW5uaW5nIG5vdGlmaWVycywgYXMgSSBjYW4ndCBmaW5kIHRoYXQgd2UgdGFrZQo+IHBh
Z2VfdGFibGVfbG9jaz8gIE9yIGlzIGl0IGp1c3QgYWJvdXQgdGhlIGZhY3QgdGhhdCB3ZSBvbmx5
IGNsZWFyCj4gbW0tPmhtbSBpbiB0aGUgZnJlZSBjYWxsYmFjaywgYW5kIG5vdCBpbiBobW1fZnJl
ZT8KClJldmlzZWQgd2l0aDoKCkZyb20gYmRjMDJhMWQ1MDJkYjA4NDU3ODIzZTZiMmI5ODM4NjFh
MzU3NGE3NiBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKRnJvbTogSmFzb24gR3VudGhvcnBlIDxq
Z2dAbWVsbGFub3guY29tPgpEYXRlOiBUaHUsIDIzIE1heSAyMDE5IDEwOjI0OjEzIC0wMzAwClN1
YmplY3Q6IFtQQVRDSF0gbW0vaG1tOiBTaW1wbGlmeSBobW1fZ2V0X29yX2NyZWF0ZSBhbmQgbWFr
ZSBpdCByZWxpYWJsZQoKQXMgY29kZWQgdGhpcyBmdW5jdGlvbiBjYW4gZmFsc2UtZmFpbCBpbiB2
YXJpb3VzIHJhY3kgc2l0dWF0aW9ucy4gTWFrZSBpdApyZWxpYWJsZSBhbmQgc2ltcGxlciBieSBy
dW5uaW5nIHVuZGVyIHRoZSB3cml0ZSBzaWRlIG9mIHRoZSBtbWFwX3NlbSBhbmQKYXZvaWRpbmcg
dGhlIGZhbHNlLWZhaWxpbmcgY29tcGFyZS9leGNoYW5nZSBwYXR0ZXJuLiBEdWUgdG8gdGhlIG1t
YXBfc2VtCnRoaXMgbm8gbG9uZ2VyIGhhcyB0byBhdm9pZCByYWNpbmcgd2l0aCBhIDJuZCBwYXJh
bGxlbApobW1fZ2V0X29yX2NyZWF0ZSgpLgoKVW5mb3J0dW5hdGVseSB0aGlzIHN0aWxsIGhhcyB0
byB1c2UgdGhlIHBhZ2VfdGFibGVfbG9jayBhcyB0aGUKbm9uLXNsZWVwaW5nIGxvY2sgcHJvdGVj
dGluZyBtbS0+aG1tLCBzaW5jZSB0aGUgY29udGV4dHMgd2hlcmUgd2UgZnJlZSB0aGUKaG1tIGFy
ZSBpbmNvbXBhdGlibGUgd2l0aCBtbWFwX3NlbS4KClNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRo
b3JwZSA8amdnQG1lbGxhbm94LmNvbT4KUmV2aWV3ZWQtYnk6IEpvaG4gSHViYmFyZCA8amh1YmJh
cmRAbnZpZGlhLmNvbT4KUmV2aWV3ZWQtYnk6IFJhbHBoIENhbXBiZWxsIDxyY2FtcGJlbGxAbnZp
ZGlhLmNvbT4KUmV2aWV3ZWQtYnk6IElyYSBXZWlueSA8aXJhLndlaW55QGludGVsLmNvbT4KVGVz
dGVkLWJ5OiBQaGlsaXAgWWFuZyA8UGhpbGlwLllhbmdAYW1kLmNvbT4KLS0tCnYyOgotIEZpeCBl
cnJvciB1bndpbmQgb2YgbW1ncmFiIChKZXJvbWUpCi0gVXNlIGhtbSBsb2NhbCBpbnN0ZWFkIG9m
IDJuZCBjb250YWluZXJfb2YgKEplcm9tZSkKdjM6Ci0gQ2FuJ3QgdXNlIG1tYXBfc2VtIGluIHRo
ZSBTUkNVIGNhbGxiYWNrLCBrZWVwIHVzaW5nIHRoZQogIHBhZ2VfdGFibGVfbG9jayAoUGhpbGlw
KQp2NDoKLSBQdXQgdGhlIG1tLT5obW0gPSBOVUxMIGluIHRoZSBrcmVmIHJlbGVhc2UsIHJlZHVj
ZSBMT0MKICBpbiBobW1fZ2V0X29yX2NyZWF0ZSgpIChDaHJpc3RvcGgpCi0tLQogbW0vaG1tLmMg
fCA3NyArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLQogMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDQ3IGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL21tL2htbS5jIGIvbW0vaG1tLmMKaW5kZXggMDgwYjE3YTJlODdlMmQuLjA0
MjNmNGNhM2E3ZTA5IDEwMDY0NAotLS0gYS9tbS9obW0uYworKysgYi9tbS9obW0uYwpAQCAtMzEs
MTYgKzMxLDYgQEAKICNpZiBJU19FTkFCTEVEKENPTkZJR19ITU1fTUlSUk9SKQogc3RhdGljIGNv
bnN0IHN0cnVjdCBtbXVfbm90aWZpZXJfb3BzIGhtbV9tbXVfbm90aWZpZXJfb3BzOwogCi1zdGF0
aWMgaW5saW5lIHN0cnVjdCBobW0gKm1tX2dldF9obW0oc3RydWN0IG1tX3N0cnVjdCAqbW0pCi17
Ci0Jc3RydWN0IGhtbSAqaG1tID0gUkVBRF9PTkNFKG1tLT5obW0pOwotCi0JaWYgKGhtbSAmJiBr
cmVmX2dldF91bmxlc3NfemVybygmaG1tLT5rcmVmKSkKLQkJcmV0dXJuIGhtbTsKLQotCXJldHVy
biBOVUxMOwotfQotCiAvKioKICAqIGhtbV9nZXRfb3JfY3JlYXRlIC0gcmVnaXN0ZXIgSE1NIGFn
YWluc3QgYW4gbW0gKEhNTSBpbnRlcm5hbCkKICAqCkBAIC01NSwxMSArNDUsMTYgQEAgc3RhdGlj
IGlubGluZSBzdHJ1Y3QgaG1tICptbV9nZXRfaG1tKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tKQogICov
CiBzdGF0aWMgc3RydWN0IGhtbSAqaG1tX2dldF9vcl9jcmVhdGUoc3RydWN0IG1tX3N0cnVjdCAq
bW0pCiB7Ci0Jc3RydWN0IGhtbSAqaG1tID0gbW1fZ2V0X2htbShtbSk7Ci0JYm9vbCBjbGVhbnVw
ID0gZmFsc2U7CisJc3RydWN0IGhtbSAqaG1tOworCisJbG9ja2RlcF9hc3NlcnRfaGVsZF9leGNs
dXNpdmUoJm1tLT5tbWFwX3NlbSk7CiAKLQlpZiAoaG1tKQotCQlyZXR1cm4gaG1tOworCS8qIEFi
dXNlIHRoZSBwYWdlX3RhYmxlX2xvY2sgdG8gYWxzbyBwcm90ZWN0IG1tLT5obW0uICovCisJc3Bp
bl9sb2NrKCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKKwlobW0gPSBtbS0+aG1tOworCWlmIChtbS0+
aG1tICYmIGtyZWZfZ2V0X3VubGVzc196ZXJvKCZtbS0+aG1tLT5rcmVmKSkKKwkJZ290byBvdXRf
dW5sb2NrOworCXNwaW5fdW5sb2NrKCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKIAogCWhtbSA9IGtt
YWxsb2Moc2l6ZW9mKCpobW0pLCBHRlBfS0VSTkVMKTsKIAlpZiAoIWhtbSkKQEAgLTc0LDU3ICs2
OSw0NSBAQCBzdGF0aWMgc3RydWN0IGhtbSAqaG1tX2dldF9vcl9jcmVhdGUoc3RydWN0IG1tX3N0
cnVjdCAqbW0pCiAJaG1tLT5ub3RpZmllcnMgPSAwOwogCWhtbS0+ZGVhZCA9IGZhbHNlOwogCWht
bS0+bW0gPSBtbTsKLQltbWdyYWIoaG1tLT5tbSk7CiAKLQlzcGluX2xvY2soJm1tLT5wYWdlX3Rh
YmxlX2xvY2spOwotCWlmICghbW0tPmhtbSkKLQkJbW0tPmhtbSA9IGhtbTsKLQllbHNlCi0JCWNs
ZWFudXAgPSB0cnVlOwotCXNwaW5fdW5sb2NrKCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKKwlobW0t
Pm1tdV9ub3RpZmllci5vcHMgPSAmaG1tX21tdV9ub3RpZmllcl9vcHM7CisJaWYgKF9fbW11X25v
dGlmaWVyX3JlZ2lzdGVyKCZobW0tPm1tdV9ub3RpZmllciwgbW0pKSB7CisJCWtmcmVlKGhtbSk7
CisJCXJldHVybiBOVUxMOworCX0KIAotCWlmIChjbGVhbnVwKQotCQlnb3RvIGVycm9yOworCW1t
Z3JhYihobW0tPm1tKTsKIAogCS8qCi0JICogV2Ugc2hvdWxkIG9ubHkgZ2V0IGhlcmUgaWYgaG9s
ZCB0aGUgbW1hcF9zZW0gaW4gd3JpdGUgbW9kZSBpZSBvbgotCSAqIHJlZ2lzdHJhdGlvbiBvZiBm
aXJzdCBtaXJyb3IgdGhyb3VnaCBobW1fbWlycm9yX3JlZ2lzdGVyKCkKKwkgKiBXZSBob2xkIHRo
ZSBleGNsdXNpdmUgbW1hcF9zZW0gaGVyZSBzbyB3ZSBrbm93IHRoYXQgbW0tPmhtbSBpcworCSAq
IHN0aWxsIE5VTEwgb3IgMCBrcmVmLCBhbmQgaXMgc2FmZSB0byB1cGRhdGUuCiAJICovCi0JaG1t
LT5tbXVfbm90aWZpZXIub3BzID0gJmhtbV9tbXVfbm90aWZpZXJfb3BzOwotCWlmIChfX21tdV9u
b3RpZmllcl9yZWdpc3RlcigmaG1tLT5tbXVfbm90aWZpZXIsIG1tKSkKLQkJZ290byBlcnJvcl9t
bTsKLQotCXJldHVybiBobW07Ci0KLWVycm9yX21tOgogCXNwaW5fbG9jaygmbW0tPnBhZ2VfdGFi
bGVfbG9jayk7Ci0JaWYgKG1tLT5obW0gPT0gaG1tKQotCQltbS0+aG1tID0gTlVMTDsKKwltbS0+
aG1tID0gaG1tOworCitvdXRfdW5sb2NrOgogCXNwaW5fdW5sb2NrKCZtbS0+cGFnZV90YWJsZV9s
b2NrKTsKLWVycm9yOgotCW1tZHJvcChobW0tPm1tKTsKLQlrZnJlZShobW0pOwotCXJldHVybiBO
VUxMOworCXJldHVybiBobW07CiB9CiAKIHN0YXRpYyB2b2lkIGhtbV9mcmVlX3JjdShzdHJ1Y3Qg
cmN1X2hlYWQgKnJjdSkKIHsKLQlrZnJlZShjb250YWluZXJfb2YocmN1LCBzdHJ1Y3QgaG1tLCBy
Y3UpKTsKKwlzdHJ1Y3QgaG1tICpobW0gPSBjb250YWluZXJfb2YocmN1LCBzdHJ1Y3QgaG1tLCBy
Y3UpOworCisJbW1kcm9wKGhtbS0+bW0pOworCWtmcmVlKGhtbSk7CiB9CiAKIHN0YXRpYyB2b2lk
IGhtbV9mcmVlKHN0cnVjdCBrcmVmICprcmVmKQogewogCXN0cnVjdCBobW0gKmhtbSA9IGNvbnRh
aW5lcl9vZihrcmVmLCBzdHJ1Y3QgaG1tLCBrcmVmKTsKLQlzdHJ1Y3QgbW1fc3RydWN0ICptbSA9
IGhtbS0+bW07CiAKLQltbXVfbm90aWZpZXJfdW5yZWdpc3Rlcl9ub19yZWxlYXNlKCZobW0tPm1t
dV9ub3RpZmllciwgbW0pOworCXNwaW5fbG9jaygmaG1tLT5tbS0+cGFnZV90YWJsZV9sb2NrKTsK
KwlpZiAoaG1tLT5tbS0+aG1tID09IGhtbSkKKwkJaG1tLT5tbS0+aG1tID0gTlVMTDsKKwlzcGlu
X3VubG9jaygmaG1tLT5tbS0+cGFnZV90YWJsZV9sb2NrKTsKIAotCXNwaW5fbG9jaygmbW0tPnBh
Z2VfdGFibGVfbG9jayk7Ci0JaWYgKG1tLT5obW0gPT0gaG1tKQotCQltbS0+aG1tID0gTlVMTDsK
LQlzcGluX3VubG9jaygmbW0tPnBhZ2VfdGFibGVfbG9jayk7Ci0KLQltbWRyb3AoaG1tLT5tbSk7
CisJbW11X25vdGlmaWVyX3VucmVnaXN0ZXJfbm9fcmVsZWFzZSgmaG1tLT5tbXVfbm90aWZpZXIs
IGhtbS0+bW0pOwogCW1tdV9ub3RpZmllcl9jYWxsX3NyY3UoJmhtbS0+cmN1LCBobW1fZnJlZV9y
Y3UpOwogfQogCi0tIAoyLjIxLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2RyaS1kZXZlbA==