From: Sam Ravnborg <sam@ravnborg.org>
To: Robert Chiras <robert.chiras@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-imx@nxp.com
Subject: Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver
Date: Wed, 19 Jun 2019 15:25:46 +0200 [thread overview]
Message-ID: <20190619132546.GB31903@ravnborg.org> (raw)
In-Reply-To: <1560864646-1468-3-git-send-email-robert.chiras@nxp.com>
On Tue, Jun 18, 2019 at 04:30:46PM +0300, Robert Chiras wrote:
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).
>
> Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
Please include in the changelog a list of what was updated - like this:
v2:
- added kconif symbol sorted (sam)
- another nitpick (foo)
- etc
In general try to namme who gave feedback to give them some credit.
Who is maintainer for this onwards?
> ---
> drivers/gpu/drm/panel/Kconfig | 9 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-raydium-rm67191.c | 709 ++++++++++++++++++++++++++
> 3 files changed, 719 insertions(+)
> create mode 100644 drivers/gpu/drm/panel/panel-raydium-rm67191.c
>
> +static int rad_panel_prepare(struct drm_panel *panel)
> +{
> + struct rad_panel *rad = to_rad_panel(panel);
> +
> + if (rad->prepared)
> + return 0;
> +
> + if (rad->reset) {
> + gpiod_set_value_cansleep(rad->reset, 1);
> + usleep_range(3000, 5000);
> + gpiod_set_value_cansleep(rad->reset, 0);
So writing a 0 will release reset.
> + usleep_range(18000, 20000);
> + }
> +
> + rad->prepared = true;
> +
> + return 0;
> +}
> +
> +static int rad_panel_unprepare(struct drm_panel *panel)
> +{
> + struct rad_panel *rad = to_rad_panel(panel);
> +
> + if (!rad->prepared)
> + return 0;
> +
> + if (rad->reset) {
> + gpiod_set_value_cansleep(rad->reset, 1);
> + usleep_range(15000, 17000);
> + gpiod_set_value_cansleep(rad->reset, 0);
Looks strange that reset is released in unprepare.
I would expect it to stay reset to minimize power etc.
> +
> + ret = drm_display_info_set_bus_formats(&connector->display_info,
> + rad_bus_formats,
> + ARRAY_SIZE(rad_bus_formats));
Other drivers has this as the last stement in their enable function.
I did not check why, but maybe something to invest a few minutes into.
Be different only if there is a reason to do so.
> + if (ret)
> + return ret;
> +
> + drm_mode_probed_add(panel->connector, mode);
> +
> + return 1;
> +}
> +
> +
> +#ifdef CONFIG_PM
> +static int rad_panel_suspend(struct device *dev)
> +{
> + struct rad_panel *rad = dev_get_drvdata(dev);
> +
> + if (!rad->reset)
> + return 0;
> +
> + devm_gpiod_put(dev, rad->reset);
> + rad->reset = NULL;
> +
> + return 0;
> +}
> +
> +static int rad_panel_resume(struct device *dev)
> +{
> + struct rad_panel *rad = dev_get_drvdata(dev);
> +
> + if (rad->reset)
> + return 0;
> +
> + rad->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(rad->reset))
> + rad->reset = NULL;
> +
> + return PTR_ERR_OR_ZERO(rad->reset);
> +}
> +
> +#endif
Use __maybe_unused for the tw functions above.
And loose the ifdef...
> +
> +static const struct dev_pm_ops rad_pm_ops = {
> + SET_RUNTIME_PM_OPS(rad_panel_suspend, rad_panel_resume, NULL)
> + SET_SYSTEM_SLEEP_PM_OPS(rad_panel_suspend, rad_panel_resume)
> +};
> +
> +static const struct of_device_id rad_of_match[] = {
> + { .compatible = "raydium,rm67191", },
> + { }
We often, but not always, write this as { /* sentinal */ },
> +};
> +MODULE_DEVICE_TABLE(of, rad_of_match);
> +
> +static struct mipi_dsi_driver rad_panel_driver = {
> + .driver = {
> + .name = "panel-raydium-rm67191",
> + .of_match_table = rad_of_match,
> + .pm = &rad_pm_ops,
> + },
> + .probe = rad_panel_probe,
> + .remove = rad_panel_remove,
> + .shutdown = rad_panel_shutdown,
> +};
> +module_mipi_dsi_driver(rad_panel_driver);
> +
> +MODULE_AUTHOR("Robert Chiras <robert.chiras@nxp.com>");
> +MODULE_DESCRIPTION("DRM Driver for Raydium RM67191 MIPI DSI panel");
> +MODULE_LICENSE("GPL v2");
With the above trivialities considered/fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-19 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 13:30 [PATCH v2 0/2] Add DSI panel driver for Raydium RM67191 Robert Chiras
2019-06-18 13:30 ` [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel Robert Chiras
2019-06-19 13:12 ` Sam Ravnborg
2019-06-19 13:21 ` Fabio Estevam
2019-06-20 7:58 ` [EXT] " Robert Chiras
2019-06-18 13:30 ` [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver Robert Chiras
2019-06-19 13:25 ` Sam Ravnborg [this message]
2019-06-20 8:30 ` [EXT] " Robert Chiras
2019-06-19 13:28 ` Fabio Estevam
2019-06-20 8:34 ` [EXT] " Robert Chiras
2019-06-19 14:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619132546.GB31903@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).