From: Lee Jones <lee.jones@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Brian Norris <briannorris@chromium.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves
Date: Thu, 27 Jun 2019 10:24:53 +0100 [thread overview]
Message-ID: <20190627092453.GB2000@dell> (raw)
In-Reply-To: <61ed137c-31bb-c695-4174-0484fe667d6c@linaro.org>
On Fri, 21 Jun 2019, Daniel Thompson wrote:
> On 13/06/2019 20:43, Matthias Kaehlcke wrote:
> > For backlight curves calculated with the CIE 1931 algorithm set
> > the brightness scale type property accordingly. This makes the
> > scale type available to userspace via the 'scale' sysfs attribute.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> I'd like to keep discussion on patch 2 open a bit longer (it's not part of
> the thread below patch 2 but Pavel had concerns about the sysfs interface)
> so this ack won't really push things forward but FWIW:
>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Does this depend on patch 2, or is it orthogonal?
> > ---
> > drivers/video/backlight/pwm_bl.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index fb45f866b923..f067fe7aa35d 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -553,6 +553,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> > goto err_alloc;
> > }
> > + memset(&props, 0, sizeof(struct backlight_properties));
> > +
> > if (data->levels) {
> > /*
> > * For the DT case, only when brightness levels is defined
> > @@ -591,6 +593,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> > pb->levels = data->levels;
> > }
> > +
> > + props.scale = BACKLIGHT_SCALE_CIE1931;
> > } else {
> > /*
> > * That only happens for the non-DT case, where platform data
> > @@ -601,7 +605,6 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> > pb->lth_brightness = data->lth_brightness * (state.period / pb->scale);
> > - memset(&props, 0, sizeof(struct backlight_properties));
> > props.type = BACKLIGHT_RAW;
> > props.max_brightness = data->max_brightness;
> > bl = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, pb,
> >
>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-27 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 19:43 [PATCH 0/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke
2019-06-13 19:43 ` [PATCH 1/4] MAINTAINERS: Add entry for stable backlight sysfs ABI documentation Matthias Kaehlcke
2019-06-19 11:05 ` Daniel Thompson
2019-06-13 19:43 ` [PATCH 2/4] backlight: Expose brightness curve type through sysfs Matthias Kaehlcke
2019-06-13 21:56 ` Matthias Kaehlcke
2019-06-13 19:43 ` [PATCH 3/4] backlight: pwm_bl: Set scale type for CIE 1931 curves Matthias Kaehlcke
2019-06-19 9:17 ` Enric Balletbo i Serra
2019-06-21 12:55 ` Daniel Thompson
2019-06-27 9:24 ` Lee Jones [this message]
2019-06-27 15:49 ` Daniel Thompson
2019-06-13 19:43 ` [PATCH 4/4] backlight: pwm_bl: Set scale type for brightness curves specified in the DT Matthias Kaehlcke
2019-06-21 13:10 ` Daniel Thompson
2019-06-24 18:54 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627092453.GB2000@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=briannorris@chromium.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pavel@ucw.cz \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).