From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5 05/12] drm/modes: Rewrite the command line parser Date: Tue, 9 Jul 2019 14:45:26 +0200 Message-ID: <20190709124526.36szuriteq3jumhr@flea> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1893474156==" Return-path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by gabe.freedesktop.org (Postfix) with ESMTPS id A11F58969E for ; Tue, 9 Jul 2019 12:45:32 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dmitry Osipenko Cc: eben@raspberrypi.org, David Airlie , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Thierry Reding , Sean Paul , Thomas Petazzoni , "linux-tegra@vger.kernel.org" , Daniel Vetter , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============1893474156== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vcujhgabco7cibei" Content-Disposition: inline --vcujhgabco7cibei Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jul 05, 2019 at 07:54:47PM +0300, Dmitry Osipenko wrote: > 17.06.2019 17:51, Maxime Ripard =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > From: Maxime Ripard > > > > Rewrite the command line parser in order to get away from the state mac= hine > > parsing the video mode lines. > > > > Hopefully, this will allow to extend it more easily to support named mo= des > > and / or properties set directly on the command line. > > > > Reviewed-by: Noralf Tr=C3=B8nnes > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/drm_modes.c | 325 +++++++++++++++++++++++-------------- > > 1 file changed, 210 insertions(+), 115 deletions(-) > > I have a Tegra device that uses a stock android bootloader which > passes "video=3Dtegrafb" in the kernels cmdline. That wasn't a problem > before this patch, but now Tegra DRM driver fails to probe because > the mode is 0x0:0 and hence framebuffer allocation fails. Is it a > legit regression that should be fixed in upstream? Thierry indeed reported that issue, but the discussion pretty much stalled since then. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --vcujhgabco7cibei Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXSSMYQAKCRDj7w1vZxhR xakIAP4+CIpP0/uIjF6b/BDiYxakJHM0UScucoPgY1Mh8fCrpwD/SLOeZeYOzZ3R g10KDEYVYh0DflC+UIvy2n8COGx6YAw= =FVma -----END PGP SIGNATURE----- --vcujhgabco7cibei-- --===============1893474156== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1893474156==--