From: Greg KH <gregkh@linuxfoundation.org>
To: "Jan Sebastian Götte" <linux@jaseg.net>
Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com,
linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
dri-devel@lists.freedesktop.org, bhanusreemahesh@gmail.com,
Phil Reid <preid@electromag.com.au>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2] Staging: fbtft: Fix GPIO handling
Date: Thu, 25 Jul 2019 09:21:32 +0200 [thread overview]
Message-ID: <20190725072132.GA18714@kroah.com> (raw)
In-Reply-To: <75ada52f-afa1-08bc-d0ce-966fc1110e70@jaseg.net>
On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote:
> Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface") breaks GPIO handling. In several places, checks to only set
> a GPIO if it was configured ended up backwards.
> I have tested this fix. The fixed driver works with a ili9486
> display connected to a raspberry pi via SPI.
>
> Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor interface")
> Tested-by: Jan Sebastian Götte <linux@jaseg.net>
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Signed-off-by: Jan Sebastian Götte <linux@jaseg.net>
> ---
Can this go on top of Phil's patches? Or does it replace it?
I can't figure out what to do here, sorry.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-25 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:30 [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8() Nicolas Saenz Julienne
[not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
2019-07-15 14:58 ` [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8() Jan Sebastian Götte
2019-07-15 15:04 ` [PATCH] Staging: fbtft: Fix GPIO handling Jan Sebastian Götte
2019-07-15 15:14 ` Nicolas Saenz Julienne
2019-07-17 14:41 ` [PATCH v2] " Jan Sebastian Götte
2019-07-25 7:21 ` Greg KH [this message]
2019-07-25 7:23 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725072132.GA18714@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhanusreemahesh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=leobras.c@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux@jaseg.net \
--cc=nishadkamdar@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).