From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: linux-next: build warning after merge of the drm-misc tree Date: Fri, 16 Aug 2019 15:24:11 +0300 Message-ID: <20190816122411.GE5020@pendragon.ideasonboard.com> References: <20190816133132.6b37d7fa@canb.auug.org.au> <20190816044846.GA27781@ravnborg.org> <20190816094715.GB5020@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190816094715.GB5020@pendragon.ideasonboard.com> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter Cc: Sam Ravnborg , Stephen Rothwell , Intel Graphics , DRI , Linux Next Mailing List , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org On Fri, Aug 16, 2019 at 12:47:15PM +0300, Laurent Pinchart wrote: > On Fri, Aug 16, 2019 at 08:23:54AM +0200, Daniel Vetter wrote: > > On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg wrote: > > > > Hi all, > > > > > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > > > allmodconfig) produced this warning: > > > > > > > > warning: same module names found: > > > > drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.ko > > > > drivers/gpu/drm/panel/panel-nec-nl8048hl11.ko > > > > warning: same module names found: > > > > drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.ko > > > > drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.ko > > > > warning: same module names found: > > > > drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.ko > > > > drivers/gpu/drm/panel/panel-sony-acx565akm.ko > > > > warning: same module names found: > > > > drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.ko > > > > drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko > > > > warning: same module names found: > > > > drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.ko > > > > drivers/gpu/drm/panel/panel-tpo-td043mtea1.ko > > > > > > > > Introduced by commits > > > > > > > > df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel") > > > > c9cf4c2a3bd3 ("drm/panel: Add driver for the Sharp LS037V7DW01 panel") > > > > 1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel") > > > > 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel") > > > > dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel") > > > > > > Ups, had not seen this one coming. > > > We are in the process of removing the drivers in drivers/video/fbdev/omap2/omapfb/ > > > and decided to introduce the new drivers early to get them out of a > > > longer patch series. > > Oops :-( > > The new drivers were initially part of a patch series that removed the > duplicated drivers. The new drivers then got fast-tracked, and I didn't > notice this issue. > > > Should we have a config dependency to not allow the old fbdev omap > > when the drm omap driver is enabled? I think that would take care of > > all this. > > > > Or too annoying for development? > > > > Also note that fbdev is in drm-misc now, so we should be able to fix > > this all without cross-tree conflicts. > > Note that drivers/video/fbdev/omap2/omapfb/ will stay, it's > drivers/gpu/drm/omapdrm/displays/ that is being removed. FB_OMAP2 > already depends on DRM_OMAP = n, I propose doing something similar at > the level of the individual display drivers. I've just posted "[PATCH 0/2] Fix module name clash with omapdrm and DRM panel modules" that should solve this issue. -- Regards, Laurent Pinchart