From: Daniel Vetter <daniel@ffwll.ch>
To: zhengbin <zhengbin13@huawei.com>
Cc: airlied@linux.ie, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: remove set but not used variable 'channel_eq'
Date: Mon, 18 Nov 2019 10:53:11 +0100 [thread overview]
Message-ID: <20191118095311.GD23790@phenom.ffwll.local> (raw)
In-Reply-To: <1573902268-117518-1-git-send-email-zhengbin13@huawei.com>
On Sat, Nov 16, 2019 at 07:04:28PM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/gma500/cdv_intel_dp.c: In function cdv_intel_dp_complete_link_train:
> drivers/gpu/drm/gma500/cdv_intel_dp.c:1596:7: warning: variable channel_eq set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Queued for 5.6 thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> index 570b595..5772b2d 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> @@ -1594,7 +1594,6 @@ cdv_intel_dp_complete_link_train(struct gma_encoder *encoder)
> {
> struct drm_device *dev = encoder->base.dev;
> struct cdv_intel_dp *intel_dp = encoder->dev_priv;
> - bool channel_eq = false;
> int tries, cr_tries;
> u32 reg;
> uint32_t DP = intel_dp->DP;
> @@ -1602,7 +1601,6 @@ cdv_intel_dp_complete_link_train(struct gma_encoder *encoder)
> /* channel equalization */
> tries = 0;
> cr_tries = 0;
> - channel_eq = false;
>
> DRM_DEBUG_KMS("\n");
> reg = DP | DP_LINK_TRAIN_PAT_2;
> @@ -1648,7 +1646,6 @@ cdv_intel_dp_complete_link_train(struct gma_encoder *encoder)
>
> if (cdv_intel_channel_eq_ok(encoder)) {
> DRM_DEBUG_KMS("PT2 train is done\n");
> - channel_eq = true;
> break;
> }
>
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-11-18 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 11:04 [PATCH] drm/gma500: remove set but not used variable 'channel_eq' zhengbin
2019-11-16 11:04 ` zhengbin
2019-11-18 9:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118095311.GD23790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).