From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v5 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() Date: Mon, 18 Nov 2019 11:34:09 +0100 Message-ID: <20191118103409.GI17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-16-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191115055340.1825745-16-jhubbard@nvidia.com> Sender: netdev-owner@vger.kernel.org To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Micha List-Id: dri-devel@lists.freedesktop.org On Thu 14-11-19 21:53:31, John Hubbard wrote: > Convert fs/io_uring to use the new pin_user_pages() call, which sets > FOLL_PIN. Setting FOLL_PIN is now required for code that requires > tracking of pinned pages, and therefore for any code that calls > put_user_page(). > > In partial anticipation of this work, the io_uring code was already > calling put_user_page() instead of put_page(). Therefore, in order to > convert from the get_user_pages()/put_page() model, to the > pin_user_pages()/put_user_page() model, the only change required > here is to change get_user_pages() to pin_user_pages(). > > Signed-off-by: John Hubbard Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > fs/io_uring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/io_uring.c b/fs/io_uring.c > index f9a38998f2fc..cff64bd00db9 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -3433,7 +3433,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, void __user *arg, > > ret = 0; > down_read(¤t->mm->mmap_sem); > - pret = get_user_pages(ubuf, nr_pages, > + pret = pin_user_pages(ubuf, nr_pages, > FOLL_WRITE | FOLL_LONGTERM, > pages, vmas); > if (pret == nr_pages) { > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B86C432C3 for ; Mon, 18 Nov 2019 12:01:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 839C020895 for ; Mon, 18 Nov 2019 12:01:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 839C020895 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 44FB86E4AB; Mon, 18 Nov 2019 12:01:29 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A2316E4AB for ; Mon, 18 Nov 2019 12:01:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E73AFB071; Mon, 18 Nov 2019 12:01:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 8AEB01E4B0D; Mon, 18 Nov 2019 11:34:09 +0100 (CET) Date: Mon, 18 Nov 2019 11:34:09 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v5 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() Message-ID: <20191118103409.GI17319@quack2.suse.cz> References: <20191115055340.1825745-1-jhubbard@nvidia.com> <20191115055340.1825745-16-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115055340.1825745-16-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191118103409.gAExhcJ5PSM3q6YlkfInAddZUC-BetAM92Yt0SzCu8s@z> T24gVGh1IDE0LTExLTE5IDIxOjUzOjMxLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gQ29udmVydCBm cy9pb191cmluZyB0byB1c2UgdGhlIG5ldyBwaW5fdXNlcl9wYWdlcygpIGNhbGwsIHdoaWNoIHNl dHMKPiBGT0xMX1BJTi4gU2V0dGluZyBGT0xMX1BJTiBpcyBub3cgcmVxdWlyZWQgZm9yIGNvZGUg dGhhdCByZXF1aXJlcwo+IHRyYWNraW5nIG9mIHBpbm5lZCBwYWdlcywgYW5kIHRoZXJlZm9yZSBm b3IgYW55IGNvZGUgdGhhdCBjYWxscwo+IHB1dF91c2VyX3BhZ2UoKS4KPiAKPiBJbiBwYXJ0aWFs IGFudGljaXBhdGlvbiBvZiB0aGlzIHdvcmssIHRoZSBpb191cmluZyBjb2RlIHdhcyBhbHJlYWR5 Cj4gY2FsbGluZyBwdXRfdXNlcl9wYWdlKCkgaW5zdGVhZCBvZiBwdXRfcGFnZSgpLiBUaGVyZWZv cmUsIGluIG9yZGVyIHRvCj4gY29udmVydCBmcm9tIHRoZSBnZXRfdXNlcl9wYWdlcygpL3B1dF9w YWdlKCkgbW9kZWwsIHRvIHRoZQo+IHBpbl91c2VyX3BhZ2VzKCkvcHV0X3VzZXJfcGFnZSgpIG1v ZGVsLCB0aGUgb25seSBjaGFuZ2UgcmVxdWlyZWQKPiBoZXJlIGlzIHRvIGNoYW5nZSBnZXRfdXNl cl9wYWdlcygpIHRvIHBpbl91c2VyX3BhZ2VzKCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9obiBI dWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgoKTG9va3MgZ29vZCB0byBtZS4gWW91IGNhbiBh ZGQ6CgpSZXZpZXdlZC1ieTogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KCgkJCQkJCQkJSG9uemEK Cj4gLS0tCj4gIGZzL2lvX3VyaW5nLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9mcy9pb191cmluZy5jIGIv ZnMvaW9fdXJpbmcuYwo+IGluZGV4IGY5YTM4OTk4ZjJmYy4uY2ZmNjRiZDAwZGI5IDEwMDY0NAo+ IC0tLSBhL2ZzL2lvX3VyaW5nLmMKPiArKysgYi9mcy9pb191cmluZy5jCj4gQEAgLTM0MzMsNyAr MzQzMyw3IEBAIHN0YXRpYyBpbnQgaW9fc3FlX2J1ZmZlcl9yZWdpc3RlcihzdHJ1Y3QgaW9fcmlu Z19jdHggKmN0eCwgdm9pZCBfX3VzZXIgKmFyZywKPiAgCj4gIAkJcmV0ID0gMDsKPiAgCQlkb3du X3JlYWQoJmN1cnJlbnQtPm1tLT5tbWFwX3NlbSk7Cj4gLQkJcHJldCA9IGdldF91c2VyX3BhZ2Vz KHVidWYsIG5yX3BhZ2VzLAo+ICsJCXByZXQgPSBwaW5fdXNlcl9wYWdlcyh1YnVmLCBucl9wYWdl cywKPiAgCQkJCSAgICAgIEZPTExfV1JJVEUgfCBGT0xMX0xPTkdURVJNLAo+ICAJCQkJICAgICAg cGFnZXMsIHZtYXMpOwo+ICAJCWlmIChwcmV0ID09IG5yX3BhZ2VzKSB7Cj4gLS0gCj4gMi4yNC4w Cj4gCi0tIApKYW4gS2FyYSA8amFja0BzdXNlLmNvbT4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=