From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Wed, 20 Nov 2019 13:51:27 +0200 Message-ID: <20191120115127.GD11621@lahna.fi.intel.com> References: <20191017121901.13699-1-kherbst@redhat.com> <20191119214955.GA223696@google.com> <20191120101816.GX11621@lahna.fi.intel.com> <20191120112212.GA11621@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191120112212.GA11621@lahna.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Karol Herbst , Bjorn Helgaas , LKML , Lyude Paul , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello List-Id: dri-devel@lists.freedesktop.org On Wed, Nov 20, 2019 at 01:22:16PM +0200, Mika Westerberg wrote: > If (((OSYS <= 0x07D9) || ((OSYS == 0x07DF) && (_REV == > 0x05)))) > { The OSYS comes from this (in DSDT): If (_OSI ("Windows 2009")) { OSYS = 0x07D9 } If (_OSI ("Windows 2012")) { OSYS = 0x07DC } If (_OSI ("Windows 2013")) { OSYS = 0x07DD } If (_OSI ("Windows 2015")) { OSYS = 0x07DF } So I guess this particular check tries to identify Windows 7 and older, and Linux. > If ((PIOF == Zero)) > { > P0LD = One > TCNT = Zero > While ((TCNT < LDLY)) > { > If ((P0LT == 0x08)) > { > Break > } > > Sleep (0x10) > TCNT += 0x10 > } > > P0RM = One > P0AP = 0x03 > } > ElseIf ((PIOF == One)) > { > P1LD = One > TCNT = Zero > While ((TCNT < LDLY)) > { > If ((P1LT == 0x08)) > { > Break > } > > Sleep (0x10) > TCNT += 0x10 > } > > P1RM = One > P1AP = 0x03 > } > ElseIf ((PIOF == 0x02)) > { > P2LD = One > TCNT = Zero > While ((TCNT < LDLY)) > { > If ((P2LT == 0x08)) > { > Break > } > > Sleep (0x10) > TCNT += 0x10 > } > > P2RM = One > P2AP = 0x03 > } > > If ((PBGE != Zero)) > { > If (SBDL (PIOF)) > { > MBDL = GMXB (PIOF) > PDUB (PIOF, MBDL) > } > } > } > Else > { > LKDS (PIOF) > } > > If ((DerefOf (SCLK [Zero]) != Zero)) > { > PCRO (0xDC, 0x100C, DerefOf (SCLK [One])) > Sleep (0x10) > } > > GPPR (PIOF, Zero) > If ((OSYS != 0x07D9)) > { > DIWK (PIOF) > } > > \_SB.SGOV (0x01010004, Zero) > Sleep (0x14) > Return (Zero) > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8A3C432C3 for ; Wed, 20 Nov 2019 11:51:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2CB62243F for ; Wed, 20 Nov 2019 11:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2CB62243F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25A866E34A; Wed, 20 Nov 2019 11:51:34 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B8346E340; Wed, 20 Nov 2019 11:51:32 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 03:51:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,221,1571727600"; d="scan'208";a="215772771" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 20 Nov 2019 03:51:27 -0800 Received: by lahna (sSMTP sendmail emulation); Wed, 20 Nov 2019 13:51:27 +0200 Date: Wed, 20 Nov 2019 13:51:27 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Message-ID: <20191120115127.GD11621@lahna.fi.intel.com> References: <20191017121901.13699-1-kherbst@redhat.com> <20191119214955.GA223696@google.com> <20191120101816.GX11621@lahna.fi.intel.com> <20191120112212.GA11621@lahna.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191120112212.GA11621@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , Linux PM , Linux PCI , Mario Limonciello , "Rafael J . Wysocki" , LKML , dri-devel , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120115127.Py5WfCdBguBBZz5bqEcVy2Fy3rb17vfhy5TT7uNnY4E@z> T24gV2VkLCBOb3YgMjAsIDIwMTkgYXQgMDE6MjI6MTZQTSArMDIwMCwgTWlrYSBXZXN0ZXJiZXJn IHdyb3RlOgo+ICAgICAgICAgICAgIElmICgoKE9TWVMgPD0gMHgwN0Q5KSB8fCAoKE9TWVMgPT0g MHgwN0RGKSAmJiAoX1JFViA9PSAKPiAgICAgICAgICAgICAgICAgMHgwNSkpKSkKPiAgICAgICAg ICAgICB7CgpUaGUgT1NZUyBjb21lcyBmcm9tIHRoaXMgKGluIERTRFQpOgoKICAgICAgICAgICAg ICAgIElmIChfT1NJICgiV2luZG93cyAyMDA5IikpCiAgICAgICAgICAgICAgICB7CiAgICAgICAg ICAgICAgICAgICAgT1NZUyA9IDB4MDdEOQogICAgICAgICAgICAgICAgfQoKICAgICAgICAgICAg ICAgIElmIChfT1NJICgiV2luZG93cyAyMDEyIikpCiAgICAgICAgICAgICAgICB7CiAgICAgICAg ICAgICAgICAgICAgT1NZUyA9IDB4MDdEQwogICAgICAgICAgICAgICAgfQoKICAgICAgICAgICAg ICAgIElmIChfT1NJICgiV2luZG93cyAyMDEzIikpCiAgICAgICAgICAgICAgICB7CiAgICAgICAg ICAgICAgICAgICAgT1NZUyA9IDB4MDdERAogICAgICAgICAgICAgICAgfQoKICAgICAgICAgICAg ICAgIElmIChfT1NJICgiV2luZG93cyAyMDE1IikpCiAgICAgICAgICAgICAgICB7CiAgICAgICAg ICAgICAgICAgICAgT1NZUyA9IDB4MDdERgogICAgICAgICAgICAgICAgfQoKU28gSSBndWVzcyB0 aGlzIHBhcnRpY3VsYXIgY2hlY2sgdHJpZXMgdG8gaWRlbnRpZnkgV2luZG93cyA3IGFuZCBvbGRl ciwKYW5kIExpbnV4LgoKPiAgICAgICAgICAgICAgICAgSWYgKChQSU9GID09IFplcm8pKQo+ICAg ICAgICAgICAgICAgICB7Cj4gICAgICAgICAgICAgICAgICAgICBQMExEID0gT25lCj4gICAgICAg ICAgICAgICAgICAgICBUQ05UID0gWmVybwo+ICAgICAgICAgICAgICAgICAgICAgV2hpbGUgKChU Q05UIDwgTERMWSkpCj4gICAgICAgICAgICAgICAgICAgICB7Cj4gICAgICAgICAgICAgICAgICAg ICAgICAgSWYgKChQMExUID09IDB4MDgpKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHsKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgQnJlYWsKPiAgICAgICAgICAgICAgICAgICAgICAg ICB9Cj4gCj4gICAgICAgICAgICAgICAgICAgICAgICAgU2xlZXAgKDB4MTApCj4gICAgICAgICAg ICAgICAgICAgICAgICAgVENOVCArPSAweDEwCj4gICAgICAgICAgICAgICAgICAgICB9Cj4gCj4g ICAgICAgICAgICAgICAgICAgICBQMFJNID0gT25lCj4gICAgICAgICAgICAgICAgICAgICBQMEFQ ID0gMHgwMwo+ICAgICAgICAgICAgICAgICB9Cj4gICAgICAgICAgICAgICAgIEVsc2VJZiAoKFBJ T0YgPT0gT25lKSkKPiAgICAgICAgICAgICAgICAgewo+ICAgICAgICAgICAgICAgICAgICAgUDFM RCA9IE9uZQo+ICAgICAgICAgICAgICAgICAgICAgVENOVCA9IFplcm8KPiAgICAgICAgICAgICAg ICAgICAgIFdoaWxlICgoVENOVCA8IExETFkpKQo+ICAgICAgICAgICAgICAgICAgICAgewo+ICAg ICAgICAgICAgICAgICAgICAgICAgIElmICgoUDFMVCA9PSAweDA4KSkKPiAgICAgICAgICAgICAg ICAgICAgICAgICB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJyZWFrCj4gICAgICAg ICAgICAgICAgICAgICAgICAgfQo+IAo+ICAgICAgICAgICAgICAgICAgICAgICAgIFNsZWVwICgw eDEwKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIFRDTlQgKz0gMHgxMAo+ICAgICAgICAgICAg ICAgICAgICAgfQo+IAo+ICAgICAgICAgICAgICAgICAgICAgUDFSTSA9IE9uZQo+ICAgICAgICAg ICAgICAgICAgICAgUDFBUCA9IDB4MDMKPiAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAg ICAgICBFbHNlSWYgKChQSU9GID09IDB4MDIpKQo+ICAgICAgICAgICAgICAgICB7Cj4gICAgICAg ICAgICAgICAgICAgICBQMkxEID0gT25lCj4gICAgICAgICAgICAgICAgICAgICBUQ05UID0gWmVy bwo+ICAgICAgICAgICAgICAgICAgICAgV2hpbGUgKChUQ05UIDwgTERMWSkpCj4gICAgICAgICAg ICAgICAgICAgICB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgSWYgKChQMkxUID09IDB4MDgp KQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgQnJlYWsKPiAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4gCj4gICAgICAgICAgICAgICAg ICAgICAgICAgU2xlZXAgKDB4MTApCj4gICAgICAgICAgICAgICAgICAgICAgICAgVENOVCArPSAw eDEwCj4gICAgICAgICAgICAgICAgICAgICB9Cj4gCj4gICAgICAgICAgICAgICAgICAgICBQMlJN ID0gT25lCj4gICAgICAgICAgICAgICAgICAgICBQMkFQID0gMHgwMwo+ICAgICAgICAgICAgICAg ICB9Cj4gCj4gICAgICAgICAgICAgICAgIElmICgoUEJHRSAhPSBaZXJvKSkKPiAgICAgICAgICAg ICAgICAgewo+ICAgICAgICAgICAgICAgICAgICAgSWYgKFNCREwgKFBJT0YpKQo+ICAgICAgICAg ICAgICAgICAgICAgewo+ICAgICAgICAgICAgICAgICAgICAgICAgIE1CREwgPSBHTVhCIChQSU9G KQo+ICAgICAgICAgICAgICAgICAgICAgICAgIFBEVUIgKFBJT0YsIE1CREwpCj4gICAgICAgICAg ICAgICAgICAgICB9Cj4gICAgICAgICAgICAgICAgIH0KPiAgICAgICAgICAgICB9Cj4gICAgICAg ICAgICAgRWxzZQo+ICAgICAgICAgICAgIHsKPiAgICAgICAgICAgICAgICAgTEtEUyAoUElPRikK PiAgICAgICAgICAgICB9Cj4gCj4gICAgICAgICAgICAgSWYgKChEZXJlZk9mIChTQ0xLIFtaZXJv XSkgIT0gWmVybykpCj4gICAgICAgICAgICAgewo+ICAgICAgICAgICAgICAgICBQQ1JPICgweERD LCAweDEwMEMsIERlcmVmT2YgKFNDTEsgW09uZV0pKQo+ICAgICAgICAgICAgICAgICBTbGVlcCAo MHgxMCkKPiAgICAgICAgICAgICB9Cj4gCj4gICAgICAgICAgICAgR1BQUiAoUElPRiwgWmVybykK PiAgICAgICAgICAgICBJZiAoKE9TWVMgIT0gMHgwN0Q5KSkKPiAgICAgICAgICAgICB7Cj4gICAg ICAgICAgICAgICAgIERJV0sgKFBJT0YpCj4gICAgICAgICAgICAgfQo+IAo+ICAgICAgICAgICAg IFxfU0IuU0dPViAoMHgwMTAxMDAwNCwgWmVybykKPiAgICAgICAgICAgICBTbGVlcCAoMHgxNCkK PiAgICAgICAgICAgICBSZXR1cm4gKFplcm8pCj4gICAgICAgICB9Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==