From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Rob Clark <robdclark@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Sharat Masetty <smasetty@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH 3/3] arm64: dts: sdm845: move gpu zap nodes to per-device dts
Date: Tue, 7 Jan 2020 20:57:14 -0800 [thread overview]
Message-ID: <20200108045714.GH738324@yoga> (raw)
In-Reply-To: <20200108013847.899170-4-robdclark@gmail.com>
On Tue 07 Jan 17:38 PST 2020, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> We want to specify per-device firmware-name, so move the zap node into
> the .dts file for individual boards/devices. This lets us get rid of
> the /delete-node/ for cheza, which does not use zap.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1 -
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 7 +++++++
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 ++++++++
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +-----
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 7 +++++++
> 5 files changed, 23 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index 9a4ff57fc877..2db79c1ecdac 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -165,7 +165,6 @@ panel_in_edp: endpoint {
> /delete-node/ &venus_mem;
> /delete-node/ &cdsp_mem;
> /delete-node/ &cdsp_pas;
> -/delete-node/ &zap_shader;
> /delete-node/ &gpu_mem;
>
> /* Increase the size from 120 MB to 128 MB */
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index d100f46791a6..c472195e44fb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -352,6 +352,13 @@ &gcc {
> <GCC_QSPI_CNOC_PERIPH_AHB_CLK>;
> };
>
> +&gpu {
> + zap-shader {
> + memory-region = <&gpu_mem>;
> + firmware-name = "qcom/db845c/a630_zap.mbn";
We agreed upon qcom/sdm845/* for the test-signed 845 firmware :)
> + };
> +};
> +
> &pm8998_gpio {
> vol_up_pin_a: vol-up-active {
> pins = "gpio6";
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index c57548b7b250..876155fc0547 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -360,6 +360,14 @@ &gcc {
> <GCC_LPASS_SWAY_CLK>;
> };
>
> +&gpu {
> + zap-shader {
> + memory-region = <&gpu_mem>;
> + // TODO presumably mtp can use same "test key" signed zap?
Drop this comment after s/db845c/sdm845/
> + firmware-name = "qcom/db845c/a630_zap.mbn";
Apart from that, I think this looks good!
Regards,
Bjorn
> + };
> +};
> +
> &i2c10 {
> status = "okay";
> clock-frequency = <400000>;
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index ddb1f23c936f..601c57cc9b6d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2804,7 +2804,7 @@ dsi1_phy: dsi-phy@ae96400 {
> };
> };
>
> - gpu@5000000 {
> + gpu: gpu@5000000 {
> compatible = "qcom,adreno-630.2", "qcom,adreno";
> #stream-id-cells = <16>;
>
> @@ -2824,10 +2824,6 @@ gpu@5000000 {
>
> qcom,gmu = <&gmu>;
>
> - zap_shader: zap-shader {
> - memory-region = <&gpu_mem>;
> - };
> -
> gpu_opp_table: opp-table {
> compatible = "operating-points-v2";
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 13dc619687f3..b255be3a4a0a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -245,6 +245,13 @@ &gcc {
> <GCC_QSPI_CNOC_PERIPH_AHB_CLK>;
> };
>
> +&gpu {
> + zap-shader {
> + memory-region = <&gpu_mem>;
> + firmware-name = "qcom/LENOVO/81JL/qcdxkmsuc850.mbn";
> + };
> +};
> +
> &i2c1 {
> status = "okay";
> clock-frequency = <400000>;
> --
> 2.24.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-01-08 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 1:38 [PATCH 0/3] drm/msm: use firmware-name to find zap fw Rob Clark
2020-01-08 1:38 ` [PATCH 1/3] drm/msm: support firmware-name for " Rob Clark
2020-01-08 5:00 ` Bjorn Andersson
2020-01-08 18:48 ` Jordan Crouse
2020-01-08 19:04 ` Bjorn Andersson
2020-01-08 1:38 ` [PATCH 2/3] dt-bindings: drm/msm/gpu: Document firmware-name Rob Clark
2020-01-08 4:57 ` Bjorn Andersson
2020-01-08 1:38 ` [PATCH 3/3] arm64: dts: sdm845: move gpu zap nodes to per-device dts Rob Clark
2020-01-08 4:57 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108045714.GH738324@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=smasetty@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).