From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73D0C33CA4 for ; Fri, 10 Jan 2020 13:32:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6F3A2080D for ; Fri, 10 Jan 2020 13:32:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6F3A2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E85836EA17; Fri, 10 Jan 2020 13:32:37 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF0C96EA15; Fri, 10 Jan 2020 13:32:36 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 05:32:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="212265157" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 10 Jan 2020 05:32:33 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 10 Jan 2020 15:32:32 +0200 Date: Fri, 10 Jan 2020 15:32:32 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Mario Kleiner Subject: Re: [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array. Message-ID: <20200110133232.GJ13686@intel.com> References: <20200109150752.28098-1-mario.kleiner.de@gmail.com> <20200109152656.GP1208@intel.com> <20200109153815.GQ1208@intel.com> <20200109164715.GD13686@intel.com> <20200109182408.GF13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mario.kleiner.de@gmail.de, intel-gfx , dri-devel , Daniel Vetter Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 09, 2020 at 09:19:07PM +0100, Mario Kleiner wrote: > On Thu, Jan 9, 2020 at 7:24 PM Ville Syrj=E4l=E4 > wrote: > = > > On Thu, Jan 09, 2020 at 06:57:14PM +0100, Mario Kleiner wrote: > > > On Thu, Jan 9, 2020 at 5:47 PM Ville Syrj=E4l=E4 < > > ville.syrjala@linux.intel.com> > > > wrote: > > > > > > > On Thu, Jan 09, 2020 at 05:30:05PM +0100, Mario Kleiner wrote: > > > > > On Thu, Jan 9, 2020 at 4:38 PM Ville Syrj=E4l=E4 < > > > > ville.syrjala@linux.intel.com> > > > > > wrote: > > > > > > > > = > > wouldn't work if dpcd[0x1] =3D=3D 0xa, which it likely is [*]. AMD DC > > > identified it as DP 1.1, eDP 1.3, and these extended caps seem to be = only > > > part of DP 1.3+ if i understand the comments in > > > intel_dp_extended_receiver_capabilities() correctly. > > > > > Ok, looking at previous debug output logs shows that those extended caps > are not present on the systems, ie. that extended caps bit is not set. So > dpcd[0x1] =3D=3D 0xa. > = > = > > Yeah, but you never know how creative they've been with the DPCD in > > such a propritary machine. A full DPCD dump from /dev/drm_dp_aux* would > > be nice. Can you file a bug an attach the DPCD dump there so we have a > > good reference on what we're talking about (also for future if/when > > someone eventually starts to wonder why we have such hacks in the > > code)? > > > > > True, it's Apple which likes to "Think different..." :/ > = > Will do. But is there a proper/better way to do the /dev/drm_dp_aux0 dump? > I used cat /dev/drm_dp_aux0 > dump, and that hangs, but if i interrupt it > after a few seconds, i get a dump file of 512k size, which seems excessiv= e? > On AMD DC atm., in case that matters. It can take a while to dump the whole thing. If there are errors in some parts (against the spec but some devices simply don't care about the spec) you may need to use ddrescue/etc. to dump everything that can be dumped. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel