* [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC
@ 2019-12-06 11:26 Hans Verkuil
2020-01-08 12:08 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2019-12-06 11:26 UTC (permalink / raw)
To: Maling list - DRI developers; +Cc: Linux Media Mailing List
Add a missing 'depends on DRM' for the DRM_DP_CEC config
option. Without that enabling DRM_DP_CEC will force CEC_CORE
to =y instead of =m if DRM=m as well.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 1168351267fd..e8e478d6da9c 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -163,6 +163,7 @@ config DRM_LOAD_EDID_FIRMWARE
config DRM_DP_CEC
bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
+ depends on DRM
select CEC_CORE
help
Choose this option if you want to enable HDMI CEC support for
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC
2019-12-06 11:26 [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC Hans Verkuil
@ 2020-01-08 12:08 ` Hans Verkuil
2020-01-08 17:42 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2020-01-08 12:08 UTC (permalink / raw)
To: Maling list - DRI developers; +Cc: Daniel Vetter, Linux Media Mailing List
On 12/6/19 12:26 PM, Hans Verkuil wrote:
> Add a missing 'depends on DRM' for the DRM_DP_CEC config
> option. Without that enabling DRM_DP_CEC will force CEC_CORE
> to =y instead of =m if DRM=m as well.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Daniel, can you review this? It's annoying that the cec core is
compiled as part of the kernel when it can just be a module.
Regards,
Hans
> ---
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1168351267fd..e8e478d6da9c 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -163,6 +163,7 @@ config DRM_LOAD_EDID_FIRMWARE
>
> config DRM_DP_CEC
> bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
> + depends on DRM
> select CEC_CORE
> help
> Choose this option if you want to enable HDMI CEC support for
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC
2020-01-08 12:08 ` Hans Verkuil
@ 2020-01-08 17:42 ` Daniel Vetter
2020-01-09 9:11 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2020-01-08 17:42 UTC (permalink / raw)
To: Hans Verkuil
Cc: Daniel Vetter, Maling list - DRI developers, Linux Media Mailing List
On Wed, Jan 08, 2020 at 01:08:47PM +0100, Hans Verkuil wrote:
> On 12/6/19 12:26 PM, Hans Verkuil wrote:
> > Add a missing 'depends on DRM' for the DRM_DP_CEC config
> > option. Without that enabling DRM_DP_CEC will force CEC_CORE
> > to =y instead of =m if DRM=m as well.
> >
> > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>
> Daniel, can you review this? It's annoying that the cec core is
> compiled as part of the kernel when it can just be a module.
Why did we even make this optional? Really worth it to compile out 4
functions and some change?
Anyway the one you really want here is CONFIG_DRM_KMS_HELPER, but that is
a selected variable, and you can't mix select and depends on because that
breaks Kconfig in hilarious ways. Or so I thought, but other public
symbols like this (e.g. DRM_FBDEV_EMULATION) do the same trick. So I guess
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
But really, is all this complexity?
-Daniel
>
> Regards,
>
> Hans
>
> > ---
> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index 1168351267fd..e8e478d6da9c 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -163,6 +163,7 @@ config DRM_LOAD_EDID_FIRMWARE
> >
> > config DRM_DP_CEC
> > bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
> > + depends on DRM
> > select CEC_CORE
> > help
> > Choose this option if you want to enable HDMI CEC support for
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC
2020-01-08 17:42 ` Daniel Vetter
@ 2020-01-09 9:11 ` Hans Verkuil
2020-01-12 22:43 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2020-01-09 9:11 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Vetter, Maling list - DRI developers, Linux Media Mailing List
On 1/8/20 6:42 PM, Daniel Vetter wrote:
> On Wed, Jan 08, 2020 at 01:08:47PM +0100, Hans Verkuil wrote:
>> On 12/6/19 12:26 PM, Hans Verkuil wrote:
>>> Add a missing 'depends on DRM' for the DRM_DP_CEC config
>>> option. Without that enabling DRM_DP_CEC will force CEC_CORE
>>> to =y instead of =m if DRM=m as well.
>>>
>>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>>
>> Daniel, can you review this? It's annoying that the cec core is
>> compiled as part of the kernel when it can just be a module.
>
> Why did we even make this optional? Really worth it to compile out 4
> functions and some change?
It's not about those few functions, it's because this enables the CEC
framework as well (drivers/media/cec).
If CEC is not needed, then disabling this saves a lot more code than the
few functions in drm_dp_cec.c.
CEC is an optional HDMI feature, so CEC support for HDMI input/output
drivers is optional as well in the kernel config.
Regards,
Hans
>
> Anyway the one you really want here is CONFIG_DRM_KMS_HELPER, but that is
> a selected variable, and you can't mix select and depends on because that
> breaks Kconfig in hilarious ways. Or so I thought, but other public
> symbols like this (e.g. DRM_FBDEV_EMULATION) do the same trick. So I guess
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> But really, is all this complexity?
> -Daniel
>
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>>> index 1168351267fd..e8e478d6da9c 100644
>>> --- a/drivers/gpu/drm/Kconfig
>>> +++ b/drivers/gpu/drm/Kconfig
>>> @@ -163,6 +163,7 @@ config DRM_LOAD_EDID_FIRMWARE
>>>
>>> config DRM_DP_CEC
>>> bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
>>> + depends on DRM
>>> select CEC_CORE
>>> help
>>> Choose this option if you want to enable HDMI CEC support for
>>>
>>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC
2020-01-09 9:11 ` Hans Verkuil
@ 2020-01-12 22:43 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2020-01-12 22:43 UTC (permalink / raw)
To: Hans Verkuil
Cc: Daniel Vetter, Maling list - DRI developers, Linux Media Mailing List
On Thu, Jan 09, 2020 at 10:11:48AM +0100, Hans Verkuil wrote:
> On 1/8/20 6:42 PM, Daniel Vetter wrote:
> > On Wed, Jan 08, 2020 at 01:08:47PM +0100, Hans Verkuil wrote:
> >> On 12/6/19 12:26 PM, Hans Verkuil wrote:
> >>> Add a missing 'depends on DRM' for the DRM_DP_CEC config
> >>> option. Without that enabling DRM_DP_CEC will force CEC_CORE
> >>> to =y instead of =m if DRM=m as well.
> >>>
> >>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> >>
> >> Daniel, can you review this? It's annoying that the cec core is
> >> compiled as part of the kernel when it can just be a module.
> >
> > Why did we even make this optional? Really worth it to compile out 4
> > functions and some change?
>
> It's not about those few functions, it's because this enables the CEC
> framework as well (drivers/media/cec).
>
> If CEC is not needed, then disabling this saves a lot more code than the
> few functions in drm_dp_cec.c.
>
> CEC is an optional HDMI feature, so CEC support for HDMI input/output
> drivers is optional as well in the kernel config.
The trouble is that once you have multiple layers of such automatically
optional pieces of code, Kconfig keels over: select isn't recursive. So if
you want to make CEC stuff optional, just compile the DRM stuff only if
both CEC and DRM are enabled, and drivers can then select the overall CEC
stuff. Or alternatively have dummy functions at the CEC library, and just
always compile the DRM CEC stuff in.
You could also fix Kconfig, if you have a life or two to spare :-)
Cheers, Daniel
>
> Regards,
>
> Hans
>
> >
> > Anyway the one you really want here is CONFIG_DRM_KMS_HELPER, but that is
> > a selected variable, and you can't mix select and depends on because that
> > breaks Kconfig in hilarious ways. Or so I thought, but other public
> > symbols like this (e.g. DRM_FBDEV_EMULATION) do the same trick. So I guess
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > But really, is all this complexity?
> > -Daniel
> >
> >>
> >> Regards,
> >>
> >> Hans
> >>
> >>> ---
> >>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> >>> index 1168351267fd..e8e478d6da9c 100644
> >>> --- a/drivers/gpu/drm/Kconfig
> >>> +++ b/drivers/gpu/drm/Kconfig
> >>> @@ -163,6 +163,7 @@ config DRM_LOAD_EDID_FIRMWARE
> >>>
> >>> config DRM_DP_CEC
> >>> bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support"
> >>> + depends on DRM
> >>> select CEC_CORE
> >>> help
> >>> Choose this option if you want to enable HDMI CEC support for
> >>>
> >>
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-12 22:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 11:26 [PATCH] drm/Kconfig: add missing 'depends on DRM' for DRM_DP_CEC Hans Verkuil
2020-01-08 12:08 ` Hans Verkuil
2020-01-08 17:42 ` Daniel Vetter
2020-01-09 9:11 ` Hans Verkuil
2020-01-12 22:43 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).