From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A04C33C9E for ; Tue, 14 Jan 2020 23:58:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04A6B222C4 for ; Tue, 14 Jan 2020 23:58:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04A6B222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BD7F6E5D3; Tue, 14 Jan 2020 23:58:52 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A8BB6E5D4 for ; Tue, 14 Jan 2020 23:58:50 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 15:58:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,320,1574150400"; d="scan'208";a="256517700" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2020 15:58:50 -0800 Date: Tue, 14 Jan 2020 16:00:10 -0800 From: Manasi Navare To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Message-ID: <20200115000009.GD27746@intel.com> References: <20200108003208.18706-1-manasi.d.navare@intel.com> <20200109130852.GN1208@intel.com> <20200110231743.GB16729@intel.com> <20200114003900.GA27746@intel.com> <20200114130756.GV13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200114130756.GV13686@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Kazlauskas , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 14, 2020 at 03:07:56PM +0200, Ville Syrj=E4l=E4 wrote: > On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote: > > Hi Ville, > > = > > So the two major changes you would like to see here are: > > = > > use version_greate(edid) function = > > and make use of : > > drm_for_each_detailed_block() instead of the for loop. > > But this function does not parse the monitor range yet so > > you are suggesting modifying that dmr helper function as well? > = > That functions is just the thing that iterates the descriptors, so > can't figure out what you're asking. My question was on your review comment below where you asked me to use for_each_detailed_block(), were you referring to using the existing drm_for= _each_detailed_block or just defining a new iterator for looping through 4 detailed blocks to ge= t the monitor range? Manasi > = > > = > > Manasi > > = > > On Fri, Jan 10, 2020 at 03:17:43PM -0800, Manasi Navare wrote: > > > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrj=E4l=E4 wrote: > > > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > > > the EDID's detailed descritors to obtain the adaptive sync monito= r range. > > > > > Store this info as part fo drm_display_info so it can be used > > > > > across all drivers. > > > > > This part of the code is stripped out of amdgpu's function > > > > > amdgpu_dm_update_freesync_caps() to make it generic and be used > > > > > across all DRM drivers > > > > > = > > > > > v2: > > > > > * Change vmin and vmax to use u8 (Ville) > > > > > * Dont store pixel clock since that is just a max dotclock > > > > > and not related to VRR mode (Manasi) > > > > > = > > > > > Cc: Ville Syrj=E4l=E4 > > > > > Cc: Harry Wentland > > > > > Cc: Clinton A Taylor > > > > > Cc: Nicholas Kazlauskas > > > > > Signed-off-by: Manasi Navare > > > > > --- > > > > > drivers/gpu/drm/drm_edid.c | 51 +++++++++++++++++++++++++++++++= ++++++ > > > > > include/drm/drm_connector.h | 22 ++++++++++++++++ > > > > > include/drm/drm_edid.h | 2 ++ > > > > > 3 files changed, 75 insertions(+) > > > > > = > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi= d.c > > > > > index 99769d6c9f84..52781a0e708b 100644 > > > > > --- a/drivers/gpu/drm/drm_edid.c > > > > > +++ b/drivers/gpu/drm/drm_edid.c > > > > > @@ -4880,6 +4880,54 @@ static void drm_parse_cea_ext(struct drm_c= onnector *connector, > > > > > } > > > > > } > > > > > = > > > > > +void drm_get_adaptive_sync_limits(struct drm_connector *connecto= r, > > > > > + const struct edid *edid) > > > > > +{ > > > > > + struct drm_display_info *info =3D &connector->display_info; > > > > > + const struct detailed_timing *timing; > > > > > + const struct detailed_non_pixel *data; > > > > > + const struct detailed_data_monitor_range *range; > > > > = > > > > Needlessly wide scope for everything above. > > > = > > > Okay will move inside the for_each loop ? > > > = > > > > = > > > > > + int i; > > > > > + > > > > > + /* > > > > > + * Restrict Adaptive Sync only for dp and edp > > > > > + */ > > > > > + if (connector->connector_type !=3D DRM_MODE_CONNECTOR_DisplayPo= rt && > > > > > + connector->connector_type !=3D DRM_MODE_CONNECTOR_eDP) > > > > > + return; > > > > > + > > > > > + if (edid->version <=3D 1 && !(edid->version =3D=3D 1 && edid->r= evision > 1)) > > > > > + return; > > > > = > > > > if (!version_greater(...)) > > > > return; > > > = > > > You mean simplify the condition or use define a function version_grea= ter() to check this condition? > > > = > > > > = > > > > > + > > > > > + for (i =3D 0; i < 4; i++) { > > > > = > > > > This should probably use for_each_detailed_block() > > > > > > > = > > > = > > > Ok yes will use for_each_detailed_block > > > = > > > Manasi > > > = > > > = > > > > > + timing =3D &edid->detailed_timings[i]; > > > > > + data =3D &timing->data.other_data; > > > > > + range =3D &data->data.range; > > > > > + /* > > > > > + * Check if monitor has continuous frequency mode > > > > > + */ > > > > > + if (data->type !=3D EDID_DETAIL_MONITOR_RANGE) > > > > > + continue; > > > > > + /* > > > > > + * Check for flag range limits only. If flag =3D=3D 1 then > > > > > + * no additional timing information provided. > > > > > + * Default GTF, GTF Secondary curve and CVT are not > > > > > + * supported > > > > > + */ > > > > > + if (range->flags !=3D 1) > > > > > + continue; > > > > > + > > > > > + info->adaptive_sync.min_vfreq =3D range->min_vfreq; > > > > > + info->adaptive_sync.max_vfreq =3D range->max_vfreq; > > > > > + > > > > > + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d = Hz\n", > > > > > + info->adaptive_sync.min_vfreq, > > > > > + info->adaptive_sync.max_vfreq); > > > > > + break; > > > > > + } > > > > > +} > > > > > +EXPORT_SYMBOL(drm_get_adaptive_sync_limits); > > > > > + > > > > > /* A connector has no EDID information, so we've got no EDID to = compute quirks from. Reset > > > > > * all of the values which would have been set from EDID > > > > > */ > > > > > @@ -4901,6 +4949,7 @@ drm_reset_display_info(struct drm_connector= *connector) > > > > > memset(&info->hdmi, 0, sizeof(info->hdmi)); > > > > > = > > > > > info->non_desktop =3D 0; > > > > > + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); > > > > > } > > > > > = > > > > > u32 drm_add_display_info(struct drm_connector *connector, const = struct edid *edid) > > > > > @@ -4916,6 +4965,8 @@ u32 drm_add_display_info(struct drm_connect= or *connector, const struct edid *edi > > > > > = > > > > > info->non_desktop =3D !!(quirks & EDID_QUIRK_NON_DESKTOP); > > > > > = > > > > > + drm_get_adaptive_sync_limits(connector, edid); > > > > > + > > > > > DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); > > > > > = > > > > > if (edid->revision < 3) > > > > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connec= tor.h > > > > > index 221910948b37..77df404a2e01 100644 > > > > > --- a/include/drm/drm_connector.h > > > > > +++ b/include/drm/drm_connector.h > > > > > @@ -254,6 +254,23 @@ enum drm_panel_orientation { > > > > > DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > > > > > }; > > > > > = > > > > > +/** > > > > > + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabil= ities for > > > > > + * &drm_display_info > > > > > + * > > > > > + * This struct is used to store a Panel's Adaptive Sync capabili= ties > > > > > + * as parsed from EDID's detailed monitor range descriptor block. > > > > > + * > > > > > + * @min_vfreq: This is the min supported refresh rate in Hz from > > > > > + * EDID's detailed monitor range. > > > > > + * @max_vfreq: This is the max supported refresh rate in Hz from > > > > > + * EDID's detailed monitor range > > > > > + */ > > > > > +struct drm_adaptive_sync_info { > > > > > + u8 min_vfreq; > > > > > + u8 max_vfreq; > > > > > +}; > > > > > + > > > > > /* > > > > > * This is a consolidated colorimetry list supported by HDMI and > > > > > * DP protocol standard. The respective connectors will register > > > > > @@ -465,6 +482,11 @@ struct drm_display_info { > > > > > * @non_desktop: Non desktop display (HMD). > > > > > */ > > > > > bool non_desktop; > > > > > + > > > > > + /** > > > > > + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink > > > > > + */ > > > > > + struct drm_adaptive_sync_info adaptive_sync; > > > > > }; > > > > > = > > > > > int drm_display_info_set_bus_formats(struct drm_display_info *in= fo, > > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > > > > index f0b03d401c27..b9a230aa3e69 100644 > > > > > --- a/include/drm/drm_edid.h > > > > > +++ b/include/drm/drm_edid.h > > > > > @@ -503,4 +503,6 @@ void drm_edid_get_monitor_name(struct edid *e= did, char *name, > > > > > struct drm_display_mode *drm_mode_find_dmt(struct drm_device *de= v, > > > > > int hsize, int vsize, int fresh, > > > > > bool rb); > > > > > +void drm_get_adaptive_sync_limits(struct drm_connector *connecto= r, > > > > > + const struct edid *edid); > > > > > #endif /* __DRM_EDID_H__ */ > > > > > -- = > > > > > 2.19.1 > > > > = > > > > -- = > > > > Ville Syrj=E4l=E4 > > > > Intel > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > = > -- = > Ville Syrj=E4l=E4 > Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel