From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F85C33C9E for ; Wed, 15 Jan 2020 00:01:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D305624671 for ; Wed, 15 Jan 2020 00:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D305624671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34AE86E5D4; Wed, 15 Jan 2020 00:01:39 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76E5D6E5D4 for ; Wed, 15 Jan 2020 00:01:36 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 16:01:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,320,1574150400"; d="scan'208";a="219091069" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga007.fm.intel.com with ESMTP; 14 Jan 2020 16:01:35 -0800 Date: Tue, 14 Jan 2020 16:02:55 -0800 From: Manasi Navare To: Harry Wentland Subject: Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Message-ID: <20200115000255.GE27746@intel.com> References: <20200108003208.18706-1-manasi.d.navare@intel.com> <87y2ugodox.fsf@intel.com> <20200110224338.GA16729@intel.com> <5d1ef8d1-4ef2-6b85-2893-d1c2276e4b70@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5d1ef8d1-4ef2-6b85-2893-d1c2276e4b70@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, "Kazlauskas, Nicholas" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 14, 2020 at 08:31:22AM -0500, Harry Wentland wrote: > Fixing Nick's email. > = > On 2020-01-10 5:43 p.m., Manasi Navare wrote: > > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > >> On Tue, 07 Jan 2020, Manasi Navare wrote: > >>> Adaptive Sync is a VESA feature so add a DRM core helper to parse > >>> the EDID's detailed descritors to obtain the adaptive sync monitor ra= nge. > >>> Store this info as part fo drm_display_info so it can be used > >>> across all drivers. > >>> This part of the code is stripped out of amdgpu's function > >>> amdgpu_dm_update_freesync_caps() to make it generic and be used > >>> across all DRM drivers > >>> > >>> v2: > >>> * Change vmin and vmax to use u8 (Ville) > >>> * Dont store pixel clock since that is just a max dotclock > >>> and not related to VRR mode (Manasi) > >>> > >>> Cc: Ville Syrj=E4l=E4 > >>> Cc: Harry Wentland > >>> Cc: Clinton A Taylor > >>> Cc: Nicholas Kazlauskas > >>> Signed-off-by: Manasi Navare > >>> --- > >>> drivers/gpu/drm/drm_edid.c | 51 +++++++++++++++++++++++++++++++++++= ++ > >>> include/drm/drm_connector.h | 22 ++++++++++++++++ > >>> include/drm/drm_edid.h | 2 ++ > >>> 3 files changed, 75 insertions(+) > >>> > >>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > >>> index 99769d6c9f84..52781a0e708b 100644 > >>> --- a/drivers/gpu/drm/drm_edid.c > >>> +++ b/drivers/gpu/drm/drm_edid.c > >>> @@ -4880,6 +4880,54 @@ static void drm_parse_cea_ext(struct drm_conne= ctor *connector, > >>> } > >>> } > >>> = > >>> +void drm_get_adaptive_sync_limits(struct drm_connector *connector, > >>> + const struct edid *edid) > >>> +{ > >>> + struct drm_display_info *info =3D &connector->display_info; > >>> + const struct detailed_timing *timing; > >>> + const struct detailed_non_pixel *data; > >>> + const struct detailed_data_monitor_range *range; > >>> + int i; > >>> + > >>> + /* > >>> + * Restrict Adaptive Sync only for dp and edp > >>> + */ > >>> + if (connector->connector_type !=3D DRM_MODE_CONNECTOR_DisplayPort && > >>> + connector->connector_type !=3D DRM_MODE_CONNECTOR_eDP) > >>> + return; > >>> + > >>> + if (edid->version <=3D 1 && !(edid->version =3D=3D 1 && edid->revis= ion > 1)) > >>> + return; > >>> + > >>> + for (i =3D 0; i < 4; i++) { > >>> + timing =3D &edid->detailed_timings[i]; > >>> + data =3D &timing->data.other_data; > >>> + range =3D &data->data.range; > >>> + /* > >>> + * Check if monitor has continuous frequency mode > >>> + */ > >>> + if (data->type !=3D EDID_DETAIL_MONITOR_RANGE) > >>> + continue; > >>> + /* > >>> + * Check for flag range limits only. If flag =3D=3D 1 then > >>> + * no additional timing information provided. > >>> + * Default GTF, GTF Secondary curve and CVT are not > >>> + * supported > >>> + */ > >>> + if (range->flags !=3D 1) > >>> + continue; > >>> + > >>> + info->adaptive_sync.min_vfreq =3D range->min_vfreq; > >>> + info->adaptive_sync.max_vfreq =3D range->max_vfreq; > >>> + > >>> + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d Hz\n= ", > >>> + info->adaptive_sync.min_vfreq, > >>> + info->adaptive_sync.max_vfreq); > >>> + break; > >>> + } > >>> +} > >>> +EXPORT_SYMBOL(drm_get_adaptive_sync_limits); > >> > >> Why the export? Rather, why is this not static? > >> > > = > > I could make it static but since the way AMDGPU code is written right n= ow they > > would be calling this function explicitly to populate the vmin and vmax= in their local > > structs but I can make it static and with some minor refactoring they s= hould be able to > > use thsi infor directly from drm_display_info > > = > = > Calling this through drm_add_edid_modes should be sufficient for us. > We'll just need to move amdgpu_dm_update_freesync_caps to our get_modes > function. Thanks Harry, Would you or Nick make these changes as follow up changes aft= er this patch lands? Since it might be easier for you to figure out where to accomodate the chan= ges in amdgpu. Manasi > = > Dropping the export here seems to be the right thing to do. > = > Harry > = > > Manasi > > = > >> BR, > >> Jani. > >> > >>> + > >>> /* A connector has no EDID information, so we've got no EDID to comp= ute quirks from. Reset > >>> * all of the values which would have been set from EDID > >>> */ > >>> @@ -4901,6 +4949,7 @@ drm_reset_display_info(struct drm_connector *co= nnector) > >>> memset(&info->hdmi, 0, sizeof(info->hdmi)); > >>> = > >>> info->non_desktop =3D 0; > >>> + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); > >>> } > >>> = > >>> u32 drm_add_display_info(struct drm_connector *connector, const stru= ct edid *edid) > >>> @@ -4916,6 +4965,8 @@ u32 drm_add_display_info(struct drm_connector *= connector, const struct edid *edi > >>> = > >>> info->non_desktop =3D !!(quirks & EDID_QUIRK_NON_DESKTOP); > >>> = > >>> + drm_get_adaptive_sync_limits(connector, edid); > >>> + > >>> DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); > >>> = > >>> if (edid->revision < 3) > >>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > >>> index 221910948b37..77df404a2e01 100644 > >>> --- a/include/drm/drm_connector.h > >>> +++ b/include/drm/drm_connector.h > >>> @@ -254,6 +254,23 @@ enum drm_panel_orientation { > >>> DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > >>> }; > >>> = > >>> +/** > >>> + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabilitie= s for > >>> + * &drm_display_info > >>> + * > >>> + * This struct is used to store a Panel's Adaptive Sync capabilities > >>> + * as parsed from EDID's detailed monitor range descriptor block. > >>> + * > >>> + * @min_vfreq: This is the min supported refresh rate in Hz from > >>> + * EDID's detailed monitor range. > >>> + * @max_vfreq: This is the max supported refresh rate in Hz from > >>> + * EDID's detailed monitor range > >>> + */ > >>> +struct drm_adaptive_sync_info { > >>> + u8 min_vfreq; > >>> + u8 max_vfreq; > >>> +}; > >>> + > >>> /* > >>> * This is a consolidated colorimetry list supported by HDMI and > >>> * DP protocol standard. The respective connectors will register > >>> @@ -465,6 +482,11 @@ struct drm_display_info { > >>> * @non_desktop: Non desktop display (HMD). > >>> */ > >>> bool non_desktop; > >>> + > >>> + /** > >>> + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink > >>> + */ > >>> + struct drm_adaptive_sync_info adaptive_sync; > >>> }; > >>> = > >>> int drm_display_info_set_bus_formats(struct drm_display_info *info, > >>> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > >>> index f0b03d401c27..b9a230aa3e69 100644 > >>> --- a/include/drm/drm_edid.h > >>> +++ b/include/drm/drm_edid.h > >>> @@ -503,4 +503,6 @@ void drm_edid_get_monitor_name(struct edid *edid,= char *name, > >>> struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, > >>> int hsize, int vsize, int fresh, > >>> bool rb); > >>> +void drm_get_adaptive_sync_limits(struct drm_connector *connector, > >>> + const struct edid *edid); > >>> #endif /* __DRM_EDID_H__ */ > >> > >> -- = > >> Jani Nikula, Intel Open Source Graphics Center > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel